From 4c4c6f5de230c3047ce236f2de7f060b05b457d5 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Thu, 28 May 2026 11:35:41 +0100
Subject: [PATCH] build fixes

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
---
 src/xrpld/app/main/GRPCServer.cpp      | 3 ++-
 src/xrpld/rpc/detail/RPCHandler.cpp    | 4 +++-
 src/xrpld/rpc/detail/ServerHandler.cpp | 4 ++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/xrpld/app/main/GRPCServer.cpp b/src/xrpld/app/main/GRPCServer.cpp
index d0019b79f9..fb92a55dde 100644
--- a/src/xrpld/app/main/GRPCServer.cpp
+++ b/src/xrpld/app/main/GRPCServer.cpp
@@ -192,7 +192,8 @@ GRPCServerImpl::CallData<Request, Response>::process(std::shared_ptr<JobQueue::C
 
             span.setAttribute(
                 grpc_span::attr::grpcRole,
-                role == Role::ADMIN ? grpc_span::val::admin : grpc_span::val::user);
+                role == Role::ADMIN ? std::string_view(grpc_span::val::admin)
+                                    : std::string_view(grpc_span::val::user));
 
             {
                 std::stringstream toLog;
diff --git a/src/xrpld/rpc/detail/RPCHandler.cpp b/src/xrpld/rpc/detail/RPCHandler.cpp
index 1eca97cd52..16ffa8de11 100644
--- a/src/xrpld/rpc/detail/RPCHandler.cpp
+++ b/src/xrpld/rpc/detail/RPCHandler.cpp
@@ -188,7 +188,9 @@ callMethod(JsonContext& context, Method method, std::string const& name, Object&
         // Status::operator bool() returns true when there IS an error
         // (code_ != OK), so the ternary correctly maps error->error, ok->success.
         span.setAttribute(
-            rpc_span::attr::rpcStatus, ret ? rpc_span::val::error : rpc_span::val::success);
+            rpc_span::attr::rpcStatus,
+            ret ? std::string_view(rpc_span::val::error)
+                : std::string_view(rpc_span::val::success));
         if (!ret)
             span.setOk();
         return ret;
diff --git a/src/xrpld/rpc/detail/ServerHandler.cpp b/src/xrpld/rpc/detail/ServerHandler.cpp
index 4f1918076c..dca713b1a7 100644
--- a/src/xrpld/rpc/detail/ServerHandler.cpp
+++ b/src/xrpld/rpc/detail/ServerHandler.cpp
@@ -355,7 +355,7 @@ ServerHandler::onWSMessage(
         Json::Value jvResult(Json::objectValue);
         jvResult[jss::type] = jss::error;
         jvResult[jss::error] = "jsonInvalid";
-        jvResult[jss::value] = buffers_to_string(buffers);
+        jvResult[jss::value] = ::xrpl::buffers_to_string(buffers);
         boost::beast::multi_buffer sb;
         Json::stream(jvResult, [&sb](auto const p, auto const n) {
             sb.commit(boost::asio::buffer_copy(sb.prepare(n), boost::asio::buffer(p, n)));
@@ -579,7 +579,7 @@ ServerHandler::processSession(
 
     processRequest(
         session->port(),
-        buffers_to_string(session->request().body().data()),
+        ::xrpl::buffers_to_string(session->request().body().data()),
         session->remoteAddress().at_port(0),
         makeOutput(*session),
         coro,