From 4c05d69a4ac0454cc0e2b18f037976fded10ef84 Mon Sep 17 00:00:00 2001 From: Bart <11445373+bthomee@users.noreply.github.com> Date: Fri, 11 Sep 2026 15:38:52 -0400 Subject: [PATCH] test: Update SHAMapTraversal comment to reflect Release-build checks PR 7944 converted the XRPL_ASSERT guards in NodePathStack to UNREACHABLE + return false, so the pairing checks now fail in both Debug and Release builds, not just Debug. Update the comment to reflect this change. Co-Authored-By: Claude Haiku 4.5 --- src/tests/libxrpl/shamap/SHAMap.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tests/libxrpl/shamap/SHAMap.cpp b/src/tests/libxrpl/shamap/SHAMap.cpp index e549e969fe..1072d18655 100644 --- a/src/tests/libxrpl/shamap/SHAMap.cpp +++ b/src/tests/libxrpl/shamap/SHAMap.cpp @@ -273,8 +273,8 @@ INSTANTIATE_TEST_SUITE_P( shamapBackingModeName); // Exercises the traversal stacks built by belowHelper. Each stack entry pairs a node with the ID -// naming its position, and SHAMap asserts that pairing on every push, so these traversals fail -// loudly in a Debug build if a node ID is ever derived from the wrong branch. +// naming its position, and SHAMap enforces that pairing on every push, failing if a node ID is +// ever derived from the wrong branch (both Debug and Release builds). class SHAMapTraversal : public ::testing::Test { protected: