From 4bbe28cb92eff50a4f9874d5e7a76844aacc9d1f Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Wed, 13 May 2026 12:11:52 +0100 Subject: [PATCH] fix(consensus): restore DisputedTx getYays/getNays accessors Consensus.h (Phase 4 tracing) depends on DisputedTx::getYays()/getNays() to build disputeResolve span events. Both accessors were removed by earlier 'duplicate accessor' cleanup commits on this branch, leaving Consensus.h referencing non-existent members. CI caught this on macOS/clang-17/gcc-13/Windows builds. Restore the accessors on the branch where they were dropped so downstream phase branches inherit a compiling DisputedTx.h via merge. Co-Authored-By: Claude Opus 4.7 --- src/xrpld/consensus/DisputedTx.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/xrpld/consensus/DisputedTx.h b/src/xrpld/consensus/DisputedTx.h index aff4ccae68..97cd766eb1 100644 --- a/src/xrpld/consensus/DisputedTx.h +++ b/src/xrpld/consensus/DisputedTx.h @@ -60,6 +60,20 @@ public: return ourVote_; } + //! Number of peers voting to include the transaction. + [[nodiscard]] int + getYays() const + { + return yays_; + } + + //! Number of peers voting to exclude the transaction. + [[nodiscard]] int + getNays() const + { + return nays_; + } + //! Are we and our peers "stalled" where we probably won't change //! our vote? [[nodiscard]] bool