Remove using-namespace-directives at global scope

TODO.txt

@@ -4,13 +4,6 @@ TODO
 
 - Remove "ENABLE_INSECURE" when the time is right.
 
-- Put all the Ripple code in the ripple namespace
-  * boost unit tests create namespace problems
-
-- Remove references to BEASTApplication
-
-- Remove "using namespace" statements
-
 - lift bind, function, and placeholders into ripple namespace
 - lift beast into the ripple namespace, remove ripple's duplicated integer types
 - lift unique_ptr / auto_ptr into ripple namespace, or replace with ScopedPointer

src/cpp/ripple/PeerDoor.cpp

@@ -6,12 +6,9 @@
 
 SETUP_LOG (PeerDoor)
 
-using namespace std;
-using namespace boost::asio::ip;
-
 PeerDoor::PeerDoor (boost::asio::io_service& io_service) :
     mAcceptor (io_service,
-               tcp::endpoint (address ().from_string (theConfig.PEER_IP.empty () ? "0.0.0.0" : theConfig.PEER_IP),
+               boost::asio::ip::tcp::endpoint (boost::asio::ip::address ().from_string (theConfig.PEER_IP.empty () ? "0.0.0.0" : theConfig.PEER_IP),
                               theConfig.PEER_PORT)),
     mCtx (boost::asio::ssl::context::sslv23), mDelayTimer (io_service)
 {

src/cpp/ripple/RPCDoor.cpp

@@ -6,15 +6,14 @@
 
 SETUP_LOG (RPCDoor)
 
-using namespace std;
-using namespace boost::asio::ip;
-
 extern void initSSLContext (boost::asio::ssl::context& context,
                             std::string key_file, std::string cert_file, std::string chain_file);
 
-RPCDoor::RPCDoor (boost::asio::io_service& io_service) :
+RPCDoor::RPCDoor (boost::asio::io_service& io_service)
-    mAcceptor (io_service, tcp::endpoint (address::from_string (theConfig.RPC_IP), theConfig.RPC_PORT)),
+    : mAcceptor (io_service,
-    mDelayTimer (io_service), mSSLContext (boost::asio::ssl::context::sslv23)
+                 boost::asio::ip::tcp::endpoint (boost::asio::ip::address::from_string (theConfig.RPC_IP), theConfig.RPC_PORT))
+    , mDelayTimer (io_service)
+    , mSSLContext (boost::asio::ssl::context::sslv23)
 {
     WriteLog (lsINFO, RPCDoor) << "RPC port: " << theConfig.RPC_IP << " " << theConfig.RPC_PORT << " allow remote: " << theConfig.RPC_ALLOW_REMOTE;
 

src/cpp/ripple/main.cpp

@@ -10,9 +10,6 @@ namespace po = boost::program_options;
 extern void TFInit ();
 extern void LEFInit ();
 
-using namespace std;
-using namespace boost::unit_test;
-
 void setupServer ()
 {
     theApp = IApplication::New ();
@@ -56,6 +53,8 @@ bool init_unit_test ()
 
 void printHelp (const po::options_description& desc)
 {
+    using namespace std;
+
     cerr << SYSTEM_NAME "d [options] <command> <params>" << endl;
 
     cerr << desc << endl;
@@ -121,6 +120,8 @@ void printHelp (const po::options_description& desc)
 
 int rippleMain (int argc, char** argv)
 {
+    using namespace std;
+
     setCallingThreadName ("main");
     int                 iResult = 0;
     po::variables_map   vm;                                     // Map of options.
@@ -214,7 +215,7 @@ int rippleMain (int argc, char** argv)
 
     if (vm.count ("unittest"))
     {
-        unit_test_main (init_unit_test, argc, argv);
+        boost::unit_test::unit_test_main (init_unit_test, argc, argv);
 
         return 0;
     }

src/cpp/ripple/rpc.cpp

@@ -5,15 +5,10 @@
 //==============================================================================
 
 // Used for logging
-struct RPC
+struct RPC;
-{
-};
 
 SETUP_LOG (RPC)
 
-using namespace boost;
-using namespace boost::asio;
-
 unsigned int const gMaxHTTPHeaderSize = 0x02000000;
 
 std::string gFormatStr ("v1");