ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve ledger-fetching logic:

Browse Source 
When fetching ledgers, the existing code would isolate the peer
that sent the most useful responses and issue follow up queries
only to that peer.

This commit increases the query aggressiveness, and changes the
mechanism used to select which peers to issue follow-up queries
to so as to more evenly spread the load along those peers which
provided useful responses.
This commit is contained in:
Nik Bougalis
2021-12-19 23:47:33 -08:00
parent 1b9387eddc
commit 48803a48af
8 changed files with 170 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/test/shamap/SHAMapSync_test.cpp
View File

@@ -124,24 +124,18 @@ public:
destination.setSynching();
{
std::vector<SHAMapNodeID> gotNodeIDs_a;
std::vector<Blob> gotNodes_a;
std::vector<std::pair<SHAMapNodeID, Blob>> a;
BEAST_EXPECT(source.getNodeFat(
SHAMapNodeID(),
gotNodeIDs_a,
gotNodes_a,
rand_bool(eng_),
rand_int(eng_, 2)));
SHAMapNodeID(), a, rand_bool(eng_), rand_int(eng_, 2)));
unexpected(gotNodes_a.size() < 1, "NodeSize");
unexpected(a.size() < 1, "NodeSize");
BEAST_EXPECT(destination
.addRootNode(
source.getHash(),
makeSlice(*gotNodes_a.begin()),
nullptr)
.isGood());
BEAST_EXPECT(
destination
.addRootNode(
source.getHash(), makeSlice(a[0].second), nullptr)
.isGood());
}
do
@@ -155,8 +149,7 @@ public:
break;
// get as many nodes as possible based on this information
std::vector<SHAMapNodeID> gotNodeIDs_b;
std::vector<Blob> gotNodes_b;
std::vector<std::pair<SHAMapNodeID, Blob>> b;
for (auto& it : nodesMissing)
{
@@ -164,29 +157,24 @@ public:
// non-deterministic number of times and the number of tests run
// should be deterministic
if (!source.getNodeFat(
it.first,
gotNodeIDs_b,
gotNodes_b,
rand_bool(eng_),
rand_int(eng_, 2)))
it.first, b, rand_bool(eng_), rand_int(eng_, 2)))
fail("", __FILE__, __LINE__);
}
// Don't use BEAST_EXPECT here b/c it will be called a
// non-deterministic number of times and the number of tests run
// should be deterministic
if (gotNodeIDs_b.size() != gotNodes_b.size() ||
gotNodeIDs_b.empty())
if (b.empty())
fail("", __FILE__, __LINE__);
for (std::size_t i = 0; i < gotNodeIDs_b.size(); ++i)
for (std::size_t i = 0; i < b.size(); ++i)
{
// Don't use BEAST_EXPECT here b/c it will be called a
// non-deterministic number of times and the number of tests run
// should be deterministic
if (!destination
.addKnownNode(
gotNodeIDs_b[i], makeSlice(gotNodes_b[i]), nullptr)
b[i].first, makeSlice(b[i].second), nullptr)
.isUseful())
fail("", __FILE__, __LINE__);
}