diff --git a/.github/scripts/otel-naming/check_otel_naming.py b/.github/scripts/otel-naming/check_otel_naming.py index 41e8748075..a5ed07c0e4 100644 --- a/.github/scripts/otel-naming/check_otel_naming.py +++ b/.github/scripts/otel-naming/check_otel_naming.py @@ -822,6 +822,8 @@ def run_rule_d_dashboards( "service_instance_id", "job", "instance", + "xrpl_branch", # perf-iac identity label: git ref of the build under test + "xrpl_node_role", # perf-iac identity label: validator/peer role in the perf cluster } # A dashboard label is valid if it is a span attribute (L1), a native-metric # label (L6), or a Prometheus/Grafana builtin. diff --git a/.github/scripts/otel-naming/test_check_otel_naming.py b/.github/scripts/otel-naming/test_check_otel_naming.py index cf042b877b..e22c31c54e 100644 --- a/.github/scripts/otel-naming/test_check_otel_naming.py +++ b/.github/scripts/otel-naming/test_check_otel_naming.py @@ -744,6 +744,12 @@ class RuleDDashboards(unittest.TestCase): [], ) + def test_perf_iac_identity_labels_not_flagged(self): + self.assertEqual( + self._run('"expr": "sum by (xrpl_branch, xrpl_node_role) (x)"', set()), + [], + ) + def test_prometheus_name_label_not_flagged(self): # `__name__` is the Prometheus reserved metric-name label; the renamed # system-*.json dashboards use `sum by (le, __name__)`.