ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modernize code:

Browse Source 
* Clean STBase-derived class creation interfaces
* Annotate overriden STBase virtual functions
* Optimize path deserialization
* Prefer range-based for
* Prefer std::unique_ptr
* Remove BOOST_FOREACH
This commit is contained in:
Nik Bougalis
2014-12-31 22:02:14 -08:00
parent e742da73bd
commit 47593730d6
43 changed files with 638 additions and 547 deletions
Download Patch File Download Diff File Expand all files Collapse all files

109
src/ripple/protocol/STBitString.h
View File

@@ -25,57 +25,71 @@
namespace ripple {
template <std::size_t Bits>
class STBitString : public STBase
class STBitString final
: public STBase
{
public:
typedef base_uint<Bits> BitString;
STBitString () {}
STBitString (SField::ref n) : STBase (n) {}
STBitString (const BitString& v) : bitString_ (v) {}
STBitString () = default;
STBitString (SField::ref n)
: STBase (n)
{ }
STBitString (const BitString& v)
: bitString_ (v)
{ }
STBitString (SField::ref n, const BitString& v)
: STBase (n), bitString_ (v)
{
}
: STBase (n), bitString_ (v)
{ }
STBitString (SField::ref n, const char* v) : STBase (n)
STBitString (SField::ref n, const char* v)
: STBase (n)
{
bitString_.SetHex (v);
}
STBitString (SField::ref n, std::string const& v) : STBase (n)
STBitString (SField::ref n, std::string const& v)
: STBase (n)
{
bitString_.SetHex (v);
}
static std::unique_ptr<STBase> deserialize (
SerializerIterator& sit, SField::ref name)
static
std::unique_ptr<STBase>
deserialize (SerializerIterator& sit, SField::ref name)
{
return std::unique_ptr<STBase> (construct (sit, name));
return std::make_unique<STBitString> (name, sit.getBitString<Bits> ());
}
SerializedTypeID getSType () const;
SerializedTypeID
getSType () const override;
std::string getText () const
std::string
getText () const override
{
return to_string (bitString_);
}
bool isEquivalent (const STBase& t) const
bool
isEquivalent (const STBase& t) const override
{
const STBitString* v = dynamic_cast<const STBitString*> (&t);
return v && (bitString_ == v->bitString_);
}
void add (Serializer& s) const
void
add (Serializer& s) const override
{
assert (fName->isBinary ());
assert (fName->fieldType == getSType());
s.addBitString<Bits> (bitString_);
}
const BitString& getValue () const
const BitString&
getValue () const
{
return bitString_;
}
@@ -91,47 +105,50 @@ public:
return bitString_;
}
virtual bool isDefault () const
bool
isDefault () const override
{
return bitString_ == zero;
}
std::unique_ptr<STBase>
duplicate () const override
{
return std::make_unique<STBitString>(*this);
}
private:
BitString bitString_;
STBitString* duplicate () const
{
return new STBitString (*this);
}
static STBitString* construct (SerializerIterator& u, SField::ref name)
{
return new STBitString (name, u.getBitString<Bits> ());
}
};
template <>
inline SerializedTypeID STBitString<128>::getSType () const
{
return STI_HASH128;
}
template <>
inline SerializedTypeID STBitString<160>::getSType () const
{
return STI_HASH160;
}
template <>
inline SerializedTypeID STBitString<256>::getSType () const
{
return STI_HASH256;
}
using STHash128 = STBitString<128>;
using STHash160 = STBitString<160>;
using STHash256 = STBitString<256>;
template <>
inline
SerializedTypeID
STHash128::getSType () const
{
return STI_HASH128;
}
template <>
inline
SerializedTypeID
STHash160::getSType () const
{
return STI_HASH160;
}
template <>
inline
SerializedTypeID
STHash256::getSType () const
{
return STI_HASH256;
}
} // ripple
#endif