Merge branch 'pratik/otel-phase4-consensus-tracing' into pratik/otel-phase5-docs-deployment

Bring phase-4 forward into phase 5 (docs & deployment). Phase 5 owns the
operator runbook (docs/telemetry-runbook.md).

Conflict resolution:
- 05-configuration-reference.md: took phase-4's code-block-free prose for the
  config-parser section; the mTLS options (tls_client_cert/tls_client_key)
  remain documented in the §5.1.2 options table.

Phase-5-owned naming fix:
- docs/telemetry-runbook.md: converted 20 dotted xrpl.<domain>. attribute keys
  in the Span Reference tables to the underscore convention (tx_hash, peer_id,
  ledger_seq, consensus_mode/round/round_id/ledger_id, tx_id). Span NAMES stay
  dotted (rule 5). `trusted` left as-is — verified it matches the code constant
  ConsensusSpanNames.h (the proposal_trusted/validation_trusted split is a
  separate, not-yet-applied code change).

End-to-end reconciliation: every span-attribute token in the runbook (L5) now
matches an L1 *SpanNames.h constant. The xrpl_<domain>_<field> tokens are the
spanmetrics-derived Prometheus labels (documented mapping), not span attrs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

include/xrpl/protocol/AMMCore.h

@@ -65,7 +65,7 @@ invalidAMMAssetPair(
 std::optional<std::uint8_t>
 ammAuctionTimeSlot(std::uint64_t current, STObject const& auctionSlot);
 
-/** Return true if required AMM amendments are enabled
+/** Return true if required AMM amendment is enabled
  */
 bool
 ammEnabled(Rules const&);

include/xrpl/protocol/IOUAmount.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <xrpl/basics/LocalValue.h>
 #include <xrpl/basics/Number.h>
 #include <xrpl/beast/utility/Zero.h>
 
@@ -179,36 +178,4 @@ to_string(IOUAmount const& amount);
 IOUAmount
 mulRatio(IOUAmount const& amt, std::uint32_t num, std::uint32_t den, bool roundUp);
 
-// Since many uses of the number class do not have access to a ledger,
-// getSTNumberSwitchover needs to be globally accessible.
-
-bool
-getSTNumberSwitchover();
-
-void
-setSTNumberSwitchover(bool v);
-
-/** RAII class to set and restore the Number switchover.
- */
-
-class NumberSO
-{
-    bool saved_;
-
-public:
-    ~NumberSO()
-    {
-        setSTNumberSwitchover(saved_);
-    }
-
-    NumberSO(NumberSO const&) = delete;
-    NumberSO&
-    operator=(NumberSO const&) = delete;
-
-    explicit NumberSO(bool v) : saved_(getSTNumberSwitchover())
-    {
-        setSTNumberSwitchover(v);
-    }
-};
-
 }  // namespace xrpl

include/xrpl/protocol/Rules.h

@@ -122,7 +122,6 @@ private:
     std::optional<Rules> saved_;
 };
 
-class NumberSO;
 class NumberMantissaScaleGuard;
 
 bool
@@ -131,7 +130,6 @@ useRulesGuards(Rules const& rules);
 void
 createGuards(
     Rules const& rules,
-    std::optional<NumberSO>& stNumberSO,
     std::optional<CurrentTransactionRulesGuard>& rulesGuard,
     std::optional<NumberMantissaScaleGuard>& mantissaScaleGuard);
 

include/xrpl/protocol/detail/features.macro

@@ -15,6 +15,7 @@
 // Add new amendments to the top of this list.
 // Keep it sorted in reverse chronological order.
 
+XRPL_FIX    (Cleanup3_3_0,                Supported::Yes, VoteBehavior::DefaultNo)
 XRPL_FIX    (Cleanup3_2_0,                Supported::Yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(MPTokensV2,                  Supported::No,  VoteBehavior::DefaultNo)
 XRPL_FIX    (Cleanup3_1_3,                Supported::Yes, VoteBehavior::DefaultYes)
@@ -64,7 +65,6 @@ XRPL_FIX    (DisallowIncomingV1,         Supported::Yes, VoteBehavior::DefaultNo
 XRPL_FEATURE(XChainBridge,               Supported::Yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(AMM,                        Supported::Yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(Clawback,                   Supported::Yes, VoteBehavior::DefaultNo)
-XRPL_FIX    (UniversalNumber,            Supported::Yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(XRPFees,                    Supported::Yes, VoteBehavior::DefaultNo)
 XRPL_FIX    (RemoveNFTokenAutoTrustLine, Supported::Yes, VoteBehavior::DefaultYes)
 
@@ -112,6 +112,7 @@ XRPL_RETIRE_FIX(RmSmallIncreasedQOffers)
 XRPL_RETIRE_FIX(STAmountCanonicalize)
 XRPL_RETIRE_FIX(TakerDryOfferRemoval)
 XRPL_RETIRE_FIX(TrustLinesToSelf)
+XRPL_RETIRE_FIX(UniversalNumber)
 
 XRPL_RETIRE_FEATURE(Checks)
 XRPL_RETIRE_FEATURE(CheckCashMakesTrustLine)

include/xrpl/telemetry/SpanGuard.h

@@ -56,8 +56,8 @@
         using namespace xrpl::telemetry;
 
         auto span = SpanGuard::span(
-            TraceCategory::Rpc, rpc_span::prefix::command, "submit");
-        span.setAttribute(rpc_span::attr::command, "submit");
+            TraceCategory::Rpc, rpc_span::prefix::command, commandName);
+        span.setAttribute(rpc_span::attr::command, commandName);
         span.setAttribute(rpc_span::attr::rpcStatus, rpc_span::val::success);
         // span ended automatically on scope exit
     @endcode
@@ -65,7 +65,7 @@
     2. Error recording:
     @code
         auto span = SpanGuard::span(
-            TraceCategory::Rpc, rpc_span::prefix::command, "submit");
+            TraceCategory::Rpc, rpc_span::prefix::command, commandName);
         try {
             doWork();
             span.setOk();
@@ -76,16 +76,16 @@
 
     3. Cross-thread context propagation:
     @code
-        #include <xrpld/consensus/ConsensusSpanNames.h>
+        #include <xrpld/rpc/detail/RpcSpanNames.h>
         using namespace xrpl::telemetry;
 
         // Thread A: create span and capture context
         auto span = SpanGuard::span(
-            TraceCategory::Consensus, seg::consensus, consensus::span::op::round);
+            TraceCategory::Rpc, rpc_span::prefix::rpc, rpc_span::op::process);
         auto ctx = span.captureContext();
 
         // Thread B: create child with captured context
-        auto child = SpanGuard::childSpan(consensus::span::accept, ctx);
+        auto child = SpanGuard::childSpan(rpc_span::op::process, ctx);
     @endcode
 
     4. Conditional check (rarely needed — methods are no-ops on null):

include/xrpl/telemetry/Telemetry.h

@@ -52,19 +52,22 @@
 
     2. Child span for a sub-operation (scoped child):
     @code
-        auto parent = SpanGuard::span(TraceCategory::Transactions, "tx", "process");
+        auto parent = SpanGuard::span(
+            TraceCategory::Rpc, rpc_span::prefix::rpc, rpc_span::op::process);
         {
-            auto child = parent.childSpan("tx.apply");
-            child.setAttribute("tx_type", txType);
+            auto child = parent.childSpan(rpc_span::op::process);
+            child.setAttribute(rpc_span::attr::version, apiVersion);
             // child ends here
         }
     @endcode
 
     3. Unrelated span (cross-scope, same thread):
     @code
-        // Transactions and RPC can be active simultaneously
-        auto txSpan = SpanGuard::span(TraceCategory::Transactions, "tx", "process");
-        auto rpcSpan = SpanGuard::span(TraceCategory::Rpc, "rpc", "info");
+        // gRPC and RPC handlers can be active simultaneously
+        auto grpcSpan = SpanGuard::span(
+            TraceCategory::Rpc, grpc_span::prefix::grpc, grpc_span::attr::method);
+        auto rpcSpan = SpanGuard::span(
+            TraceCategory::Rpc, rpc_span::prefix::command, commandName);
         // both spans end on scope exit
     @endcode
 
@@ -74,7 +77,7 @@
         auto ctx = parentGuard.captureContext();
 
         // Thread B: create child span with explicit parent
-        auto child = SpanGuard::childSpan("async.work", ctx);
+        auto child = SpanGuard::childSpan(rpc_span::op::process, ctx);
     @endcode
 
     @note Thread safety: The Telemetry interface is safe for concurrent reads