From 441c88dfb1c8ea0c3c8a50b03ddce9661d3aed18 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 20 Apr 2026 16:41:33 +0100 Subject: [PATCH] docs(telemetry): update Phase 3/4 task lists for SpanGuard factory pattern Replace references to old XRPL_TRACE_TX/CONSENSUS macros with SpanGuard::span(TraceCategory, ...) factory calls introduced in Phase 1c. Co-Authored-By: Claude Opus 4.6 (1M context) --- OpenTelemetryPlan/Phase3_taskList.md | 3 ++- OpenTelemetryPlan/Phase4_taskList.md | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/OpenTelemetryPlan/Phase3_taskList.md b/OpenTelemetryPlan/Phase3_taskList.md index e4beec9e51..a0a27c3434 100644 --- a/OpenTelemetryPlan/Phase3_taskList.md +++ b/OpenTelemetryPlan/Phase3_taskList.md @@ -97,7 +97,8 @@ - Inject current trace context into outgoing `TMTransaction::trace_context` - Set `xrpl.tx.relay_count` attribute -- Include `TracingInstrumentation.h` and use `XRPL_TRACE_TX` macro +- Use `SpanGuard::span(TraceCategory::Transactions, "tx", "receive")` factory + (Phase 1c replaced macros with the SpanGuard factory pattern) **Key modified files**: diff --git a/OpenTelemetryPlan/Phase4_taskList.md b/OpenTelemetryPlan/Phase4_taskList.md index a5ef457efd..7a44d23e0c 100644 --- a/OpenTelemetryPlan/Phase4_taskList.md +++ b/OpenTelemetryPlan/Phase4_taskList.md @@ -25,7 +25,7 @@ - Edit `src/xrpld/app/consensus/RCLConsensus.cpp`: - In `RCLConsensus::startRound()` (or the Adaptor's startRound): - - Create `consensus.round` span using `XRPL_TRACE_CONSENSUS` macro + - Create `consensus.round` span using `SpanGuard::span(TraceCategory::Consensus, ...)` - Set attributes: - `xrpl.consensus.ledger.prev` — previous ledger hash - `xrpl.consensus.ledger.seq` — target ledger sequence