From 43e1d4440eda27e04735ce27ca25a646974956c8 Mon Sep 17 00:00:00 2001 From: Olek <115580134+oleks-rip@users.noreply.github.com> Date: Sat, 15 Feb 2025 10:08:25 -0500 Subject: [PATCH] fix: Switch Permissioned Domain to Supported::yes (#5287) Switch Permissioned Domain feature's supported flag from Supported::no to Supported::yes for it to be votable. --- include/xrpl/protocol/detail/features.macro | 2 +- src/test/app/PermissionedDomains_test.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/xrpl/protocol/detail/features.macro b/include/xrpl/protocol/detail/features.macro index aa0782b137..7b120c0b8d 100644 --- a/include/xrpl/protocol/detail/features.macro +++ b/include/xrpl/protocol/detail/features.macro @@ -33,7 +33,7 @@ XRPL_FIX (InvalidTxFlags, Supported::yes, VoteBehavior::DefaultNo) XRPL_FIX (FrozenLPTokenTransfer, Supported::yes, VoteBehavior::DefaultNo) XRPL_FEATURE(DeepFreeze, Supported::yes, VoteBehavior::DefaultNo) -XRPL_FEATURE(PermissionedDomains, Supported::no, VoteBehavior::DefaultNo) +XRPL_FEATURE(PermissionedDomains, Supported::yes, VoteBehavior::DefaultNo) XRPL_FEATURE(DynamicNFT, Supported::yes, VoteBehavior::DefaultNo) XRPL_FEATURE(Credentials, Supported::yes, VoteBehavior::DefaultNo) XRPL_FEATURE(AMMClawback, Supported::yes, VoteBehavior::DefaultNo) diff --git a/src/test/app/PermissionedDomains_test.cpp b/src/test/app/PermissionedDomains_test.cpp index a80352cac5..7d78652b28 100644 --- a/src/test/app/PermissionedDomains_test.cpp +++ b/src/test/app/PermissionedDomains_test.cpp @@ -54,7 +54,8 @@ exceptionExpected(Env& env, Json::Value const& jv) class PermissionedDomains_test : public beast::unit_test::suite { - FeatureBitset withoutFeature_{supported_amendments()}; + FeatureBitset withoutFeature_{ + supported_amendments() - featurePermissionedDomains}; FeatureBitset withFeature_{ supported_amendments() // | featurePermissionedDomains | featureCredentials};