Change default value of some Options

Summary: Since we are optimizing for server workloads, some default values are not optimized any more. We change some of those values that I feel it's less prone to regression bugs.

Test Plan: make all check

Reviewers: dhruba, haobo, ljin, igor, yhchiang

Reviewed By: igor

CC: leveldb, MarkCallaghan

Differential Revision: https://reviews.facebook.net/D16995
This commit is contained in:
sdong
2014-03-28 16:57:04 -07:00
parent 2d3468c293
commit 43a593a6d9
3 changed files with 16 additions and 11 deletions

View File

@@ -146,7 +146,7 @@ struct Options {
// If any of the writes to the database fails (Put, Delete, Merge, Write),
// the database will switch to read-only mode and fail all other
// Write operations.
// Default: false
// Default: true
bool paranoid_checks;
// Use the specified object to interact with the environment,
@@ -199,7 +199,7 @@ struct Options {
// on target_file_size_base and target_file_size_multiplier for level-based
// compaction. For universal-style compaction, you can usually set it to -1.
//
// Default: 1000
// Default: 5000
int max_open_files;
// Control over blocks (user data is stored in a set of blocks, and
@@ -436,7 +436,7 @@ struct Options {
// Without a separate pool, long running major compaction jobs could
// potentially block memtable flush jobs of other db instances, leading to
// unnecessary Put stalls.
// Default: 0
// Default: 1
int max_background_flushes;
// Specify the maximal size of the info log file. If the log file
@@ -562,7 +562,7 @@ struct Options {
// Allow the OS to mmap file for reading sst tables. Default: false
bool allow_mmap_reads;
// Allow the OS to mmap file for writing. Default: true
// Allow the OS to mmap file for writing. Default: false
bool allow_mmap_writes;
// Disable child process inherit open files. Default: true