fix: address PR review comments

This commit is contained in:
Vito
2026-03-21 17:45:14 +01:00
parent d02f534987
commit 43547fcacc
6 changed files with 92 additions and 8 deletions

View File

@@ -1103,6 +1103,9 @@ sharesToAssetsWithdraw(
std::shared_ptr<SLE const> const& issuance,
STAmount const& shares);
[[nodiscard]] bool
isVaultDonate(Rules const& rules, STTx const& tx);
/** Has the specified time passed?
@param now the current time

View File

@@ -186,6 +186,10 @@ inline constexpr FlagValue tfUniversalMask = ~tfUniversal;
TF_FLAG(tfVaultShareNonTransferable, 0x00020000), \
MASK_ADJ(0)) \
\
TRANSACTION(VaultDeposit, \
TF_FLAG(tfVaultDonate, 0x00010000), \
MASK_ADJ(0)) \
\
TRANSACTION(Batch, \
TF_FLAG(tfAllOrNothing, 0x00010000) \
TF_FLAG(tfOnlyOne, 0x00020000) \
@@ -214,8 +218,6 @@ inline constexpr FlagValue tfUniversalMask = ~tfUniversal;
TF_FLAG(tfLoanUnimpair, 0x00040000), \
MASK_ADJ(0))
constexpr std::uint32_t const tfVaultDonate = 0x00010000;
constexpr std::uint32_t const tfVaultDepositMask = ~(tfUniversal | tfVaultDonate);
// clang-format on
// Create all the flag values.