From 91c6582bd5382dd9bb52ebaae0f1c49b872313ef Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 9 Jul 2026 17:03:15 +0100 Subject: [PATCH 1/3] refactor(telemetry): rename dashboard template variable label from 'Service' to 'Service Name' The template variable's Prometheus label name is `service_name` but the UI display label read 'Service', which mismatched what users typed into Grafana's Metrics Drilldown UI (which defaults to filter on a bare `service` label). Rename the display label to 'Service Name' so it unambiguously points at the underlying `service_name` Prometheus label. Behaviour unchanged; template-variable name (`service_name`) and PromQL label are the same. Only the widget label shown at the top of the dashboard changes from 'Service' to 'Service Name'. Co-Authored-By: Claude Opus 4.7 --- docker/telemetry/grafana/dashboards/consensus-health.json | 2 +- docker/telemetry/grafana/dashboards/ledger-operations.json | 2 +- docker/telemetry/grafana/dashboards/peer-network.json | 2 +- docker/telemetry/grafana/dashboards/rpc-performance.json | 2 +- docker/telemetry/grafana/dashboards/transaction-overview.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docker/telemetry/grafana/dashboards/consensus-health.json b/docker/telemetry/grafana/dashboards/consensus-health.json index 36c84d3196..485ba20965 100644 --- a/docker/telemetry/grafana/dashboards/consensus-health.json +++ b/docker/telemetry/grafana/dashboards/consensus-health.json @@ -973,7 +973,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/ledger-operations.json b/docker/telemetry/grafana/dashboards/ledger-operations.json index 70f99707d7..45b8a8f506 100644 --- a/docker/telemetry/grafana/dashboards/ledger-operations.json +++ b/docker/telemetry/grafana/dashboards/ledger-operations.json @@ -324,7 +324,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/peer-network.json b/docker/telemetry/grafana/dashboards/peer-network.json index 2493b31179..f7018ace18 100644 --- a/docker/telemetry/grafana/dashboards/peer-network.json +++ b/docker/telemetry/grafana/dashboards/peer-network.json @@ -158,7 +158,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/rpc-performance.json b/docker/telemetry/grafana/dashboards/rpc-performance.json index 2a11175807..41edb89b52 100644 --- a/docker/telemetry/grafana/dashboards/rpc-performance.json +++ b/docker/telemetry/grafana/dashboards/rpc-performance.json @@ -423,7 +423,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/transaction-overview.json b/docker/telemetry/grafana/dashboards/transaction-overview.json index 6aa4b8d9aa..fbbf90a703 100644 --- a/docker/telemetry/grafana/dashboards/transaction-overview.json +++ b/docker/telemetry/grafana/dashboards/transaction-overview.json @@ -853,7 +853,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", From bab0c84793ae3aa006bf9d33d7f79ada5c261209 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 9 Jul 2026 17:03:47 +0100 Subject: [PATCH 2/3] refactor(telemetry): rename dashboard template variable label from 'Service' to 'Service Name' Continuation of the same rename applied on phase-6-statsd (commit 91c6582bd5): 5 more dashboards introduced on phase-7 (formerly the system-* set, renamed to bare names by 2c590a47c5) still carried the older 'Service' UI label. Aligning them with the rest. Same reasoning as the phase-6 commit: the underlying Prometheus label is `service_name`, and the UI label 'Service' misled users into typing `service=xrpld` in Grafana Metrics Drilldown. Co-Authored-By: Claude Opus 4.7 --- docker/telemetry/grafana/dashboards/ledger-data-sync.json | 2 +- docker/telemetry/grafana/dashboards/network-traffic.json | 2 +- docker/telemetry/grafana/dashboards/node-health.json | 2 +- docker/telemetry/grafana/dashboards/overlay-traffic-detail.json | 2 +- docker/telemetry/grafana/dashboards/rpc-pathfinding.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docker/telemetry/grafana/dashboards/ledger-data-sync.json b/docker/telemetry/grafana/dashboards/ledger-data-sync.json index 4361cb5997..b0993f2feb 100644 --- a/docker/telemetry/grafana/dashboards/ledger-data-sync.json +++ b/docker/telemetry/grafana/dashboards/ledger-data-sync.json @@ -498,7 +498,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/network-traffic.json b/docker/telemetry/grafana/dashboards/network-traffic.json index d18957adbe..f32b1ff981 100644 --- a/docker/telemetry/grafana/dashboards/network-traffic.json +++ b/docker/telemetry/grafana/dashboards/network-traffic.json @@ -776,7 +776,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/node-health.json b/docker/telemetry/grafana/dashboards/node-health.json index a1abeb2dc1..67ce9edc6e 100644 --- a/docker/telemetry/grafana/dashboards/node-health.json +++ b/docker/telemetry/grafana/dashboards/node-health.json @@ -898,7 +898,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/overlay-traffic-detail.json b/docker/telemetry/grafana/dashboards/overlay-traffic-detail.json index 6acb4a37a7..af3192a37e 100644 --- a/docker/telemetry/grafana/dashboards/overlay-traffic-detail.json +++ b/docker/telemetry/grafana/dashboards/overlay-traffic-detail.json @@ -558,7 +558,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/rpc-pathfinding.json b/docker/telemetry/grafana/dashboards/rpc-pathfinding.json index b9897b69d0..bd200b4237 100644 --- a/docker/telemetry/grafana/dashboards/rpc-pathfinding.json +++ b/docker/telemetry/grafana/dashboards/rpc-pathfinding.json @@ -597,7 +597,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", From a835fbb2974c3ca2c49e54231c55000c805e6f05 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 9 Jul 2026 17:04:23 +0100 Subject: [PATCH 3/3] refactor(telemetry): rename dashboard template variable label from 'Service' to 'Service Name' Completes the rename applied on phase-6-statsd and phase-7-native-metrics. These four dashboards were introduced on phase-9: peer-quality and validator-health via b92354715d, fee-market and job-queue via 25868f2740. Same reasoning: the underlying Prometheus label is `service_name`, so the UI display label should say 'Service Name' rather than the ambiguous 'Service'. Co-Authored-By: Claude Opus 4.7 --- docker/telemetry/grafana/dashboards/fee-market.json | 2 +- docker/telemetry/grafana/dashboards/job-queue.json | 2 +- docker/telemetry/grafana/dashboards/peer-quality.json | 2 +- docker/telemetry/grafana/dashboards/validator-health.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docker/telemetry/grafana/dashboards/fee-market.json b/docker/telemetry/grafana/dashboards/fee-market.json index 3371f3687a..ce3dd11545 100644 --- a/docker/telemetry/grafana/dashboards/fee-market.json +++ b/docker/telemetry/grafana/dashboards/fee-market.json @@ -461,7 +461,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/job-queue.json b/docker/telemetry/grafana/dashboards/job-queue.json index 93b91ea497..8ba7177df6 100644 --- a/docker/telemetry/grafana/dashboards/job-queue.json +++ b/docker/telemetry/grafana/dashboards/job-queue.json @@ -459,7 +459,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/peer-quality.json b/docker/telemetry/grafana/dashboards/peer-quality.json index 5c61944122..a9b6d26e66 100644 --- a/docker/telemetry/grafana/dashboards/peer-quality.json +++ b/docker/telemetry/grafana/dashboards/peer-quality.json @@ -368,7 +368,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)", diff --git a/docker/telemetry/grafana/dashboards/validator-health.json b/docker/telemetry/grafana/dashboards/validator-health.json index 7220232025..6dd831fca7 100644 --- a/docker/telemetry/grafana/dashboards/validator-health.json +++ b/docker/telemetry/grafana/dashboards/validator-health.json @@ -921,7 +921,7 @@ "list": [ { "name": "service_name", - "label": "Service", + "label": "Service Name", "description": "Filter by service.name (e.g. xrpld, xrpld-validator)", "type": "query", "query": "label_values(service_name)",