From 415a412d424ea217bffe96512174759bc504ed0b Mon Sep 17 00:00:00 2001 From: Valentin Balaschenko <13349202+vlntb@users.noreply.github.com> Date: Thu, 16 Oct 2025 13:10:34 +0100 Subject: [PATCH] refactoring: removing uncesssary optimisation --- include/xrpl/ledger/LedgerIndexMap.h | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/include/xrpl/ledger/LedgerIndexMap.h b/include/xrpl/ledger/LedgerIndexMap.h index 794af336e5..5b1a1adae9 100644 --- a/include/xrpl/ledger/LedgerIndexMap.h +++ b/include/xrpl/ledger/LedgerIndexMap.h @@ -22,7 +22,6 @@ #include #include -#include #include namespace ripple { @@ -48,20 +47,14 @@ public: operator[](Key const& k) { std::lock_guard lock(mutex_); - auto [it, inserted] = data_.try_emplace(k); - if (inserted) - order_.push(k); - return it->second; + return data_[k]; } Mapped& operator[](Key&& k) { std::lock_guard lock(mutex_); - auto [it, inserted] = data_.try_emplace(std::move(k)); - if (inserted) - order_.push(it->first); - return it->second; + return data_[std::move(k)]; } [[nodiscard]] Mapped* @@ -88,8 +81,6 @@ public: auto [it, inserted] = data_.try_emplace(k, std::forward(args)...); if (!inserted) it->second = Mapped(std::forward(args)...); - else - order_.push(k); return it->second; } @@ -139,7 +130,6 @@ public: private: std::unordered_map data_; - std::queue order_; mutable std::mutex mutex_; };