From 4036d58dc904a7a552280e6151f73679c9d7bc15 Mon Sep 17 00:00:00 2001 From: kailiu Date: Tue, 21 Jan 2014 17:51:36 -0800 Subject: [PATCH] Fix a Statistics-related unit test faulure Summary: In my MacOS, the member variables are populated with random numbers after initialization. This diff fixes it by fill these arrays with 0. Test Plan: make && ./table_test Reviewers: igor CC: leveldb Differential Revision: https://reviews.facebook.net/D15315 --- util/statistics.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/statistics.cc b/util/statistics.cc index f19a777c1f..a850445edb 100644 --- a/util/statistics.cc +++ b/util/statistics.cc @@ -5,6 +5,7 @@ // #include "util/statistics.h" #include "rocksdb/statistics.h" +#include #include namespace rocksdb { @@ -13,7 +14,11 @@ std::shared_ptr CreateDBStatistics() { return std::make_shared(); } -StatisticsImpl::StatisticsImpl() {} +StatisticsImpl::StatisticsImpl() { + // Fill tickers_ with "zero". To ensure plasform indepedent, we used + // uint_fast64_t() instead literal `0` to represent zero. + std::fill(tickers_, tickers_ + TICKER_ENUM_MAX, uint_fast64_t()); +} StatisticsImpl::~StatisticsImpl() {}