ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Annonate another instance of the same anonymous constant

Browse Source
This commit is contained in:
Vinnie Falco
2013-06-07 10:24:33 -07:00
parent 5ae48ddad6
commit 3cf2fb884d
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/ripple_data/crypto/ripple_Base58Data.cpp
View File

@@ -109,8 +109,16 @@ bool CBase58Data::operator> (const CBase58Data& b58) const { return CompareTo(b5
std::size_t hash_value(const CBase58Data& b58) std::size_t hash_value(const CBase58Data& b58)
{ {
std::size_t seed = HashMaps::getInstance ().getNonce <size_t> () // VFALCO: TODO, figure out what this is for and whether or
+ (b58.nVersion * 0x9e3779b9); // not it affects the protocol specification.
//
// NOTE, this constant is used elsewhere as well.
// should it be DRY?
//
const std::size_t mysteriousConstant = 0x9e3779b9;
std::size_t seed = HashMaps::getInstance ().getNonce <size_t> ()
+ (b58.nVersion * mysteriousConstant);
boost::hash_combine (seed, b58.vchData); boost::hash_combine (seed, b58.vchData);

3
src/cpp/ripple/SHAMap.cpp
View File

@@ -29,6 +29,9 @@ void SHAMapNode::setMHash() const
// VFALCO: TODO, figure out what this is for and whether or // VFALCO: TODO, figure out what this is for and whether or
// not it affects the protocol specification. // not it affects the protocol specification.
// //
// NOTE, this constant is used elsewhere as well.
// should it be DRY?
//
const std::size_t mysteriousConstant = 0x9e3779b9; const std::size_t mysteriousConstant = 0x9e3779b9;
std::size_t h = HashMaps::getInstance ().getNonce <std::size_t> () std::size_t h = HashMaps::getInstance ().getNonce <std::size_t> ()