ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update RPC handler role/usage (RIPD-557):

Browse Source 
* Properly use the RPC method to determine required role for HTTP/S RPC calls.
* Charge for malformed RPC calls over HTTP/S
This commit is contained in:
Brad Chase
2016-12-07 11:59:44 -05:00
committed by Nik Bougalis
parent d9ef5ef98f
commit 3c4d3b10c1
8 changed files with 156 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/rpc/LedgerRequestRPC_test.cpp
View File

@@ -294,10 +294,12 @@ public:
env.fund(XRP(100000), gw);
env.close();
auto const result = env.rpc ( "ledger_request", "1" ) [jss::result];
BEAST_EXPECT(result[jss::error] == "noPermission");
BEAST_EXPECT(result[jss::status] == "error");
BEAST_EXPECT(result[jss::error_message] == "You don't have permission for this command.");
auto const result = env.rpc ( "ledger_request", "1" ) [jss::result];
// The current HTTP/S ServerHandler returns an HTTP 403 error code here
// rather than a noPermission JSON error. The JSONRPCClient just eats that
// error and returns an null result.
BEAST_EXPECT(result.type() == Json::nullValue);
}
void run ()