From 3b93e2d4d99bb9c573430a3b74d97cd499ff307b Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 28 Apr 2026 14:01:39 +0100 Subject: [PATCH] fix(telemetry): suppress unused span warning and regenerate levelization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add [[maybe_unused]] to the RAII span in processSession() — the variable is not read but its lifetime scopes the active OTel context for child spans created in processRequest() - Regenerate levelization: remove premature xrpld.telemetry entries that reference a module not yet present on this branch Co-Authored-By: Claude Opus 4.6 --- .github/scripts/levelization/results/loops.txt | 3 +++ .github/scripts/levelization/results/ordering.txt | 2 -- src/xrpld/rpc/detail/ServerHandler.cpp | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/scripts/levelization/results/loops.txt b/.github/scripts/levelization/results/loops.txt index fb449441e3..181cbec44a 100644 --- a/.github/scripts/levelization/results/loops.txt +++ b/.github/scripts/levelization/results/loops.txt @@ -4,6 +4,9 @@ Loop: test.jtx test.toplevel Loop: test.jtx test.unit_test test.unit_test ~= test.jtx +Loop: xrpl.telemetry xrpld.rpc + xrpld.rpc ~= xrpl.telemetry + Loop: xrpld.app xrpld.overlay xrpld.app > xrpld.overlay diff --git a/.github/scripts/levelization/results/ordering.txt b/.github/scripts/levelization/results/ordering.txt index 4aacd68fb8..b908b4a64c 100644 --- a/.github/scripts/levelization/results/ordering.txt +++ b/.github/scripts/levelization/results/ordering.txt @@ -281,7 +281,6 @@ xrpld.perflog > xrpl.protocol xrpld.rpc > xrpl.basics xrpld.rpc > xrpl.core xrpld.rpc > xrpld.core -xrpld.rpc > xrpld.telemetry xrpld.rpc > xrpl.json xrpld.rpc > xrpl.ledger xrpld.rpc > xrpl.net @@ -296,4 +295,3 @@ xrpld.shamap > xrpl.basics xrpld.shamap > xrpld.core xrpld.shamap > xrpl.protocol xrpld.shamap > xrpl.shamap -xrpld.telemetry > xrpl.telemetry diff --git a/src/xrpld/rpc/detail/ServerHandler.cpp b/src/xrpld/rpc/detail/ServerHandler.cpp index 5c2f82ae54..9c9b34ec6e 100644 --- a/src/xrpld/rpc/detail/ServerHandler.cpp +++ b/src/xrpld/rpc/detail/ServerHandler.cpp @@ -573,7 +573,7 @@ ServerHandler::processSession( std::shared_ptr const& session, std::shared_ptr coro) { - auto span = + [[maybe_unused]] auto span = SpanGuard::span(TraceCategory::Rpc, rpc_span::prefix::rpc, rpc_span::op::httpRequest); processRequest(