ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-21 14:20:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'pratik/otel-phase6-statsd' into pratik/otel-phase7-native-metrics

Browse Source 
# Conflicts:
#	docker/telemetry/grafana/dashboards/statsd-rpc-pathfinding.json
#	docker/telemetry/integration-test.sh
This commit is contained in:
Pratik Mankawde
2026-08-14 21:20:39 +01:00
parent c4888dd066 974835589a
commit 3a91a7414e
7 changed files with 43 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
include/xrpl/proto/xrpl.proto
View File

@@ -95,9 +95,8 @@ message TMPublicKey {
// Older peers that do not understand field 1001 will simply ignore it
// per protobuf wire-format rules, preserving backwards compatibility.
//
// trace_state is reserved for future use (secure tracing pipeline,
// OpenTelemetryPlan/secure-OTel.md). It is currently neither populated
// on inject nor read on extract; consumers must not rely on it.
// trace_state is reserved for future use. It is currently neither
// populated on inject nor read on extract; consumers must not rely on it.
message TraceContext {
optional bytes trace_id = 1; // 16-byte trace identifier
optional bytes span_id = 2; // 8-byte parent span identifier

11
include/xrpl/telemetry/TraceContextPropagator.h
View File

@@ -101,13 +101,10 @@ injectToProtobuf(opentelemetry::context::Context const& ctx, protocol::TraceCont
// Serialize flags
proto.set_trace_flags(spanCtx.trace_flags().flags());
// TODO(observability/secure-OTel): the protobuf TraceContext message
// also carries `trace_state` (field 4), which is currently neither
// populated here nor read by extractFromProtobuf above. The field is
// reserved for the secure tracing pipeline outlined in
// OpenTelemetryPlan/secure-OTel.md, where an authenticated token in
// tracestate will let receivers reject spoofed/poisoned trace context.
// Wire trace_state through inject/extract once the consumer lands.
// TODO: the protobuf TraceContext message also carries `trace_state`
// (field 4), which is currently neither populated here nor read by
// extractFromProtobuf above. The field is reserved for future use;
// wire it through inject/extract once a consumer lands.
}
} // namespace xrpl::telemetry