Add provisional Visual Studio 2010 project

Builds/VisualStudio2010/RippleD.props

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <ImportGroup Label="PropertySheets" />
+  <PropertyGroup Label="UserMacros">
+    <RepoDir>..\..</RepoDir>
+    <SrcDir>$(RepoDir)\src\cpp\ripple</SrcDir>
+  </PropertyGroup>
+  <PropertyGroup>
+    <OutDir>$(RepoDir)\build\VisualStudio2010\$(Configuration).$(Platform)\</OutDir>
+  </PropertyGroup>
+  <PropertyGroup>
+    <IntDir>$(RepoDir)\build\obj\VisualStudio2010\$(Configuration).$(Platform)\</IntDir>
+  </PropertyGroup>
+  <ItemDefinitionGroup>
+    <ClCompile>
+      <AdditionalIncludeDirectories>$(RepoDir);$(RepoDir)\src\cpp\leveldb;$(RepoDir)\src\cpp\leveldb\include;$(RepoDir)\src\cpp\protobuf\src;$(RepoDir)\src\cpp\protobuf\vsprojects;$(RepoDir)\build\proto;$(RepoDir)\Subtrees\beast;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
+      <PreprocessorDefinitions>USE_LEVELDB;BOOST_TEST_ALTERNATIVE_INIT_API;BOOST_TEST_NO_MAIN;_WIN32_WINNT=0x0600;_SCL_SECURE_NO_WARNINGS;_CRT_SECURE_NO_WARNINGS;WIN32;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <WarningLevel>Level3</WarningLevel>
+      <MultiProcessorCompilation>true</MultiProcessorCompilation>
+    </ClCompile>
+  </ItemDefinitionGroup>
+  <ItemGroup>
+    <BuildMacro Include="RepoDir">
+      <Value>$(RepoDir)</Value>
+    </BuildMacro>
+    <BuildMacro Include="SrcDir">
+      <Value>$(SrcDir)</Value>
+    </BuildMacro>
+  </ItemGroup>
+</Project>

Builds/VisualStudio2010/RippleD.sln

@@ -0,0 +1,20 @@
+
+Microsoft Visual Studio Solution File, Format Version 11.00
+# Visual Studio 2010
+Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "RippleD", "RippleD.vcxproj", "{EE95954F-3D34-4FB1-ADBD-FE8395233026}"
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Win32 = Debug|Win32
+		Release|Win32 = Release|Win32
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{EE95954F-3D34-4FB1-ADBD-FE8395233026}.Debug|Win32.ActiveCfg = Debug|Win32
+		{EE95954F-3D34-4FB1-ADBD-FE8395233026}.Debug|Win32.Build.0 = Debug|Win32
+		{EE95954F-3D34-4FB1-ADBD-FE8395233026}.Release|Win32.ActiveCfg = Release|Win32
+		{EE95954F-3D34-4FB1-ADBD-FE8395233026}.Release|Win32.Build.0 = Release|Win32
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+EndGlobal

Builds/VisualStudio2010/RippleD.vcxproj

@@ -0,0 +1,98 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <ItemGroup Label="ProjectConfigurations">
+    <ProjectConfiguration Include="Debug|Win32">
+      <Configuration>Debug</Configuration>
+      <Platform>Win32</Platform>
+    </ProjectConfiguration>
+    <ProjectConfiguration Include="Release|Win32">
+      <Configuration>Release</Configuration>
+      <Platform>Win32</Platform>
+    </ProjectConfiguration>
+  </ItemGroup>
+  <PropertyGroup Label="Globals">
+    <ProjectGuid>{EE95954F-3D34-4FB1-ADBD-FE8395233026}</ProjectGuid>
+    <Keyword>Win32Proj</Keyword>
+    <RootNamespace>RippleD</RootNamespace>
+  </PropertyGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
+    <ConfigurationType>Application</ConfigurationType>
+    <UseDebugLibraries>true</UseDebugLibraries>
+    <CharacterSet>NotSet</CharacterSet>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'" Label="Configuration">
+    <ConfigurationType>Application</ConfigurationType>
+    <UseDebugLibraries>false</UseDebugLibraries>
+    <WholeProgramOptimization>true</WholeProgramOptimization>
+    <CharacterSet>NotSet</CharacterSet>
+  </PropertyGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
+  <ImportGroup Label="ExtensionSettings">
+  </ImportGroup>
+  <ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
+    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
+    <Import Project="RippleD.props" />
+  </ImportGroup>
+  <ImportGroup Label="PropertySheets" Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
+    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
+  </ImportGroup>
+  <PropertyGroup Label="UserMacros" />
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
+    <LinkIncremental>true</LinkIncremental>
+  </PropertyGroup>
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
+    <LinkIncremental>false</LinkIncremental>
+  </PropertyGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
+    <ClCompile>
+      <PrecompiledHeader>
+      </PrecompiledHeader>
+      <WarningLevel>Level3</WarningLevel>
+      <Optimization>Disabled</Optimization>
+      <PreprocessorDefinitions>WIN32;_DEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
+      <MinimalRebuild>false</MinimalRebuild>
+    </ClCompile>
+    <Link>
+      <SubSystem>Windows</SubSystem>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
+    </Link>
+  </ItemDefinitionGroup>
+  <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
+    <ClCompile>
+      <WarningLevel>Level3</WarningLevel>
+      <PrecompiledHeader>
+      </PrecompiledHeader>
+      <Optimization>MaxSpeed</Optimization>
+      <FunctionLevelLinking>true</FunctionLevelLinking>
+      <IntrinsicFunctions>true</IntrinsicFunctions>
+      <PreprocessorDefinitions>WIN32;NDEBUG;_WINDOWS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <RuntimeLibrary>MultiThreaded</RuntimeLibrary>
+      <MinimalRebuild>false</MinimalRebuild>
+    </ClCompile>
+    <Link>
+      <SubSystem>Windows</SubSystem>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
+      <EnableCOMDATFolding>true</EnableCOMDATFolding>
+      <OptimizeReferences>true</OptimizeReferences>
+    </Link>
+  </ItemDefinitionGroup>
+  <ItemGroup>
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt1.cpp" />
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt2.cpp" />
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt3.cpp" />
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt4.cpp" />
+    <ClCompile Include="..\..\modules\ripple_basics\ripple_basics.cpp" />
+    <ClCompile Include="..\..\modules\ripple_data\ripple_data.cpp" />
+    <ClCompile Include="..\..\src\cpp\database\sqlite3.c" />
+    <ClCompile Include="..\..\src\cpp\leveldb_core.cpp" />
+    <ClCompile Include="..\..\src\cpp\protobuf_core.cpp" />
+    <ClCompile Include="..\..\src\cpp\websocket_core.cpp" />
+    <ClCompile Include="..\..\Subtrees\beast\modules\beast_basics\beast_basics.cpp" />
+    <ClCompile Include="..\..\Subtrees\beast\modules\beast_core\beast_core.cpp" />
+  </ItemGroup>
+  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
+  <ImportGroup Label="ExtensionTargets">
+  </ImportGroup>
+</Project>

Builds/VisualStudio2010/RippleD.vcxproj.filters

@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <ItemGroup>
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt1.cpp" />
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt2.cpp" />
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt3.cpp" />
+    <ClCompile Include="..\..\modules\ripple_app\ripple_app_pt4.cpp" />
+    <ClCompile Include="..\..\modules\ripple_basics\ripple_basics.cpp" />
+    <ClCompile Include="..\..\modules\ripple_data\ripple_data.cpp" />
+    <ClCompile Include="..\..\Subtrees\beast\modules\beast_basics\beast_basics.cpp">
+      <Filter>Subtrees</Filter>
+    </ClCompile>
+    <ClCompile Include="..\..\Subtrees\beast\modules\beast_core\beast_core.cpp">
+      <Filter>Subtrees</Filter>
+    </ClCompile>
+    <ClCompile Include="..\..\src\cpp\leveldb_core.cpp">
+      <Filter>Subtrees</Filter>
+    </ClCompile>
+    <ClCompile Include="..\..\src\cpp\protobuf_core.cpp">
+      <Filter>Subtrees</Filter>
+    </ClCompile>
+    <ClCompile Include="..\..\src\cpp\websocket_core.cpp">
+      <Filter>Subtrees</Filter>
+    </ClCompile>
+    <ClCompile Include="..\..\src\cpp\database\sqlite3.c">
+      <Filter>Subtrees</Filter>
+    </ClCompile>
+  </ItemGroup>
+  <ItemGroup>
+    <Filter Include="Ripple">
+      <UniqueIdentifier>{63db902e-0e7a-42d1-b5f5-663e4b48786c}</UniqueIdentifier>
+    </Filter>
+    <Filter Include="Subtrees">
+      <UniqueIdentifier>{469e8a0a-64bf-4fa1-8b6f-81207db68577}</UniqueIdentifier>
+    </Filter>
+  </ItemGroup>
+</Project>

Builds/VisualStudio2012/Ripple.sln

@@ -3,6 +3,8 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Express 2012 for Windows Desktop
 Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "RippleD", "RippleD.vcxproj", "{19465545-42EE-42FA-9CC8-F8975F8F1CC7}"
 EndProject
+Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "beast", "..\..\Subtrees\beast\Builds\VisualStudio2012\beast.vcxproj", "{73C5A0F0-7629-4DE7-9194-BE7AC6C19535}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Win32 = Debug|Win32
@@ -19,6 +21,12 @@ Global
 		{19465545-42EE-42FA-9CC8-F8975F8F1CC7}.Release|Win32.Build.0 = Release|Win32
 		{19465545-42EE-42FA-9CC8-F8975F8F1CC7}.Release|x64.ActiveCfg = Release|x64
 		{19465545-42EE-42FA-9CC8-F8975F8F1CC7}.Release|x64.Build.0 = Release|x64
+		{73C5A0F0-7629-4DE7-9194-BE7AC6C19535}.Debug|Win32.ActiveCfg = Debug|Win32
+		{73C5A0F0-7629-4DE7-9194-BE7AC6C19535}.Debug|Win32.Build.0 = Debug|Win32
+		{73C5A0F0-7629-4DE7-9194-BE7AC6C19535}.Debug|x64.ActiveCfg = Debug|Win32
+		{73C5A0F0-7629-4DE7-9194-BE7AC6C19535}.Release|Win32.ActiveCfg = Release|Win32
+		{73C5A0F0-7629-4DE7-9194-BE7AC6C19535}.Release|Win32.Build.0 = Release|Win32
+		{73C5A0F0-7629-4DE7-9194-BE7AC6C19535}.Release|x64.ActiveCfg = Release|Win32
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

Builds/VisualStudio2012/RippleD.vcxproj

@@ -1910,7 +1910,7 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
-    <Text Include="RefactoringNotes.txt" />
+    <Text Include="..\..\TODO.txt" />
     <Text Include="StyleCheatSheet.txt" />
   </ItemGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />

Builds/VisualStudio2012/RippleD.vcxproj.filters

@@ -1662,7 +1662,7 @@
     <CustomBuild Include="..\..\src\cpp\ripple\ripple.proto" />
   </ItemGroup>
   <ItemGroup>
-    <Text Include="RefactoringNotes.txt" />
     <Text Include="StyleCheatSheet.txt" />
+    <Text Include="..\..\TODO.txt" />
   </ItemGroup>
 </Project>

TODO.txt

@@ -2,6 +2,17 @@
 TODO
 --------------------------------------------------------------------------------
 
+- Remove "using namespace" statements
+
+- Make LevelDB and Ripple code work with both Unicode and non-Unicode Windows APIs
+
+- Raise the warning level and fix everything
+
+- Go searching through VFALCO notes and fix everything
+
+- Deal with function-level statics used for SqliteDatabase (like in
+  HSBESQLite::visitAll)
+
 - Document in order:
     SerializedType
     STObject
@@ -29,11 +40,6 @@ Naming
 
 Some names don't make sense.
 
-  InboundLedger
-    Not a noun.
-    Is it really an InboundLedger ?
-    Does it continue to exist after the ledger is received?
-
   Index
     Stop using Index to refer to keys in tables.
     Index implies a small integer, or a data structure.

modules/ripple_basics/utility/ripple_RandomNumbers.cpp

@@ -73,7 +73,7 @@ bool RandomNumbers::platformAddEntropy ()
     DWORD count = 500;
     HCRYPTPROV cryptoHandle;
 
-    if (!CryptGetDefaultProvider (PROV_RSA_FULL, NULL, CRYPT_MACHINE_DEFAULT, name, &count))
+    if (!CryptGetDefaultProviderA (PROV_RSA_FULL, NULL, CRYPT_MACHINE_DEFAULT, name, &count))
     {
 #ifdef DEBUG
         std::cerr << "Unable to get default crypto provider" << std::endl;
@@ -81,7 +81,7 @@ bool RandomNumbers::platformAddEntropy ()
         return false;
     }
 
-    if (!CryptAcquireContext (&cryptoHandle, NULL, name, PROV_RSA_FULL, CRYPT_VERIFYCONTEXT | CRYPT_SILENT))
+    if (!CryptAcquireContextA (&cryptoHandle, NULL, name, PROV_RSA_FULL, CRYPT_VERIFYCONTEXT | CRYPT_SILENT))
     {
 #ifdef DEBUG
         std::cerr << "Unable to acquire crypto provider" << std::endl;

src/cpp/ripple/ripple_Application.cpp

@@ -610,7 +610,6 @@ void Application::setup ()
     if (!theConfig.RUN_STANDALONE)
         mPeers->start ();
 
-
     if (theConfig.RUN_STANDALONE)
     {
         WriteLog (lsWARNING, Application) << "Running in standalone mode";
@@ -618,7 +617,9 @@ void Application::setup ()
         mNetOps.setStandAlone ();
     }
     else
+    {
         mNetOps.setStateTimer ();
+    }
 }
 
 void Application::run ()
@@ -644,9 +645,10 @@ void Application::run ()
 
 void Application::sweep ()
 {
-
     boost::filesystem::space_info space = boost::filesystem::space (theConfig.DATA_DIR);
 
+    // VFALCO TODO Give this magic constant a name and move it into a well documented header
+    //
     if (space.available < (512 * 1024 * 1024))
     {
         WriteLog (lsFATAL, Application) << "Remaining free disk space is less than 512MB";