ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Harden validations:

Browse Source 
This commit introduces the "HardenedValidations" amendment which,
if enabled, allows validators to include additional information in
their validations that can increase the robustness of consensus.

Specifically, the commit introduces a new optional field that can
be set in validation messages can be used to attest to the hash of
the latest ledger that a validator considers to be fully validated.

Additionally, the commit leverages the previously introduced "cookie"
field to improve the robustness of the network by making it possible
for servers to automatically detect accidental misconfiguration which
results in two or more validators using the same validation key.
This commit is contained in:
Nik Bougalis
2018-11-16 02:24:23 -08:00
parent 567e42e071
commit 381606aba2
25 changed files with 313 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

94
src/ripple/protocol/STValidation.h
View File

@@ -25,6 +25,7 @@
#include <ripple/protocol/PublicKey.h>
#include <ripple/protocol/STObject.h>
#include <ripple/protocol/SecretKey.h>
#include <cassert>
#include <cstdint>
#include <functional>
#include <memory>
@@ -32,8 +33,12 @@
namespace ripple {
// Validation flags
const std::uint32_t vfFullyCanonicalSig =
0x80000000; // signature is fully canonical
// This is a full (as opposed to a partial) validation
constexpr std::uint32_t vfFullValidation = 0x00000001;
// The signature is fully canonical
constexpr std::uint32_t vfFullyCanonicalSig = 0x80000000;
class STValidation final : public STObject, public CountedObject<STValidation>
{
@@ -44,11 +49,6 @@ public:
return "STValidation";
}
using pointer = std::shared_ptr<STValidation>;
using ref = const std::shared_ptr<STValidation>&;
enum { kFullFlag = 0x1 };
/** Construct a STValidation from a peer.
Construct a STValidation from serialized data previously shared by a
@@ -70,71 +70,63 @@ public:
SerialIter& sit,
LookupNodeID&& lookupNodeID,
bool checkSignature)
: STObject(getFormat(), sit, sfValidation)
: STObject(validationFormat(), sit, sfValidation)
{
auto const spk = getFieldVL(sfSigningPubKey);
if (publicKeyType(makeSlice(spk)) != KeyType::secp256k1)
{
JLOG(debugLog().error()) << "Invalid public key in validation"
JLOG(debugLog().error()) << "Invalid public key in validation: "
<< getJson(JsonOptions::none);
Throw<std::runtime_error>("Invalid public key in validation");
}
if (checkSignature && !isValid())
{
JLOG(debugLog().error()) << "Invalid signature in validation"
JLOG(debugLog().error()) << "Invalid signature in validation: "
<< getJson(JsonOptions::none);
Throw<std::runtime_error>("Invalid signature in validation");
}
mNodeID = lookupNodeID(PublicKey(makeSlice(spk)));
assert(mNodeID.isNonZero());
nodeID_ = lookupNodeID(PublicKey(makeSlice(spk)));
assert(nodeID_.isNonZero());
}
/** Fees to set when issuing a new validation.
/** Construct, sign and trust a new STValidation issued by this node.
Optional fees to include when issuing a new validation
*/
struct FeeSettings
{
boost::optional<std::uint32_t> loadFee;
boost::optional<XRPAmount> baseFee;
boost::optional<XRPAmount> reserveBase;
boost::optional<XRPAmount> reserveIncrement;
};
/** Construct, sign and trust a new STValidation
Constructs, signs and trusts new STValidation issued by this node.
@param ledgerHash The hash of the validated ledger
@param ledgerSeq The sequence number (index) of the ledger
@param consensusHash The hash of the consensus transaction set
@param signTime When the validation is signed
@param publicKey The current signing public key
@param secretKey The current signing secret key
@param nodeID ID corresponding to node's public master key
@param isFull Whether the validation is full or partial
@param fee FeeSettings to include in the validation
@param amendments If not empty, the amendments to include in this
validation
@note The fee and amendment settings are only set if not boost::none.
Typically, the amendments and fees are set for validations of flag
ledgers only.
@param f callback function to "fill" the validation with necessary data
*/
template <typename F>
STValidation(
uint256 const& ledgerHash,
std::uint32_t ledgerSeq,
uint256 const& consensusHash,
NetClock::time_point signTime,
PublicKey const& publicKey,
SecretKey const& secretKey,
PublicKey const& pk,
SecretKey const& sk,
NodeID const& nodeID,
bool isFull,
FeeSettings const& fees,
std::vector<uint256> const& amendments);
F&& f)
: STObject(validationFormat(), sfValidation)
, nodeID_(nodeID)
, seenTime_(signTime)
{
// First, set our own public key:
if (publicKeyType(pk) != KeyType::secp256k1)
LogicError(
"We can only use secp256k1 keys for signing validations");
setFieldVL(sfSigningPubKey, pk.slice());
setFieldU32(sfSigningTime, signTime.time_since_epoch().count());
// Perform additional initialization
f(*this);
// Finally, sign the validation and mark it as trusted:
setFlag(vfFullyCanonicalSig);
setFieldVL(sfSignature, signDigest(pk, sk, getSigningHash()));
setTrusted();
}
STBase*
copy(std::size_t n, void* buf) const override
@@ -168,7 +160,7 @@ public:
NodeID
getNodeID() const
{
return mNodeID;
return nodeID_;
}
bool
@@ -201,7 +193,7 @@ public:
void
setSeen(NetClock::time_point s)
{
mSeen = s;
seenTime_ = s;
}
Blob
@@ -212,11 +204,11 @@ public:
private:
static SOTemplate const&
getFormat();
validationFormat();
NodeID mNodeID;
NodeID nodeID_;
bool mTrusted = false;
NetClock::time_point mSeen = {};
NetClock::time_point seenTime_ = {};
};
} // namespace ripple