reduce PR size

cmake/scripts/codegen/macro_parser_common.py

@@ -9,7 +9,6 @@ and ledger_entries.macro files using pcpp and pyparsing.
 import re
 import shutil
 from pathlib import Path
-
 import pyparsing as pp
 from pcpp import Preprocessor
 

include/xrpl/ledger/helpers/VaultHelpers.h

@@ -108,8 +108,6 @@ isSoleShareholder(ReadView const& view, AccountID const& account, SLE::const_ref
     @return True if the vault is insolvent, false otherwise.
 */
 [[nodiscard]] bool
-isVaultInsolvent(
-    std::shared_ptr<SLE const> const& vault,
-    std::shared_ptr<SLE const> const& shareIssuance);
+isVaultInsolvent(SLE::const_ref vault, SLE::const_ref shareIssuance);
 
 }  // namespace xrpl

include/xrpl/tx/transactors/vault/VaultClawback.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <xrpl/ledger/helpers/VaultHelpers.h>
 #include <xrpl/tx/Transactor.h>
 
 namespace xrpl {

include/xrpl/tx/transactors/vault/VaultDeposit.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <xrpl/ledger/helpers/VaultHelpers.h>
 #include <xrpl/tx/Transactor.h>
 
 namespace xrpl {

include/xrpl/tx/transactors/vault/VaultWithdraw.h

@@ -1,6 +1,5 @@
 #pragma once
 
-#include <xrpl/ledger/helpers/VaultHelpers.h>
 #include <xrpl/tx/Transactor.h>
 
 namespace xrpl {

src/libxrpl/ledger/helpers/VaultHelpers.cpp

@@ -12,7 +12,6 @@
 #include <xrpl/protocol/STNumber.h>  // IWYU pragma: keep
 
 #include <cstdint>
-#include <memory>
 #include <optional>
 
 namespace xrpl {
@@ -139,9 +138,7 @@ isSoleShareholder(ReadView const& view, AccountID const& account, SLE::const_ref
 }
 
 [[nodiscard]] bool
-isVaultInsolvent(
-    std::shared_ptr<SLE const> const& vault,
-    std::shared_ptr<SLE const> const& shareIssuance)
+isVaultInsolvent(SLE::const_ref vault, SLE::const_ref shareIssuance)
 {
     XRPL_ASSERT(vault && vault->getType() == ltVAULT, "xrpl::isVaultInsolvent : Vault sle");
     XRPL_ASSERT(

src/test/jtx/vault.h

@@ -35,7 +35,7 @@ struct Vault
     {
         Account owner;
         uint256 id;
-        std::optional<std::uint32_t> flags;
+        std::optional<std::uint32_t> flags = std::nullopt;
     };
 
     static json::Value