ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-26 22:15:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Must check sequence before checking fee and signature. Otherwise lots of bad things happen:

Browse Source 
1) We needlessly check signatures on applied.
2) We return the wrong error code if a transaction that was already applied has an insufficient fee.
This commit is contained in:
JoelKatz
2013-02-11 16:48:52 -08:00
parent b512ed3df2
commit 341d198ffe
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/cpp/ripple/Transactor.cpp
View File

@@ -206,15 +206,15 @@ TER Transactor::apply()
mHasAuthKey = mTxnAccount->isFieldPresent(sfRegularKey);
}
terResult = checkSeq();
if (terResult != tesSUCCESS) return(terResult);
terResult = payFee();
if (terResult != tesSUCCESS) return(terResult);
terResult = checkSig();
if (terResult != tesSUCCESS) return(terResult);
terResult = checkSeq();
if (terResult != tesSUCCESS) return(terResult);
mEngine->entryModify(mTxnAccount);
return doApply();