Tidy up LedgerEntrySet

src/cpp/ripple/Ledger.h

@@ -358,6 +358,9 @@ public:
     //
 
     // Index of node which is the ripple state between two accounts for a currency.
+    // VFALCO NOTE Rename these to make it clear they are simple functions that
+    //             don't access global variables. e.g. "calculateKeyFromRippleStateAndAddress"
+    //
     static uint256 getRippleStateIndex (const RippleAddress & naA, const RippleAddress & naB, const uint160 & uCurrency);
     static uint256 getRippleStateIndex (const uint160 & uiA, const uint160 & uiB, const uint160 & uCurrency)
     {

src/cpp/ripple/ripple_LedgerEntrySet.cpp

@@ -11,6 +11,9 @@ DECLARE_INSTANCE (LedgerEntrySet)
 
 // #define META_DEBUG
 
+// VFALCO TODO Replace this macro with a documented language constant
+//        NOTE Is this part of the protocol?
+//
 #define DIR_NODE_MAX        32
 
 void LedgerEntrySet::init (Ledger::ref ledger, uint256 const& transactionID,

src/cpp/ripple/ripple_LedgerEntrySet.h

@@ -4,8 +4,8 @@
 */
 //==============================================================================
 
-#ifndef __LEDGERENTRYSET__
-#define __LEDGERENTRYSET__
+#ifndef RIPPLE_LEDGERENTRYSET_H
+#define RIPPLE_LEDGERENTRYSET_H
 
 DEFINE_INSTANCE (LedgerEntrySetEntry);
 DEFINE_INSTANCE (LedgerEntrySet);
@@ -42,9 +42,11 @@ public:
     LedgerEntryAction   mAction;
     int                 mSeq;
 
-    LedgerEntrySetEntry (SLE::ref e, LedgerEntryAction a, int s) : mEntry (e), mAction (a), mSeq (s)
+    LedgerEntrySetEntry (SLE::ref e, LedgerEntryAction a, int s)
+        : mEntry (e)
+        , mAction (a)
+        , mSeq (s)
     {
-        ;
     }
 };
 
@@ -62,12 +64,10 @@ public:
     LedgerEntrySet (Ledger::ref ledger, TransactionEngineParams tep, bool immutable = false) :
         mLedger (ledger), mParams (tep), mSeq (0), mImmutable (immutable)
     {
-        ;
     }
 
     LedgerEntrySet () : mParams (tapNONE), mSeq (0), mImmutable (false)
     {
-        ;
     }
 
     // set functions
@@ -75,17 +75,23 @@ public:
     {
         mImmutable = true;
     }
+
     bool isImmutable () const
     {
         return mImmutable;
     }
+
     LedgerEntrySet duplicate () const;  // Make a duplicate of this set
+
     void setTo (const LedgerEntrySet&); // Set this set to have the same contents as another
+
     void swapWith (LedgerEntrySet&);    // Swap the contents of two sets
+
     void invalidate ()
     {
         mLedger.reset ();
     }
+
     bool isValid () const
     {
         return !!mLedger;
@@ -95,21 +101,26 @@ public:
     {
         return mSeq;
     }
+
     TransactionEngineParams getParams () const
     {
         return mParams;
     }
+
     void bumpSeq ()
     {
         ++mSeq;
     }
+
     void init (Ledger::ref ledger, uint256 const & transactionID, uint32 ledgerID, TransactionEngineParams params);
+
     void clear ();
 
     Ledger::pointer& getLedger ()
     {
         return mLedger;
     }
+
     Ledger::ref getLedgerRef () const
     {
         return mLedger;