ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy bugprone-suspicious-stringview-data-usage check (#6467)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-10 08:34:27 +00:00
committed by GitHub
parent 45b8c4d732
commit 320a65f77c
5 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/libxrpl/beast/core/CurrentThreadName.cpp
View File

@@ -62,7 +62,8 @@ namespace beast::detail {
inline void
setCurrentThreadNameImpl(std::string_view name)
{
pthread_setname_np(name.data());
// The string is assumed to be null terminated
pthread_setname_np(name.data()); // NOLINT(bugprone-suspicious-stringview-data-usage)
}
} // namespace beast::detail
@@ -85,7 +86,7 @@ setCurrentThreadNameImpl(std::string_view name)
sizeof(boundedName),
"%.*s",
static_cast<int>(maxThreadNameLength),
name.data());
name.data()); // NOLINT(bugprone-suspicious-stringview-data-usage)
pthread_setname_np(pthread_self(), boundedName);

4
src/test/core/Config_test.cpp
View File

@@ -1280,7 +1280,7 @@ r.ripple.com:51235
for (auto const& t : tests)
{
Section s;
s.append(t.line.data());
s.append(std::string(t.line));
BEAST_EXPECT(s.had_trailing_comments() == t.had_comment);
if (t.field.empty())
{
@@ -1289,7 +1289,7 @@ r.ripple.com:51235
else
{
std::string field;
BEAST_EXPECTS(set(field, t.field.data(), s), t.line);
BEAST_EXPECTS(set(field, std::string(t.field), s), t.line);
BEAST_EXPECTS(field == t.expect, t.line);
}
}

5
src/test/rpc/AccountInfo_test.cpp
View File

@@ -502,11 +502,12 @@ public:
Json::Value params;
params[jss::account] = account.human();
auto const info = env.rpc("json", "account_info", to_string(params));
auto const name = std::string(fName);
std::optional<bool> res;
if (info[jss::result][jss::status] == "success" &&
info[jss::result][jss::account_flags].isMember(fName.data()))
res.emplace(info[jss::result][jss::account_flags][fName.data()].asBool());
info[jss::result][jss::account_flags].isMember(name))
res.emplace(info[jss::result][jss::account_flags][name].asBool());
return res;
};

2
src/xrpld/overlay/detail/OverlayImpl.cpp
View File

@@ -825,7 +825,7 @@ OverlayImpl::processValidatorList(http_request_type const& req, Handoff& handoff
// return the most recent validator list for that key.
constexpr std::string_view prefix("/vl/");
if (!req.target().starts_with(prefix.data()) || !setup_.vlEnabled)
if (!req.target().starts_with(prefix) || !setup_.vlEnabled)
return false;
std::uint32_t version = 1;