From 30c65320e4479806aee850222a988b25fcbb68dc Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Thu, 5 Feb 2026 18:25:23 -0500 Subject: [PATCH] fixup! Address review feedback from @copilot --- src/libxrpl/basics/Number.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libxrpl/basics/Number.cpp b/src/libxrpl/basics/Number.cpp index f266ead2b1..e279b7aa4d 100644 --- a/src/libxrpl/basics/Number.cpp +++ b/src/libxrpl/basics/Number.cpp @@ -392,7 +392,8 @@ Number::fromInternal(bool negative, Rep mantissa, int exponent, MantissaRange co auto const sign = negative ? -1 : 1; - mantissa_ = static_cast(sign * mantissa); + // mantissa is unsigned, but it might not be uint64 + mantissa_ = static_cast(sign * static_cast(mantissa)); exponent_ = exponent; XRPL_ASSERT_PARTS(