Fix clang-tidy issues

src/test/app/SHAMapStore_test.cpp

@@ -577,8 +577,6 @@ public:
 
         Env env{*this, envconfig(onlineDelete)};
 
-        std::map<LedgerIndex, uint256> hashes;
-
         auto failureMessage = [&](char const* label, auto expected, auto actual) {
             std::stringstream ss;
             ss << label << ": Expected: " << expected << ", Got: " << actual;

src/xrpld/app/ledger/detail/LedgerMaster.cpp

@@ -1540,7 +1540,7 @@ LedgerMaster::missingFromCompleteLedgerRange(LedgerIndex first, LedgerIndex last
 {
     // Make a copy of the range to avoid holding the lock
     auto const range = [&] {
-        std::lock_guard sl(mCompleteLock);
+        std::lock_guard const sl(mCompleteLock);
         return mCompleteLedgers;
     }();
 

src/xrpld/app/misc/SHAMapStoreImp.cpp

@@ -270,7 +270,7 @@ SHAMapStoreImp::run()
             // don't start the rotation until the validated ledger is fully
             // processed. It is not guaranteed to be done at this point. It also
             // allows the testLedgerGaps unit test to work.
-            std::unique_lock<std::mutex> lock(mutex_);
+            std::unique_lock<std::mutex> const lock(mutex_);
             lastGoodValidatedLedger_ = validatedSeq;
         }