From 2fb9a6a2920cd731477c77e7a55358aee9de96bb Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Sat, 22 Nov 2025 23:06:12 -0500 Subject: [PATCH] Review feedback from @Tapanito: tecKILLED logs - Log messages explaining Loan-related tecKILLED returns. --- src/xrpld/app/tx/detail/LoanSet.cpp | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/xrpld/app/tx/detail/LoanSet.cpp b/src/xrpld/app/tx/detail/LoanSet.cpp index e9eff856a6..0d86ade9dc 100644 --- a/src/xrpld/app/tx/detail/LoanSet.cpp +++ b/src/xrpld/app/tx/detail/LoanSet.cpp @@ -219,18 +219,32 @@ LoanSet::preclaim(PreclaimContext const& ctx) // The grace period can't be larger than the interval. Check it first, // mostly so that unit tests can test that specific case. if (grace > timeAvailable) + { + JLOG(ctx.j.warn()) << "Grace period exceeds protocol time limit."; return tecKILLED; + } if (interval > timeAvailable) + { + JLOG(ctx.j.warn()) + << "Payment interval exceeds protocol time limit."; return tecKILLED; + } if (total > timeAvailable) + { + JLOG(ctx.j.warn()) << "Payment total exceeds protocol time limit."; return tecKILLED; + } auto const timeLastPayment = timeAvailable - grace; if (timeLastPayment / interval < total) + { + JLOG(ctx.j.warn()) << "Last payment due date, or grace period for " + "last payment exceeds protocol time limit."; return tecKILLED; + } } auto const account = tx[sfAccount];