From 2f02fc2c044b88c4e75bc3ecabe05b9c93c757bf Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 11 Jun 2026 16:15:21 +0100 Subject: [PATCH] test(telemetry): use convention-correct attribute keys in SpanGuard test SpanGuardFactory.cpp set dotted "xrpl.rpc.command"/"xrpl.rpc.status" attribute keys. Test files are exempt from the naming check's Rule F (they pass arbitrary literals to exercise the API), so this slipped through, but the keys should still illustrate the underscore convention. Use "command"/"rpc_status". Co-Authored-By: Claude Opus 4.8 --- src/tests/libxrpl/telemetry/SpanGuardFactory.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tests/libxrpl/telemetry/SpanGuardFactory.cpp b/src/tests/libxrpl/telemetry/SpanGuardFactory.cpp index 674f0073be..4025a0b1ef 100644 --- a/src/tests/libxrpl/telemetry/SpanGuardFactory.cpp +++ b/src/tests/libxrpl/telemetry/SpanGuardFactory.cpp @@ -28,8 +28,8 @@ TEST(SpanGuardFactory, category_span_returns_null_when_disabled) auto span = SpanGuard::span(TraceCategory::Rpc, "rpc", "test"); EXPECT_FALSE(span); - span.setAttribute("xrpl.rpc.command", "test"); - span.setAttribute("xrpl.rpc.status", "success"); + span.setAttribute("command", "test"); + span.setAttribute("rpc_status", "success"); } TEST(SpanGuardFactory, child_span_null_when_no_parent)