From 2e425d60fd2d8521622b810c7bd3a9d662c21864 Mon Sep 17 00:00:00 2001 From: JoelKatz Date: Thu, 6 Dec 2012 18:59:10 -0800 Subject: [PATCH] Don't return rpcSUCCESS. --- src/cpp/ripple/RPCErr.cpp | 1 - src/cpp/ripple/RPCErr.h | 3 +-- src/cpp/ripple/RPCHandler.cpp | 4 ++-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/cpp/ripple/RPCErr.cpp b/src/cpp/ripple/RPCErr.cpp index 4e1eecc127..cbc699a4a3 100644 --- a/src/cpp/ripple/RPCErr.cpp +++ b/src/cpp/ripple/RPCErr.cpp @@ -58,7 +58,6 @@ Json::Value rpcError(int iError, Json::Value jvResult) { rpcSRC_ACT_MISSING, "srcActMissing", "Source account does not exist." }, { rpcSRC_AMT_MALFORMED, "srcAmtMalformed", "Source amount/currency/issuer is malformed." }, { rpcSRC_UNCLAIMED, "srcUnclaimed", "Source account is not claimed." }, - { rpcSUCCESS, "success", "Success." }, { rpcTXN_NOT_FOUND, "txnNotFound", "Transaction not found." }, { rpcUNKNOWN_COMMAND, "unknownCmd", "Unknown command." }, { rpcWRONG_SEED, "wrongSeed", "The regular key does not point as the master key." }, diff --git a/src/cpp/ripple/RPCErr.h b/src/cpp/ripple/RPCErr.h index d77cc24355..0059b35a45 100644 --- a/src/cpp/ripple/RPCErr.h +++ b/src/cpp/ripple/RPCErr.h @@ -4,8 +4,7 @@ #include "../json/value.h" enum { - rpcSUCCESS, - + rpcSUCCESS = 0, rpcBAD_SYNTAX, // Must be 1 to print usage to command line. rpcJSON_RPC, diff --git a/src/cpp/ripple/RPCHandler.cpp b/src/cpp/ripple/RPCHandler.cpp index 9a6d6191d2..dce825aaca 100644 --- a/src/cpp/ripple/RPCHandler.cpp +++ b/src/cpp/ripple/RPCHandler.cpp @@ -1564,7 +1564,7 @@ Json::Value RPCHandler::doLogLevel(Json::Value jvRequest) if (!jvRequest.isMember("partition")) { // set base log severity Log::setMinSeverity(sv, true); - return rpcError(rpcSUCCESS); + return Json::objectValue; } // log_level partition severity base? @@ -1576,7 +1576,7 @@ Json::Value RPCHandler::doLogLevel(Json::Value jvRequest) else if (!LogPartition::setSeverity(partition, sv)) return rpcError(rpcINVALID_PARAMS); - return rpcError(rpcSUCCESS); + return Json::objectValue; } return rpcError(rpcINVALID_PARAMS);