ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-27 14:35:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Initial implementation of Vault invariants for Loan operations

Browse Source
This commit is contained in:
Bronek Kozicki
2025-10-10 15:14:32 +01:00
parent 8152bcb1f3
commit 2d37254504
1 changed files with 116 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

127
src/xrpld/app/tx/detail/InvariantCheck.cpp
View File

@@ -2857,7 +2857,7 @@ ValidVault::finalize(
if (!beforeVault_.empty() && if (!beforeVault_.empty() &&
afterVault.lossUnrealized != beforeVault_[0].lossUnrealized && afterVault.lossUnrealized != beforeVault_[0].lossUnrealized &&
tx.getTxnType() != ttLOAN_MANAGE) txnType != ttLOAN_MANAGE && txnType != ttLOAN_PAY)
{ {
JLOG(j.fatal()) << // JLOG(j.fatal()) << //
"Invariant failed: vault transaction must not change loss " "Invariant failed: vault transaction must not change loss "
@@ -2879,9 +2879,9 @@ ValidVault::finalize(
}(); }();
if (!beforeShares && if (!beforeShares &&
(tx.getTxnType() == ttVAULT_DEPOSIT || // (txnType == ttVAULT_DEPOSIT || //
tx.getTxnType() == ttVAULT_WITHDRAW || // txnType == ttVAULT_WITHDRAW || //
tx.getTxnType() == ttVAULT_CLAWBACK)) txnType == ttVAULT_CLAWBACK))
{ {
JLOG(j.fatal()) << "Invariant failed: vault operation succeeded " JLOG(j.fatal()) << "Invariant failed: vault operation succeeded "
"without updating shares"; "without updating shares";
@@ -3414,17 +3414,122 @@ ValidVault::finalize(
return result; return result;
} }
case ttLOAN_SET: case ttLOAN_SET: {
case ttLOAN_MANAGE: bool result = true;
case ttLOAN_PAY: {
// TBD if (beforeShares)
return true; {
JLOG(j.fatal()) //
<< "Invariant failed: loan must not have updated vault "
"shares";
result = false;
}
XRPL_ASSERT(
!beforeVault_.empty(),
"ripple::ValidVault::finalize : loan updated a vault");
auto const& beforeVault = beforeVault_[0];
auto const vaultDeltaAssets = deltaAssets(afterVault.pseudoId);
if (!vaultDeltaAssets)
{
JLOG(j.fatal())
<< "Invariant failed: loan must change vault balance";
return false; // That's all we can do
}
if (*vaultDeltaAssets >= zero)
{
JLOG(j.fatal()) << "Invariant failed: loan must "
"decrease vault balance";
result = false;
}
auto loan =
beforeVault.assetsAvailable - afterVault.assetsAvailable;
if (loan <= zero)
{
JLOG(j.fatal())
<< "Invariant failed: loan must be greater than zero";
result = false;
}
auto const interest =
afterVault.assetsTotal - beforeVault.assetsTotal;
if (interest < zero)
{
JLOG(j.fatal())
<< "Invariant failed: loan interest must be positive";
result = false;
}
if (*vaultDeltaAssets * -1 != loan)
{
JLOG(j.fatal()) << "Invariant failed: loan must agree with "
"change of vault balance";
result = false;
}
return result;
}
case ttLOAN_PAY: {
bool result = true;
if (beforeShares)
{
JLOG(j.fatal()) //
<< "Invariant failed: loan must not have updated vault "
"shares";
result = false;
}
XRPL_ASSERT(
!beforeVault_.empty(),
"ripple::ValidVault::finalize : payment updated a vault");
// auto const& beforeVault = beforeVault_[0];
auto const vaultDeltaAssets = deltaAssets(afterVault.pseudoId);
if (!vaultDeltaAssets)
{
JLOG(j.fatal()) << "Invariant failed: payment must change "
"vault balance";
return false; // That's all we can do
}
if (*vaultDeltaAssets <= zero)
{
JLOG(j.fatal()) << "Invariant failed: payment must "
"increase vault balance";
result = false;
}
// TODO
return result;
}
case ttLOAN_MANAGE: {
bool result = true;
if (beforeShares)
{
JLOG(j.fatal()) //
<< "Invariant failed: loan management must not have "
"updated vault shares";
result = false;
}
// TODO
return result;
} }
default:
// LCOV_EXCL_START // LCOV_EXCL_START
default:
UNREACHABLE( UNREACHABLE(
"ripple::ValidVault::finalize : unknown transaction type"); "ripple::ValidVault::finalize : unknown transaction "
"type");
return false; return false;
// LCOV_EXCL_STOP // LCOV_EXCL_STOP
} }