From c45a3a912323821e573dc10a77d8011b3649c693 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 20 Jul 2026 18:06:34 +0100 Subject: [PATCH] fix(telemetry): correct Prometheus metric names in ValidationTracker.h comments An earlier Doxygen-style normalization pass on this file introduced a stray xrpld_ prefix into 5 comment references to the validation counters/gauge. The actual instrument names registered in MetricsRegistry.cpp have no such prefix (validation_agreements_total, validation_missed_total, validation_agreement). Comment-only fix. Co-Authored-By: Claude Opus 4.8 (1M context) --- src/xrpld/telemetry/ValidationTracker.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/xrpld/telemetry/ValidationTracker.h b/src/xrpld/telemetry/ValidationTracker.h index 150761b7bc..ac80f5cdf5 100644 --- a/src/xrpld/telemetry/ValidationTracker.h +++ b/src/xrpld/telemetry/ValidationTracker.h @@ -223,7 +223,7 @@ public: * @note Unlike totalAgreements(), this is strictly monotonic: it is * incremented only when a ledger is first reconciled as an agreement and * is never adjusted by a late repair. It backs the monotonic Prometheus - * counter xrpld_validation_agreements_total. See the counting-semantics + * counter validation_agreements_total. See the counting-semantics * note in detail/ValidationTracker.cpp. */ uint64_t @@ -235,7 +235,7 @@ public: * @note Unlike totalMissed(), this is strictly monotonic: it is * incremented only when a ledger is first reconciled as a miss and is * never decremented by a late repair. It backs the monotonic Prometheus - * counter xrpld_validation_missed_total. See the counting-semantics note + * counter validation_missed_total. See the counting-semantics note * in detail/ValidationTracker.cpp. */ uint64_t @@ -357,17 +357,17 @@ private: * strictly monotonic (a Prometheus _total must never decrease) and * additive: totalAgreementsGross_ + totalMissedGross_ == ledgers * reconciled. The repaired/agreement view is still available from the - * windowed gauge (xrpld_validation_agreement) and the net totals above. + * windowed gauge (validation_agreement) and the net totals above. */ /** * Monotonic lifetime initial agreements; backs - * xrpld_validation_agreements_total. Never adjusted on repair. + * validation_agreements_total. Never adjusted on repair. */ std::atomic totalAgreementsGross_{0}; /** - * Monotonic lifetime initial misses; backs xrpld_validation_missed_total. + * Monotonic lifetime initial misses; backs validation_missed_total. * Never decremented on repair. */ std::atomic totalMissedGross_{0};