test: enable unit tests to work with variable reference fee (#5145)

Fix remaining unit tests to be able to process reference fee values other than 10.
This commit is contained in:
Vlad
2025-03-25 14:31:25 +00:00
committed by GitHub
parent 67028d6ea6
commit 2bc5cb240f
37 changed files with 801 additions and 384 deletions

View File

@@ -43,7 +43,11 @@ private:
Account const bad("bad");
env.memoize(bad);
Oracle oracle(
env, {.owner = bad, .seq = seq(1), .err = ter(terNO_ACCOUNT)});
env,
{.owner = bad,
.seq = seq(1),
.fee = static_cast<int>(env.current()->fees().base.drops()),
.err = ter(terNO_ACCOUNT)});
}
// Insufficient reserve
@@ -51,7 +55,10 @@ private:
Env env(*this);
env.fund(env.current()->fees().accountReserve(0), owner);
Oracle oracle(
env, {.owner = owner, .err = ter(tecINSUFFICIENT_RESERVE)});
env,
{.owner = owner,
.fee = static_cast<int>(env.current()->fees().base.drops()),
.err = ter(tecINSUFFICIENT_RESERVE)});
}
// Insufficient reserve if the data series extends to greater than 5
{
@@ -60,7 +67,10 @@ private:
env.current()->fees().accountReserve(1) +
env.current()->fees().base * 2,
owner);
Oracle oracle(env, {.owner = owner});
Oracle oracle(
env,
{.owner = owner,
.fee = static_cast<int>(env.current()->fees().base.drops())});
BEAST_EXPECT(oracle.exists());
oracle.set(UpdateArg{
.series =
@@ -71,38 +81,47 @@ private:
{"XRP", "CAD", 740, 1},
{"XRP", "AUD", 740, 1},
},
.fee = static_cast<int>(env.current()->fees().base.drops()),
.err = ter(tecINSUFFICIENT_RESERVE)});
}
{
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner}, false);
Oracle oracle(env, {.owner = owner, .fee = baseFee}, false);
// Invalid flag
oracle.set(
CreateArg{.flags = tfSellNFToken, .err = ter(temINVALID_FLAG)});
oracle.set(CreateArg{
.flags = tfSellNFToken,
.fee = baseFee,
.err = ter(temINVALID_FLAG)});
// Duplicate token pair
oracle.set(CreateArg{
.series = {{"XRP", "USD", 740, 1}, {"XRP", "USD", 750, 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
// Price is not included
oracle.set(CreateArg{
.series =
{{"XRP", "USD", 740, 1}, {"XRP", "EUR", std::nullopt, 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
// Token pair is in update and delete
oracle.set(CreateArg{
.series =
{{"XRP", "USD", 740, 1}, {"XRP", "USD", std::nullopt, 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
// Token pair is in add and delete
oracle.set(CreateArg{
.series =
{{"XRP", "EUR", 740, 1}, {"XRP", "EUR", std::nullopt, 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
// Array of token pair is 0 or exceeds 10
@@ -119,19 +138,25 @@ private:
{"XRP", "US9", 740, 1},
{"XRP", "U10", 750, 1},
{"XRP", "U11", 740, 1}},
.fee = baseFee,
.err = ter(temARRAY_TOO_LARGE)});
oracle.set(CreateArg{.series = {}, .err = ter(temARRAY_EMPTY)});
oracle.set(CreateArg{
.series = {}, .fee = baseFee, .err = ter(temARRAY_EMPTY)});
}
// Array of token pair exceeds 10 after update
{
Env env{*this};
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(
env,
CreateArg{
.owner = owner, .series = {{{"XRP", "USD", 740, 1}}}});
.owner = owner,
.series = {{{"XRP", "USD", 740, 1}}},
.fee = baseFee});
oracle.set(UpdateArg{
.series =
{
@@ -146,75 +171,95 @@ private:
{"XRP", "US9", 740, 1},
{"XRP", "U10", 750, 1},
},
.fee = baseFee,
.err = ter(tecARRAY_TOO_LARGE)});
}
{
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner}, false);
Oracle oracle(env, {.owner = owner, .fee = baseFee}, false);
// Asset class or provider not included on create
oracle.set(CreateArg{
.assetClass = std::nullopt,
.provider = "provider",
.fee = baseFee,
.err = ter(temMALFORMED)});
oracle.set(CreateArg{
.assetClass = "currency",
.provider = std::nullopt,
.uri = "URI",
.fee = baseFee,
.err = ter(temMALFORMED)});
// Asset class or provider are included on update
// and don't match the current values
oracle.set(CreateArg{});
oracle.set(CreateArg{
.fee = static_cast<int>(env.current()->fees().base.drops())});
BEAST_EXPECT(oracle.exists());
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.provider = "provider1",
.fee = baseFee,
.err = ter(temMALFORMED)});
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.assetClass = "currency1",
.fee = baseFee,
.err = ter(temMALFORMED)});
}
{
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner}, false);
Oracle oracle(env, {.owner = owner, .fee = baseFee}, false);
// Fields too long
// Asset class
std::string assetClass(17, '0');
oracle.set(
CreateArg{.assetClass = assetClass, .err = ter(temMALFORMED)});
oracle.set(CreateArg{
.assetClass = assetClass,
.fee = baseFee,
.err = ter(temMALFORMED)});
// provider
std::string const large(257, '0');
oracle.set(CreateArg{.provider = large, .err = ter(temMALFORMED)});
oracle.set(CreateArg{
.provider = large, .fee = baseFee, .err = ter(temMALFORMED)});
// URI
oracle.set(CreateArg{.uri = large, .err = ter(temMALFORMED)});
oracle.set(CreateArg{
.uri = large, .fee = baseFee, .err = ter(temMALFORMED)});
// Empty field
// Asset class
oracle.set(CreateArg{.assetClass = "", .err = ter(temMALFORMED)});
oracle.set(CreateArg{
.assetClass = "", .fee = baseFee, .err = ter(temMALFORMED)});
// provider
oracle.set(CreateArg{.provider = "", .err = ter(temMALFORMED)});
oracle.set(CreateArg{
.provider = "", .fee = baseFee, .err = ter(temMALFORMED)});
// URI
oracle.set(CreateArg{.uri = "", .err = ter(temMALFORMED)});
oracle.set(
CreateArg{.uri = "", .fee = baseFee, .err = ter(temMALFORMED)});
}
{
// Different owner creates a new object and fails because
// of missing fields currency/provider
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
Account const some("some");
env.fund(XRP(1'000), owner);
env.fund(XRP(1'000), some);
Oracle oracle(env, {.owner = owner});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
BEAST_EXPECT(oracle.exists());
oracle.set(UpdateArg{
.owner = some,
.series = {{"XRP", "USD", 740, 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
}
@@ -222,6 +267,8 @@ private:
// Invalid update time
using namespace std::chrono;
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
auto closeTime = [&]() {
return duration_cast<seconds>(
env.current()->info().closeTime.time_since_epoch() -
@@ -229,89 +276,109 @@ private:
.count();
};
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
BEAST_EXPECT(oracle.exists());
env.close(seconds(400));
// Less than the last close time - 300s
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.lastUpdateTime = static_cast<std::uint32_t>(closeTime() - 301),
.fee = baseFee,
.err = ter(tecINVALID_UPDATE_TIME)});
// Greater than last close time + 300s
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.lastUpdateTime = static_cast<std::uint32_t>(closeTime() + 311),
.fee = baseFee,
.err = ter(tecINVALID_UPDATE_TIME)});
oracle.set(UpdateArg{.series = {{"XRP", "USD", 740, 1}}});
oracle.set(
UpdateArg{.series = {{"XRP", "USD", 740, 1}}, .fee = baseFee});
BEAST_EXPECT(oracle.expectLastUpdateTime(
static_cast<std::uint32_t>(testStartTime.count() + 450)));
// Less than the previous lastUpdateTime
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.lastUpdateTime = static_cast<std::uint32_t>(449),
.fee = baseFee,
.err = ter(tecINVALID_UPDATE_TIME)});
// Less than the epoch time
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.lastUpdateTime = static_cast<int>(epoch_offset.count() - 1),
.fee = baseFee,
.err = ter(tecINVALID_UPDATE_TIME)});
}
{
// delete token pair that doesn't exist
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
BEAST_EXPECT(oracle.exists());
oracle.set(UpdateArg{
.series = {{"XRP", "EUR", std::nullopt, std::nullopt}},
.fee = baseFee,
.err = ter(tecTOKEN_PAIR_NOT_FOUND)});
// delete all token pairs
oracle.set(UpdateArg{
.series = {{"XRP", "USD", std::nullopt, std::nullopt}},
.fee = baseFee,
.err = ter(tecARRAY_EMPTY)});
}
{
// same BaseAsset and QuoteAsset
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(
env,
{.owner = owner,
.series = {{"USD", "USD", 740, 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
}
{
// Scale is greater than maxPriceScale
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(
env,
{.owner = owner,
.series = {{"USD", "BTC", 740, maxPriceScale + 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
}
{
// Updating token pair to add and delete
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
oracle.set(UpdateArg{
.series =
{{"XRP", "EUR", std::nullopt, std::nullopt},
{"XRP", "EUR", 740, 1}},
.fee = baseFee,
.err = ter(temMALFORMED)});
// Delete token pair that doesn't exist in this oracle
oracle.set(UpdateArg{
.series = {{"XRP", "EUR", std::nullopt, std::nullopt}},
.fee = baseFee,
.err = ter(tecTOKEN_PAIR_NOT_FOUND)});
// Delete token pair in oracle, which is not in the ledger
oracle.set(UpdateArg{
.documentID = 10,
.series = {{"XRP", "EUR", std::nullopt, std::nullopt}},
.fee = baseFee,
.err = ter(temMALFORMED)});
}
@@ -321,7 +388,10 @@ private:
env.fund(XRP(1'000), owner);
Oracle oracle(
env, {.owner = owner, .fee = -1, .err = ter(temBAD_FEE)});
Oracle oracle1(env, {.owner = owner});
Oracle oracle1(
env,
{.owner = owner,
.fee = static_cast<int>(env.current()->fees().base.drops())});
oracle.set(
UpdateArg{.owner = owner, .fee = -1, .err = ter(temBAD_FEE)});
}
@@ -335,9 +405,12 @@ private:
Account const owner("owner");
auto test = [&](Env& env, DataSeries const& series, std::uint16_t adj) {
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
auto const count = ownerCount(env, owner);
Oracle oracle(env, {.owner = owner, .series = series});
Oracle oracle(
env, {.owner = owner, .series = series, .fee = baseFee});
BEAST_EXPECT(oracle.exists());
BEAST_EXPECT(ownerCount(env, owner) == (count + adj));
BEAST_EXPECT(oracle.expectLastUpdateTime(946694810));
@@ -366,13 +439,17 @@ private:
{
// Different owner creates a new object
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
Account const some("some");
env.fund(XRP(1'000), owner);
env.fund(XRP(1'000), some);
Oracle oracle(env, {.owner = owner});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
BEAST_EXPECT(oracle.exists());
oracle.set(CreateArg{
.owner = some, .series = {{"912810RR9", "USD", 740, 1}}});
.owner = some,
.series = {{"912810RR9", "USD", 740, 1}},
.fee = baseFee});
BEAST_EXPECT(Oracle::exists(env, some, oracle.documentID()));
}
}
@@ -384,9 +461,11 @@ private:
using namespace jtx;
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
Account const owner("owner");
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
BEAST_EXPECT(oracle.exists());
{
@@ -394,19 +473,27 @@ private:
Account const bad("bad");
env.memoize(bad);
oracle.remove(
{.owner = bad, .seq = seq(1), .err = ter(terNO_ACCOUNT)});
{.owner = bad,
.seq = seq(1),
.fee = baseFee,
.err = ter(terNO_ACCOUNT)});
}
// Invalid DocumentID
oracle.remove({.documentID = 2, .err = ter(tecNO_ENTRY)});
oracle.remove(
{.documentID = 2, .fee = baseFee, .err = ter(tecNO_ENTRY)});
// Invalid owner
Account const invalid("invalid");
env.fund(XRP(1'000), invalid);
oracle.remove({.owner = invalid, .err = ter(tecNO_ENTRY)});
oracle.remove(
{.owner = invalid, .fee = baseFee, .err = ter(tecNO_ENTRY)});
// Invalid flags
oracle.remove({.flags = tfSellNFToken, .err = ter(temINVALID_FLAG)});
oracle.remove(
{.flags = tfSellNFToken,
.fee = baseFee,
.err = ter(temINVALID_FLAG)});
// Bad fee
oracle.remove({.fee = -1, .err = ter(temBAD_FEE)});
@@ -420,11 +507,14 @@ private:
Account const owner("owner");
auto test = [&](Env& env, DataSeries const& series, std::uint16_t adj) {
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
Oracle oracle(env, {.owner = owner, .series = series});
Oracle oracle(
env, {.owner = owner, .series = series, .fee = baseFee});
auto const count = ownerCount(env, owner);
BEAST_EXPECT(oracle.exists());
oracle.remove({});
oracle.remove({.fee = baseFee});
BEAST_EXPECT(!oracle.exists());
BEAST_EXPECT(ownerCount(env, owner) == (count - adj));
};
@@ -454,17 +544,24 @@ private:
{
// deleting the account deletes the oracles
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
auto const alice = Account("alice");
auto const acctDelFee{drops(env.current()->fees().increment)};
env.fund(XRP(1'000), owner);
env.fund(XRP(1'000), alice);
Oracle oracle(
env, {.owner = owner, .series = {{"XRP", "USD", 740, 1}}});
env,
{.owner = owner,
.series = {{"XRP", "USD", 740, 1}},
.fee = baseFee});
Oracle oracle1(
env,
{.owner = owner,
.documentID = 2,
.series = {{"XRP", "EUR", 740, 1}}});
.series = {{"XRP", "EUR", 740, 1}},
.fee = baseFee});
BEAST_EXPECT(ownerCount(env, owner) == 2);
BEAST_EXPECT(oracle.exists());
BEAST_EXPECT(oracle1.exists());
@@ -503,13 +600,16 @@ private:
{
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
auto count = ownerCount(env, owner);
Oracle oracle(env, {.owner = owner});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
BEAST_EXPECT(oracle.exists());
// update existing pair
oracle.set(UpdateArg{.series = {{"XRP", "USD", 740, 2}}});
oracle.set(
UpdateArg{.series = {{"XRP", "USD", 740, 2}}, .fee = baseFee});
BEAST_EXPECT(oracle.expectPrice({{"XRP", "USD", 740, 2}}));
// owner count is increased by 1 since the oracle object is added
// with one token pair
@@ -517,7 +617,8 @@ private:
BEAST_EXPECT(ownerCount(env, owner) == count);
// add new pairs, not-included pair is reset
oracle.set(UpdateArg{.series = {{"XRP", "EUR", 700, 2}}});
oracle.set(
UpdateArg{.series = {{"XRP", "EUR", 700, 2}}, .fee = baseFee});
BEAST_EXPECT(oracle.expectPrice(
{{"XRP", "USD", 0, 0}, {"XRP", "EUR", 700, 2}}));
// owner count is not changed since the number of pairs is 2
@@ -525,7 +626,8 @@ private:
// update both pairs
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 741, 2}, {"XRP", "EUR", 710, 2}}});
.series = {{"XRP", "USD", 741, 2}, {"XRP", "EUR", 710, 2}},
.fee = baseFee});
BEAST_EXPECT(oracle.expectPrice(
{{"XRP", "USD", 741, 2}, {"XRP", "EUR", 710, 2}}));
// owner count is not changed since the number of pairs is 2
@@ -533,25 +635,29 @@ private:
// owner count is increased by 1 since the number of pairs is 6
oracle.set(UpdateArg{
.series = {
{"BTC", "USD", 741, 2},
{"ETH", "EUR", 710, 2},
{"YAN", "EUR", 710, 2},
{"CAN", "EUR", 710, 2},
}});
.series =
{
{"BTC", "USD", 741, 2},
{"ETH", "EUR", 710, 2},
{"YAN", "EUR", 710, 2},
{"CAN", "EUR", 710, 2},
},
.fee = baseFee});
count += 1;
BEAST_EXPECT(ownerCount(env, owner) == count);
// update two pairs and delete four
oracle.set(UpdateArg{
.series = {{"BTC", "USD", std::nullopt, std::nullopt}}});
.series = {{"BTC", "USD", std::nullopt, std::nullopt}},
.fee = baseFee});
oracle.set(UpdateArg{
.series = {
{"XRP", "USD", 742, 2},
{"XRP", "EUR", 711, 2},
{"ETH", "EUR", std::nullopt, std::nullopt},
{"YAN", "EUR", std::nullopt, std::nullopt},
{"CAN", "EUR", std::nullopt, std::nullopt}}});
.series =
{{"XRP", "USD", 742, 2},
{"XRP", "EUR", 711, 2},
{"ETH", "EUR", std::nullopt, std::nullopt},
{"YAN", "EUR", std::nullopt, std::nullopt},
{"CAN", "EUR", std::nullopt, std::nullopt}},
.fee = baseFee});
BEAST_EXPECT(oracle.expectPrice(
{{"XRP", "USD", 742, 2}, {"XRP", "EUR", 711, 2}}));
// owner count is decreased by 1 since the number of pairs is 2
@@ -562,12 +668,15 @@ private:
// Min reserve to create and update
{
Env env(*this);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(
env.current()->fees().accountReserve(1) +
env.current()->fees().base * 2,
owner);
Oracle oracle(env, {.owner = owner});
oracle.set(UpdateArg{.series = {{"XRP", "USD", 742, 2}}});
Oracle oracle(env, {.owner = owner, .fee = baseFee});
oracle.set(
UpdateArg{.series = {{"XRP", "USD", 742, 2}}, .fee = baseFee});
}
}
@@ -579,6 +688,9 @@ private:
Oracle::setFee(100'000);
Env env(*this, features);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
Account const alice{"alice", KeyType::secp256k1};
Account const bogie{"bogie", KeyType::secp256k1};
Account const ed{"ed", KeyType::secp256k1};
@@ -602,24 +714,32 @@ private:
// Create
// Force close (true) and time advancement because the close time
// is no longer 0.
Oracle oracle(env, CreateArg{.owner = alice, .close = true}, false);
oracle.set(CreateArg{.msig = msig(becky), .err = ter(tefBAD_QUORUM)});
oracle.set(
CreateArg{.msig = msig(zelda), .err = ter(tefBAD_SIGNATURE)});
oracle.set(CreateArg{.msig = msig(becky, bogie)});
Oracle oracle(
env,
CreateArg{.owner = alice, .fee = baseFee, .close = true},
false);
oracle.set(CreateArg{
.msig = msig(becky), .fee = baseFee, .err = ter(tefBAD_QUORUM)});
oracle.set(CreateArg{
.msig = msig(zelda), .fee = baseFee, .err = ter(tefBAD_SIGNATURE)});
oracle.set(CreateArg{.msig = msig(becky, bogie), .fee = baseFee});
BEAST_EXPECT(oracle.exists());
// Update
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.msig = msig(becky),
.fee = baseFee,
.err = ter(tefBAD_QUORUM)});
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.msig = msig(zelda),
.fee = baseFee,
.err = ter(tefBAD_SIGNATURE)});
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 741, 1}}, .msig = msig(becky, bogie)});
.series = {{"XRP", "USD", 741, 1}},
.msig = msig(becky, bogie),
.fee = baseFee});
BEAST_EXPECT(oracle.expectPrice({{"XRP", "USD", 741, 1}}));
// remove the signer list
env(signers(alice, jtx::none), sig(alie));
@@ -632,19 +752,28 @@ private:
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 740, 1}},
.msig = msig(becky, bogie),
.fee = baseFee,
.err = ter(tefBAD_SIGNATURE)});
// updated list succeeds
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 7412, 2}}, .msig = msig(zelda, bob)});
.series = {{"XRP", "USD", 7412, 2}},
.msig = msig(zelda, bob),
.fee = baseFee});
BEAST_EXPECT(oracle.expectPrice({{"XRP", "USD", 7412, 2}}));
oracle.set(
UpdateArg{.series = {{"XRP", "USD", 74245, 3}}, .msig = msig(ed)});
oracle.set(UpdateArg{
.series = {{"XRP", "USD", 74245, 3}},
.msig = msig(ed),
.fee = baseFee});
BEAST_EXPECT(oracle.expectPrice({{"XRP", "USD", 74245, 3}}));
// Remove
oracle.remove({.msig = msig(bob), .err = ter(tefBAD_QUORUM)});
oracle.remove({.msig = msig(becky), .err = ter(tefBAD_SIGNATURE)});
oracle.remove({.msig = msig(ed)});
oracle.remove(
{.msig = msig(bob), .fee = baseFee, .err = ter(tefBAD_QUORUM)});
oracle.remove(
{.msig = msig(becky),
.fee = baseFee,
.err = ter(tefBAD_SIGNATURE)});
oracle.remove({.msig = msig(ed), .fee = baseFee});
BEAST_EXPECT(!oracle.exists());
}
@@ -657,15 +786,18 @@ private:
auto const features = supported_amendments() - featurePriceOracle;
Account const owner("owner");
Env env(*this, features);
auto const baseFee =
static_cast<int>(env.current()->fees().base.drops());
env.fund(XRP(1'000), owner);
{
Oracle oracle(env, {.owner = owner, .err = ter(temDISABLED)});
Oracle oracle(
env, {.owner = owner, .fee = baseFee, .err = ter(temDISABLED)});
}
{
Oracle oracle(env, {.owner = owner}, false);
oracle.remove({.err = ter(temDISABLED)});
Oracle oracle(env, {.owner = owner, .fee = baseFee}, false);
oracle.remove({.fee = baseFee, .err = ter(temDISABLED)});
}
}