Fix clang warnings about copies vs references:

A recent version of clang notes a number of places in range
for loops where the code base was making unnecessary copies
or using const lvalue references to extend lifetimes.  This
fixes the places that clang identified.

src/ripple/app/misc/impl/ValidatorList.cpp

@@ -99,7 +99,7 @@ void
 ValidatorList::PublisherListStats::mergeDispositions(
     PublisherListStats const& src)
 {
-    for (auto const [disp, count] : src.dispositions)
+    for (auto const& [disp, count] : src.dispositions)
     {
         dispositions[disp] += count;
     }

src/ripple/app/misc/impl/ValidatorSite.cpp

@@ -408,7 +408,7 @@ ValidatorSite::parseJsonResponse(
     sites_[siteIdx].lastRefreshStatus.emplace(
         Site::Status{clock_type::now(), applyResult.bestDisposition(), ""});
 
-    for (auto const [disp, count] : applyResult.dispositions)
+    for (auto const& [disp, count] : applyResult.dispositions)
     {
         switch (disp)
         {

src/ripple/overlay/impl/ConnectAttempt.cpp

@@ -293,7 +293,7 @@ ConnectAttempt::processResponse()
         Json::Reader r;
         std::string s;
         s.reserve(boost::asio::buffer_size(response_.body().data()));
-        for (auto const& buffer : response_.body().data())
+        for (auto const buffer : response_.body().data())
             s.append(
                 boost::asio::buffer_cast<char const*>(buffer),
                 boost::asio::buffer_size(buffer));

src/ripple/overlay/impl/PeerImp.cpp

@@ -2168,7 +2168,7 @@ PeerImp::onValidatorListMessage(
     }
 
     // Log based on all the results.
-    for (auto const [disp, count] : applyResult.dispositions)
+    for (auto const& [disp, count] : applyResult.dispositions)
     {
         switch (disp)
         {

src/ripple/rpc/impl/ServerHandlerImp.cpp

@@ -264,7 +264,9 @@ buffers_to_string(ConstBufferSequence const& bs)
     using boost::asio::buffer_size;
     std::string s;
     s.reserve(buffer_size(bs));
-    for (auto const& b : bs)
+    // Use auto&& so the right thing happens whether bs returns a copy or
+    // a reference
+    for (auto&& b : bs)
         s.append(buffer_cast<char const*>(b), buffer_size(b));
     return s;
 }

src/ripple/server/SimpleWriter.h

@@ -66,7 +66,7 @@ public:
         auto const& buf = sb_.data();
         std::vector<boost::asio::const_buffer> result;
         result.reserve(std::distance(buf.begin(), buf.end()));
-        for (auto const& b : buf)
+        for (auto const b : buf)
             result.push_back(b);
         return result;
     }