From 90b3726ed77ec8304977394990ed3d33ac1d9a0e Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 6 Jul 2026 13:19:21 +0100 Subject: [PATCH] fix: make csf::Peer::getTelemetry() static to satisfy clang-tidy The test Peer adaptor's getTelemetry() returns a shared function-local NullTelemetry instance and does not read any per-peer state, so clang-tidy's readability-convert-member-functions-to-static flags it as an error under -warnings-as-errors. Mark it static; it has no callers that depend on it being a non-static member. Co-Authored-By: Claude Opus 4.8 --- src/test/csf/Peer.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/test/csf/Peer.h b/src/test/csf/Peer.h index 74406b9c83..9778d5464d 100644 --- a/src/test/csf/Peer.h +++ b/src/test/csf/Peer.h @@ -640,9 +640,10 @@ struct Peer * * The test Peer adaptor uses a static disabled NullTelemetry instance * so that all shouldTrace*() checks return false and no spans are - * created during simulation tests. + * created during simulation tests. It is static because the shared + * disabled instance does not depend on any per-peer state. */ - telemetry::Telemetry& + static telemetry::Telemetry& getTelemetry() { static auto tel = telemetry::makeTelemetry(