Merge branch 'develop' into ximinez/fix-getledger

src/test/app/LedgerReplay_test.cpp

@@ -235,7 +235,7 @@ public:
     send(std::shared_ptr<Message> const& m) override
     {
     }
-    beast::IP::Endpoint
+    [[nodiscard]] beast::IP::Endpoint
     getRemoteAddress() const override
     {
         return {};
@@ -244,27 +244,27 @@ public:
     charge(Resource::Charge const& fee, std::string const& context = {}) override
     {
     }
-    id_t
+    [[nodiscard]] id_t
     id() const override
     {
         return 1234;
     }
-    bool
+    [[nodiscard]] bool
     cluster() const override
     {
         return false;
     }
-    bool
+    [[nodiscard]] bool
     isHighLatency() const override
     {
         return false;
     }
-    int
+    [[nodiscard]] int
     getScore(bool) const override
     {
         return 0;
     }
-    PublicKey const&
+    [[nodiscard]] PublicKey const&
     getNodePublic() const override
     {
         return nodePublicKey_;
@@ -274,12 +274,12 @@ public:
     {
         return {};
     }
-    bool
+    [[nodiscard]] bool
     supportsFeature(ProtocolFeature f) const override
     {
         return f == ProtocolFeature::LedgerReplay && ledgerReplayEnabled_;
     }
-    std::optional<std::size_t>
+    [[nodiscard]] std::optional<std::size_t>
     publisherListSequence(PublicKey const&) const override
     {
         return {};
@@ -288,13 +288,13 @@ public:
     setPublisherListSequence(PublicKey const&, std::size_t const) override
     {
     }
-    uint256 const&
+    [[nodiscard]] uint256 const&
     getClosedLedgerHash() const override
     {
         static uint256 const hash{};
         return hash;
     }
-    bool
+    [[nodiscard]] bool
     hasLedger(uint256 const& hash, std::uint32_t seq) const override
     {
         return true;
@@ -303,7 +303,7 @@ public:
     ledgerRange(std::uint32_t& minSeq, std::uint32_t& maxSeq) const override
     {
     }
-    bool
+    [[nodiscard]] bool
     hasTxSet(uint256 const& hash) const override
     {
         return false;
@@ -317,7 +317,7 @@ public:
     {
         return false;
     }
-    bool
+    [[nodiscard]] bool
     compressionEnabled() const override
     {
         return false;
@@ -334,7 +334,7 @@ public:
     removeTxQueue(uint256 const&) override
     {
     }
-    bool
+    [[nodiscard]] bool
     txReduceRelayEnabled() const override
     {
         return false;
@@ -345,7 +345,7 @@ public:
         return {};
     }
 
-    std::string const&
+    [[nodiscard]] std::string const&
     fingerprint() const override
     {
         return fingerprint_;
@@ -445,7 +445,7 @@ struct TestPeerSet : public PeerSet
         }
     }
 
-    std::set<Peer::id_t> const&
+    [[nodiscard]] std::set<Peer::id_t> const&
     getPeerIds() const override
     {
         static std::set<Peer::id_t> const emptyPeers;