chore: Enable clang-tidy misc checks (#6655)

This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions

View File

@@ -13,7 +13,8 @@ public:
unexpected(sfGeneric.isUseful(), "sfGeneric must not be useful");
{
// Try to put sfGeneric in an SOTemplate.
except<std::runtime_error>([&]() { SOTemplate elements{{sfGeneric, soeREQUIRED}}; });
except<std::runtime_error>(
[&]() { SOTemplate const elements{{sfGeneric, soeREQUIRED}}; });
}
unexpected(sfInvalid.isUseful(), "sfInvalid must not be useful");
@@ -31,12 +32,13 @@ public:
}
{
// Try to put sfInvalid in an SOTemplate.
except<std::runtime_error>([&]() { SOTemplate elements{{sfInvalid, soeREQUIRED}}; });
except<std::runtime_error>(
[&]() { SOTemplate const elements{{sfInvalid, soeREQUIRED}}; });
}
{
// Try to put the same SField into an SOTemplate twice.
except<std::runtime_error>([&]() {
SOTemplate elements{
SOTemplate const elements{
{sfAccount, soeREQUIRED},
{sfAccount, soeREQUIRED},
};
@@ -59,7 +61,7 @@ public:
};
STObject object1(elements, sfTestObject);
STObject object2(object1);
STObject const object2(object1);
unexpected(object1.getSerializer() != object2.getSerializer(), "STObject error 1");
@@ -106,7 +108,7 @@ public:
for (int i = 0; i < 1000; i++)
{
Blob j(i, 2);
Blob const j(i, 2);
object1.setFieldVL(sfTestVL, j);
@@ -114,7 +116,7 @@ public:
object1.add(s);
SerialIter it(s.slice());
STObject object3(elements, it, sfTestObject);
STObject const object3(elements, it, sfTestObject);
unexpected(object1.getFieldVL(sfTestVL) != j, "STObject error");
@@ -134,7 +136,7 @@ public:
object1.add(s);
SerialIter it(s.slice());
STObject object3(elements, it, sfTestObject);
STObject const object3(elements, it, sfTestObject);
auto const& uints1 = object1.getFieldV256(sfTestV256);
auto const& uints3 = object3.getFieldV256(sfTestV256);
@@ -475,7 +477,7 @@ public:
run() override
{
// Instantiate a jtx::Env so debugLog writes are exercised.
test::jtx::Env env(*this);
test::jtx::Env const env(*this);
testFields();
testSerialization();