chore: Enable clang-tidy misc checks (#6655)

This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions

View File

@@ -114,7 +114,7 @@ class View_test : public beast::unit_test::suite
using namespace jtx;
Env env(*this);
Config config;
Config const config;
std::shared_ptr<Ledger const> const genesis = std::make_shared<Ledger>(
create_genesis,
Rules{config.features},
@@ -124,7 +124,7 @@ class View_test : public beast::unit_test::suite
auto const ledger =
std::make_shared<Ledger>(*genesis, env.app().getTimeKeeper().closeTime());
wipe(*ledger);
ReadView& v = *ledger;
ReadView const& v = *ledger;
succ(v, 0, std::nullopt);
ledger->rawInsert(sle(1, 1));
BEAST_EXPECT(v.exists(k(1)));
@@ -338,7 +338,7 @@ class View_test : public beast::unit_test::suite
BEAST_EXPECT(v2.seq() == v1.seq());
BEAST_EXPECT(v2.flags() == tapRETRY);
Sandbox v3(&v2);
Sandbox const v3(&v2);
BEAST_EXPECT(v3.seq() == v2.seq());
BEAST_EXPECT(v3.parentCloseTime() == v2.parentCloseTime());
BEAST_EXPECT(v3.flags() == tapRETRY);
@@ -349,7 +349,7 @@ class View_test : public beast::unit_test::suite
BEAST_EXPECT(v2.seq() == v0.seq());
BEAST_EXPECT(v2.parentCloseTime() == v0.parentCloseTime());
BEAST_EXPECT(v2.flags() == tapRETRY);
PaymentSandbox v3(&v2);
PaymentSandbox const v3(&v2);
BEAST_EXPECT(v3.seq() == v2.seq());
BEAST_EXPECT(v3.parentCloseTime() == v2.parentCloseTime());
BEAST_EXPECT(v3.flags() == v2.flags());
@@ -382,7 +382,7 @@ class View_test : public beast::unit_test::suite
using namespace jtx;
Env env(*this);
Config config;
Config const config;
std::shared_ptr<Ledger const> const genesis = std::make_shared<Ledger>(
create_genesis,
Rules{config.features},
@@ -591,7 +591,7 @@ class View_test : public beast::unit_test::suite
using namespace jtx;
Env env(*this);
Config config;
Config const config;
std::shared_ptr<Ledger const> const genesis = std::make_shared<Ledger>(
create_genesis,
Rules{config.features},
@@ -942,7 +942,7 @@ class View_test : public beast::unit_test::suite
// erase the item, apply.
{
Env env(*this);
Config config;
Config const config;
std::shared_ptr<Ledger const> const genesis = std::make_shared<Ledger>(
create_genesis,
Rules{config.features},
@@ -953,7 +953,7 @@ class View_test : public beast::unit_test::suite
std::make_shared<Ledger>(*genesis, env.app().getTimeKeeper().closeTime());
wipe(*ledger);
ledger->rawInsert(sle(1));
ReadView& v0 = *ledger;
ReadView const& v0 = *ledger;
ApplyViewImpl v1(&v0, tapNONE);
{
Sandbox v2(&v1);