ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy misc checks (#6655)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

178
src/test/app/Vault_test.cpp
View File

@@ -90,8 +90,8 @@ class Vault_test : public beast::unit_test::suite
env.memoize(vaultAccount);
// Several 3rd party accounts which cannot receive funds
Account alice{"alice"};
Account erin{"erin"}; // not authorized by issuer
Account const alice{"alice"};
Account const erin{"erin"}; // not authorized by issuer
env.fund(XRP(1000), alice, erin);
env(fset(alice, asfDepositAuth));
env.close();
@@ -514,14 +514,14 @@ class Vault_test : public beast::unit_test::suite
env.require(flags(issuer, asfAllowTrustLineClawback));
env.require(flags(issuer, asfRequireAuth));
PrettyAsset asset = setup(env);
PrettyAsset const asset = setup(env);
testSequence(prefix, env, vault, asset);
};
testCases("XRP", [&](Env& env) -> PrettyAsset { return {xrpIssue(), 1'000'000}; });
testCases("IOU", [&](Env& env) -> Asset {
PrettyAsset asset = issuer["IOU"];
PrettyAsset const asset = issuer["IOU"];
env(trust(owner, asset(1000)));
env(trust(depositor, asset(1000)));
env(trust(charlie, asset(1000)));
@@ -538,7 +538,7 @@ class Vault_test : public beast::unit_test::suite
testCases("MPT", [&](Env& env) -> Asset {
MPTTester mptt{env, issuer, mptInitNoFund};
mptt.create({.flags = tfMPTCanClawback | tfMPTCanTransfer | tfMPTCanLock});
PrettyAsset asset = mptt.issuanceID();
PrettyAsset const asset = mptt.issuanceID();
mptt.authorize({.account = depositor});
mptt.authorize({.account = charlie});
mptt.authorize({.account = dave});
@@ -567,8 +567,8 @@ class Vault_test : public beast::unit_test::suite
Vault& vault)> test,
CaseArgs args = {}) {
Env env{*this, args.features};
Account issuer{"issuer"};
Account owner{"owner"};
Account const issuer{"issuer"};
Account const owner{"owner"};
Vault vault{env};
env.fund(XRP(1000), issuer, owner);
env.close();
@@ -577,7 +577,7 @@ class Vault_test : public beast::unit_test::suite
env(fset(issuer, asfRequireAuth));
env.close();
PrettyAsset asset = issuer["IOU"];
PrettyAsset const asset = issuer["IOU"];
env(trust(owner, asset(1000)));
env(trust(issuer, asset(0), owner, tfSetfAuth));
env(pay(issuer, owner, asset(1000)));
@@ -1081,13 +1081,13 @@ class Vault_test : public beast::unit_test::suite
Asset const& asset,
Vault& vault)> test) {
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account depositor{"depositor"};
Account const issuer{"issuer"};
Account const owner{"owner"};
Account const depositor{"depositor"};
env.fund(XRP(1000), issuer, owner, depositor);
env.close();
Vault vault{env};
Asset asset = xrpIssue();
Asset const asset = xrpIssue();
test(env, issuer, owner, depositor, asset, vault);
};
@@ -1246,13 +1246,13 @@ class Vault_test : public beast::unit_test::suite
testcase("IOU fail because MPT is disabled");
Env env{
*this, (testable_amendments() - featureMPTokensV1) | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account const issuer{"issuer"};
Account const owner{"owner"};
env.fund(XRP(1000), issuer, owner);
env.close();
Vault vault{env};
Asset asset = issuer["IOU"].asset();
Vault const vault{env};
Asset const asset = issuer["IOU"].asset();
auto [tx, keylet] = vault.create({.owner = owner, .asset = asset});
env(tx, ter(temDISABLED));
@@ -1262,15 +1262,15 @@ class Vault_test : public beast::unit_test::suite
{
testcase("IOU fail create frozen");
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account const issuer{"issuer"};
Account const owner{"owner"};
env.fund(XRP(1000), issuer, owner);
env.close();
env(fset(issuer, asfGlobalFreeze));
env.close();
Vault vault{env};
Asset asset = issuer["IOU"].asset();
Vault const vault{env};
Asset const asset = issuer["IOU"].asset();
auto [tx, keylet] = vault.create({.owner = owner, .asset = asset});
env(tx, ter(tecFROZEN));
@@ -1280,15 +1280,15 @@ class Vault_test : public beast::unit_test::suite
{
testcase("IOU fail create no ripling");
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account const issuer{"issuer"};
Account const owner{"owner"};
env.fund(XRP(1000), issuer, owner);
env.close();
env(fclear(issuer, asfDefaultRipple));
env.close();
Vault vault{env};
Asset asset = issuer["IOU"].asset();
Vault const vault{env};
Asset const asset = issuer["IOU"].asset();
auto [tx, keylet] = vault.create({.owner = owner, .asset = asset});
env(tx, ter(terNO_RIPPLE));
env.close();
@@ -1297,13 +1297,13 @@ class Vault_test : public beast::unit_test::suite
{
testcase("IOU no issuer");
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account const issuer{"issuer"};
Account const owner{"owner"};
env.fund(XRP(1000), owner);
env.close();
Vault vault{env};
Asset asset = issuer["IOU"].asset();
Vault const vault{env};
Asset const asset = issuer["IOU"].asset();
{
auto [tx, keylet] = vault.create({.owner = owner, .asset = asset});
env(tx, ter(terNO_ACCOUNT));
@@ -1351,12 +1351,12 @@ class Vault_test : public beast::unit_test::suite
fund(env, gw, {alice, carol}, toFund2, {toFund1}, Fund::All);
}
AMM ammAlice(env, alice, asset1, asset2, CreateArg{.log = false, .tfee = 0});
AMM const ammAlice(env, alice, asset1, asset2, CreateArg{.log = false, .tfee = 0});
Account const owner{"owner"};
env.fund(XRP(1000000), owner);
Vault vault{env};
Vault const vault{env};
auto [tx, k] = vault.create({.owner = owner, .asset = ammAlice.lptIssue()});
env(tx, ter{tecWRONG_ASSET});
env.close();
@@ -1377,16 +1377,16 @@ class Vault_test : public beast::unit_test::suite
Asset const& asset,
Vault& vault)> test) {
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account depositor{"depositor"};
Account const issuer{"issuer"};
Account const owner{"owner"};
Account const depositor{"depositor"};
env.fund(XRP(1000), issuer, owner, depositor);
env.close();
Vault vault{env};
MPTTester mptt{env, issuer, mptInitNoFund};
// Locked because that is the default flag.
mptt.create();
Asset asset = mptt.issuanceID();
Asset const asset = mptt.issuanceID();
test(env, issuer, owner, depositor, asset, vault);
};
@@ -1436,14 +1436,14 @@ class Vault_test : public beast::unit_test::suite
using namespace test::jtx;
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account depositor{"depositor"};
Account const issuer{"issuer"};
Account const owner{"owner"};
Account const depositor{"depositor"};
env.fund(XRP(1000), issuer, owner, depositor);
env.close();
Vault vault{env};
PrettyAsset asset = issuer["IOU"];
Vault const vault{env};
PrettyAsset const asset = issuer["IOU"];
env.trust(asset(1000), owner);
env(pay(issuer, owner, asset(100)));
env.trust(asset(1000), depositor);
@@ -1480,7 +1480,7 @@ class Vault_test : public beast::unit_test::suite
}();
auto const MptID = makeMptID(1, vaultAccount);
Asset shares = MptID;
Asset const shares = MptID;
{
testcase("nontransferable shares cannot be moved");
@@ -1563,7 +1563,7 @@ class Vault_test : public beast::unit_test::suite
(args.enableClawback ? tfMPTCanClawback : none) |
(args.requireAuth ? tfMPTRequireAuth : none),
.mutableFlags = tmfMPTCanMutateCanTransfer});
PrettyAsset asset = mptt.issuanceID();
PrettyAsset const asset = mptt.issuanceID();
mptt.authorize({.account = owner});
mptt.authorize({.account = depositor});
if (args.requireAuth)
@@ -1654,10 +1654,10 @@ class Vault_test : public beast::unit_test::suite
// accounts for the issued shares.
auto v = env.le(keylet);
BEAST_EXPECT(v);
MPTID share = (*v)[sfShareMPTID];
MPTID const share = (*v)[sfShareMPTID];
auto issuance = env.le(keylet::mptIssuance(share));
BEAST_EXPECT(issuance);
Number outstandingShares = issuance->at(sfOutstandingAmount);
Number const outstandingShares = issuance->at(sfOutstandingAmount);
BEAST_EXPECT(outstandingShares == 100);
mptt.set({.account = issuer, .flags = tfMPTLock});
@@ -1761,7 +1761,7 @@ class Vault_test : public beast::unit_test::suite
{
// Set destination to 3rd party without MPToken
Account charlie{"charlie"};
Account const charlie{"charlie"};
env.fund(XRP(1000), charlie);
env.close();
@@ -1838,7 +1838,7 @@ class Vault_test : public beast::unit_test::suite
{.requireAuth = false});
auto const [acctReserve, incReserve] = [this]() -> std::pair<int, int> {
Env env{*this, testable_amendments()};
Env const env{*this, testable_amendments()};
return {
env.current()->fees().accountReserve(0).drops() / DROPS_PER_XRP.drops(),
env.current()->fees().increment.drops() / DROPS_PER_XRP.drops()};
@@ -1975,7 +1975,7 @@ class Vault_test : public beast::unit_test::suite
auto const vault = env.le(keylet);
return vault->at(sfShareMPTID);
}(keylet);
PrettyAsset shares = MPTIssue(issuanceId);
PrettyAsset const shares = MPTIssue(issuanceId);
{
// owner has MPToken for shares they did not explicitly create
@@ -2177,14 +2177,14 @@ class Vault_test : public beast::unit_test::suite
Account issuer{"issuer"};
env.fund(XRP(1000000), owner, issuer);
env.close();
Vault vault{env};
Vault const vault{env};
MPTTester mptt{env, issuer, mptInitNoFund};
mptt.create(
{.flags = tfMPTCanTransfer | tfMPTCanLock | lsfMPTCanClawback | tfMPTRequireAuth});
mptt.authorize({.account = owner});
mptt.authorize({.account = issuer, .holder = owner});
PrettyAsset asset = mptt.issuanceID();
PrettyAsset const asset = mptt.issuanceID();
env(pay(issuer, owner, asset(100)));
auto [tx1, k1] = vault.create({.owner = owner, .asset = asset});
env(tx1);
@@ -2650,7 +2650,7 @@ class Vault_test : public beast::unit_test::suite
}
{
PrettyAsset shares = issuanceId(keylet);
PrettyAsset const shares = issuanceId(keylet);
auto tx1 =
vault.deposit({.depositor = owner, .id = keylet.key, .amount = asset(100)});
env(tx1);
@@ -2761,7 +2761,7 @@ class Vault_test : public beast::unit_test::suite
{.initialIOU = Number(11875, -2)});
auto const [acctReserve, incReserve] = [this]() -> std::pair<int, int> {
Env env{*this, testable_amendments()};
Env const env{*this, testable_amendments()};
return {
env.current()->fees().accountReserve(0).drops() / DROPS_PER_XRP.drops(),
env.current()->fees().increment.drops() / DROPS_PER_XRP.drops()};
@@ -2950,22 +2950,22 @@ class Vault_test : public beast::unit_test::suite
testcase("private vault");
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account issuer{"issuer"};
Account owner{"owner"};
Account depositor{"depositor"};
Account charlie{"charlie"};
Account pdOwner{"pdOwner"};
Account credIssuer1{"credIssuer1"};
Account credIssuer2{"credIssuer2"};
Account const issuer{"issuer"};
Account const owner{"owner"};
Account const depositor{"depositor"};
Account const charlie{"charlie"};
Account const pdOwner{"pdOwner"};
Account const credIssuer1{"credIssuer1"};
Account const credIssuer2{"credIssuer2"};
std::string const credType = "credential";
Vault vault{env};
Vault const vault{env};
env.fund(XRP(1000), issuer, owner, depositor, charlie, pdOwner, credIssuer1, credIssuer2);
env.close();
env(fset(issuer, asfAllowTrustLineClawback));
env.close();
env.require(flags(issuer, asfAllowTrustLineClawback));
PrettyAsset asset = issuer["IOU"];
PrettyAsset const asset = issuer["IOU"];
env.trust(asset(1000), owner);
env(pay(issuer, owner, asset(500)));
env.trust(asset(1000), depositor);
@@ -3198,15 +3198,15 @@ class Vault_test : public beast::unit_test::suite
testcase("private XRP vault");
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account owner{"owner"};
Account depositor{"depositor"};
Account alice{"charlie"};
Account const owner{"owner"};
Account const depositor{"depositor"};
Account const alice{"charlie"};
std::string const credType = "credential";
Vault vault{env};
Vault const vault{env};
env.fund(XRP(100000), owner, depositor, alice);
env.close();
PrettyAsset asset = xrpIssue();
PrettyAsset const asset = xrpIssue();
auto [tx, keylet] = vault.create({.owner = owner, .asset = asset, .flags = tfVaultPrivate});
env(tx);
env.close();
@@ -3219,7 +3219,7 @@ class Vault_test : public beast::unit_test::suite
}();
BEAST_EXPECT(env.le(keylet::account(vaultAccount)));
BEAST_EXPECT(env.le(keylet::mptIssuance(issuanceId)));
PrettyAsset shares{issuanceId};
PrettyAsset const shares{issuanceId};
{
testcase("private XRP vault owner can deposit");
@@ -3296,7 +3296,7 @@ class Vault_test : public beast::unit_test::suite
testcase("fail pseudo-account allocation");
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account const owner{"owner"};
Vault vault{env};
Vault const vault{env};
env.fund(XRP(1000), owner);
auto const keylet = keylet::vault(owner.id(), env.seq(owner));
@@ -3362,7 +3362,7 @@ class Vault_test : public beast::unit_test::suite
auto const vault = env.le(keylet);
return {Account("vault", vault->at(sfAccount)), vault->at(sfShareMPTID)};
}(keylet);
MPTIssue shares(issuanceId);
MPTIssue const shares(issuanceId);
env.memoize(vaultAccount);
auto const peek = [keylet, &env, this](std::function<bool(SLE&, SLE&)> fn) -> bool {
@@ -4113,11 +4113,11 @@ class Vault_test : public beast::unit_test::suite
Env env{*this, testable_amendments() | featureSingleAssetVault};
Account const owner{"owner"};
Account const issuer{"issuer"};
Vault vault{env};
Vault const vault{env};
env.fund(XRP(1000), issuer, owner);
env.close();
PrettyAsset asset = issuer["IOU"];
PrettyAsset const asset = issuer["IOU"];
env.trust(asset(1000), owner);
env(pay(issuer, owner, asset(200)));
env.close();
@@ -4545,7 +4545,7 @@ class Vault_test : public beast::unit_test::suite
auto const setupVault = [&](PrettyAsset const& asset,
Account const& owner,
Account const& depositor) -> std::pair<Vault, Keylet> {
Vault vault{env};
Vault const vault{env};
auto const& [tx, vaultKeylet] = vault.create({.owner = owner, .asset = asset});
env(tx, ter(tesSUCCESS));
@@ -4554,7 +4554,7 @@ class Vault_test : public beast::unit_test::suite
auto const& vaultSle = env.le(vaultKeylet);
BEAST_EXPECT(vaultSle != nullptr);
Asset share = vaultSle->at(sfShareMPTID);
Asset const share = vaultSle->at(sfShareMPTID);
env(vault.deposit(
{.depositor = depositor, .id = vaultKeylet.key, .amount = asset(100)}),
@@ -4651,7 +4651,7 @@ class Vault_test : public beast::unit_test::suite
BEAST_EXPECT(vaultSle != nullptr);
if (!vaultSle)
return;
Asset share = vaultSle->at(sfShareMPTID);
Asset const share = vaultSle->at(sfShareMPTID);
env(vault.clawback({
.issuer = owner,
.id = vaultKeylet.key,
@@ -4687,7 +4687,7 @@ class Vault_test : public beast::unit_test::suite
BEAST_EXPECT(vaultSle != nullptr);
if (!vaultSle)
return;
Asset share = vaultSle->at(sfShareMPTID);
Asset const share = vaultSle->at(sfShareMPTID);
env(vault.clawback({
.issuer = owner,
.id = vaultKeylet.key,
@@ -4704,7 +4704,7 @@ class Vault_test : public beast::unit_test::suite
BEAST_EXPECT(vaultSle != nullptr);
if (!vaultSle)
return;
Asset share = vaultSle->at(sfShareMPTID);
Asset const share = vaultSle->at(sfShareMPTID);
env(vault.clawback({
.issuer = owner,
.id = vaultKeylet.key,
@@ -4721,7 +4721,7 @@ class Vault_test : public beast::unit_test::suite
auto const& vaultSle = env.le(vaultKeylet);
if (BEAST_EXPECT(vaultSle != nullptr))
return;
Asset share = vaultSle->at(sfShareMPTID);
Asset const share = vaultSle->at(sfShareMPTID);
env(vault.clawback({
.issuer = owner,
.id = vaultKeylet.key,
@@ -4743,18 +4743,18 @@ class Vault_test : public beast::unit_test::suite
Account owner{"alice"};
Account depositor{"bob"};
Account issuer{"issuer"};
Account const issuer{"issuer"};
env.fund(XRP(10000), issuer, owner, depositor);
env.close();
// Test XRP
PrettyAsset xrp = xrpIssue();
PrettyAsset const xrp = xrpIssue();
testCase(xrp, "XRP", owner, depositor);
testCase(xrp, "XRP (depositor is owner)", owner, owner);
// Test IOU
PrettyAsset IOU = issuer["IOU"];
PrettyAsset const IOU = issuer["IOU"];
env(fset(issuer, asfAllowTrustLineClawback));
env.close();
@@ -4769,7 +4769,7 @@ class Vault_test : public beast::unit_test::suite
// Test MPT
MPTTester mptt{env, issuer, mptInitNoFund};
mptt.create({.flags = tfMPTCanClawback | tfMPTCanTransfer | tfMPTCanLock});
PrettyAsset MPT = mptt.issuanceID();
PrettyAsset const MPT = mptt.issuanceID();
mptt.authorize({.account = owner});
mptt.authorize({.account = depositor});
env(pay(issuer, owner, MPT(1000)));
@@ -4791,7 +4791,7 @@ class Vault_test : public beast::unit_test::suite
Account const& owner,
Account const& depositor,
Account const& issuer) -> std::pair<Vault, Keylet> {
Vault vault{env};
Vault const vault{env};
auto const& [tx, vaultKeylet] = vault.create({.owner = owner, .asset = asset});
env(tx, ter(tesSUCCESS));
@@ -4840,8 +4840,8 @@ class Vault_test : public beast::unit_test::suite
"VaultClawback (asset) - " + prefix + " clawback for different asset fails");
auto [vault, vaultKeylet] = setupVault(asset, owner, depositor, issuer);
Account issuer2{"issuer2"};
PrettyAsset asset2 = issuer2["FOO"];
Account const issuer2{"issuer2"};
PrettyAsset const asset2 = issuer2["FOO"];
env(vault.clawback({
.issuer = issuer,
.id = vaultKeylet.key,
@@ -4902,7 +4902,7 @@ class Vault_test : public beast::unit_test::suite
BEAST_EXPECT(vaultSle != nullptr);
if (!vaultSle)
return;
Asset share = vaultSle->at(sfShareMPTID);
Asset const share = vaultSle->at(sfShareMPTID);
env(vault.clawback({
.issuer = issuer,
@@ -4959,17 +4959,17 @@ class Vault_test : public beast::unit_test::suite
Account owner{"alice"};
Account depositor{"bob"};
Account issuer{"issuer"};
Account const issuer{"issuer"};
env.fund(XRP(10000), issuer, owner, depositor);
env.close();
// Test XRP
PrettyAsset xrp = xrpIssue();
PrettyAsset const xrp = xrpIssue();
testCase(xrp, "XRP", owner, depositor, issuer);
// Test IOU
PrettyAsset IOU = issuer["IOU"];
PrettyAsset const IOU = issuer["IOU"];
env(fset(issuer, asfAllowTrustLineClawback));
env.close();
env.trust(IOU(1000), owner);
@@ -4982,7 +4982,7 @@ class Vault_test : public beast::unit_test::suite
// Test MPT
MPTTester mptt{env, issuer, mptInitNoFund};
mptt.create({.flags = tfMPTCanClawback | tfMPTCanTransfer | tfMPTCanLock});
PrettyAsset MPT = mptt.issuanceID();
PrettyAsset const MPT = mptt.issuanceID();
mptt.authorize({.account = owner});
mptt.authorize({.account = depositor});
env(pay(issuer, depositor, MPT(1000)));
@@ -5001,7 +5001,7 @@ class Vault_test : public beast::unit_test::suite
Account const owner{"owner"};
Account const issuer{"issuer"};
Vault vault{env};
Vault const vault{env};
env.fund(XRP(1'000'000), issuer, owner);
env.close();
@@ -5116,7 +5116,7 @@ class Vault_test : public beast::unit_test::suite
testcase("Assets Maximum: IOU");
// Almost anything goes with IOUs
PrettyAsset iouAsset = issuer["IOU"];
PrettyAsset const iouAsset = issuer["IOU"];
env.trust(iouAsset(1000), owner);
env(pay(issuer, owner, iouAsset(200)));
env.close();