ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy misc checks (#6655)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

92
src/test/app/ValidatorList_test.cpp
View File

@@ -272,7 +272,7 @@ private:
auto const masterNode1 = randomMasterKey();
auto const masterNode2 = randomMasterKey();
std::vector<std::string> cfgMasterKeys(
std::vector<std::string> const cfgMasterKeys(
{format(masterNode1), format(masterNode2, " Comment")});
BEAST_EXPECT(trustedKeys->load({}, cfgMasterKeys, emptyCfgPublishers));
BEAST_EXPECT(trustedKeys->listed(masterNode1));
@@ -362,7 +362,8 @@ private:
// load should reject validator list signing keys with invalid
// encoding
std::vector<PublicKey> keys({randomMasterKey(), randomMasterKey(), randomMasterKey()});
std::vector<PublicKey> const keys(
{randomMasterKey(), randomMasterKey(), randomMasterKey()});
badPublishers.clear();
for (auto const& key : keys)
badPublishers.push_back(toBase58(TokenType::NodePublic, key));
@@ -391,7 +392,7 @@ private:
app.config().legacy("database_path"),
env.journal);
std::vector<PublicKey> keys(
std::vector<PublicKey> const keys(
{randomMasterKey(), randomMasterKey(), randomMasterKey(), randomMasterKey()});
std::vector<std::string> cfgPublishers;
cfgPublishers.reserve(keys.size());
@@ -433,7 +434,7 @@ private:
auto legitKey1 = randomMasterKey();
auto legitKey2 = randomMasterKey();
std::vector<std::string> cfgPublishers = {
std::vector<std::string> const cfgPublishers = {
strHex(pubRevokedPublic), strHex(legitKey1), strHex(legitKey2)};
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublishers));
@@ -471,7 +472,8 @@ private:
// this one is not revoked (and not in the manifest cache at all.)
auto legitKey = randomMasterKey();
std::vector<std::string> cfgPublishers = {strHex(pubRevokedPublic), strHex(legitKey)};
std::vector<std::string> const cfgPublishers = {
strHex(pubRevokedPublic), strHex(legitKey)};
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublishers, std::size_t(2)));
BEAST_EXPECT(!trustedKeys->trustedPublisher(pubRevokedPublic));
@@ -563,8 +565,8 @@ private:
auto const manifest1 = base64_encode(makeManifestString(
publisherPublic, publisherSecret, pubSigningKeys1.first, pubSigningKeys1.second, 1));
std::vector<std::string> cfgPublisherKeys({strHex(publisherPublic)});
std::vector<std::string> emptyCfgKeys;
std::vector<std::string> const cfgPublisherKeys({strHex(publisherPublic)});
std::vector<std::string> const emptyCfgKeys;
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublisherKeys));
@@ -909,8 +911,8 @@ private:
auto const manifest = base64_encode(makeManifestString(
publisherPublic, publisherSecret, pubSigningKeys1.first, pubSigningKeys1.second, 1));
std::vector<std::string> cfgPublisherKeys({strHex(publisherPublic)});
std::vector<std::string> emptyCfgKeys;
std::vector<std::string> const cfgPublisherKeys({strHex(publisherPublic)});
std::vector<std::string> const emptyCfgKeys;
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublisherKeys));
@@ -1033,7 +1035,7 @@ private:
app.config().legacy("database_path"),
env.journal);
std::vector<std::string> cfgPublishersOuter;
std::vector<std::string> const cfgPublishersOuter;
hash_set<NodeID> activeValidatorsOuter;
std::size_t const maxKeys = 40;
@@ -1101,7 +1103,7 @@ private:
auto const masterPrivate = randomSecretKey();
auto const masterPublic = derivePublicKey(KeyType::ed25519, masterPrivate);
std::vector<std::string> cfgKeys({toBase58(TokenType::NodePublic, masterPublic)});
std::vector<std::string> const cfgKeys({toBase58(TokenType::NodePublic, masterPublic)});
BEAST_EXPECT(trustedKeysOuter->load({}, cfgKeys, cfgPublishersOuter));
@@ -1201,12 +1203,12 @@ private:
auto const publisherSecret = randomSecretKey();
auto const publisherPublic = derivePublicKey(KeyType::ed25519, publisherSecret);
std::vector<std::string> cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> emptyCfgKeys;
std::vector<std::string> const cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> const emptyCfgKeys;
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublishers));
TrustChanges changes = trustedKeys->updateTrusted(
TrustChanges const changes = trustedKeys->updateTrusted(
activeValidatorsOuter,
env.timeKeeper().now(),
env.app().getOPs(),
@@ -1227,18 +1229,18 @@ private:
env.journal);
auto const masterPrivate = randomSecretKey();
auto const masterPublic = derivePublicKey(KeyType::ed25519, masterPrivate);
std::vector<std::string> cfgKeys({toBase58(TokenType::NodePublic, masterPublic)});
std::vector<std::string> const cfgKeys({toBase58(TokenType::NodePublic, masterPublic)});
auto const publisher1Secret = randomSecretKey();
auto const publisher1Public = derivePublicKey(KeyType::ed25519, publisher1Secret);
auto const publisher2Secret = randomSecretKey();
auto const publisher2Public = derivePublicKey(KeyType::ed25519, publisher2Secret);
std::vector<std::string> cfgPublishers(
std::vector<std::string> const cfgPublishers(
{strHex(publisher1Public), strHex(publisher2Public)});
BEAST_EXPECT(trustedKeys->load({}, cfgKeys, cfgPublishers, std::size_t(2)));
TrustChanges changes = trustedKeys->updateTrusted(
TrustChanges const changes = trustedKeys->updateTrusted(
activeValidatorsOuter,
env.timeKeeper().now(),
env.app().getOPs(),
@@ -1261,7 +1263,7 @@ private:
env.journal,
minQuorum);
std::size_t n = 10;
std::size_t const n = 10;
std::vector<std::string> cfgKeys;
cfgKeys.reserve(n);
hash_set<NodeID> expectedTrusted;
@@ -1316,7 +1318,7 @@ private:
app.config().legacy("database_path"),
env.journal);
std::vector<std::string> emptyCfgKeys;
std::vector<std::string> const emptyCfgKeys;
auto const publisherKeys = randomKeyPair(KeyType::secp256k1);
auto const pubSigningKeys = randomKeyPair(KeyType::secp256k1);
auto const manifest = base64_encode(makeManifestString(
@@ -1326,7 +1328,7 @@ private:
pubSigningKeys.second,
1));
std::vector<std::string> cfgPublisherKeys({strHex(publisherKeys.first)});
std::vector<std::string> const cfgPublisherKeys({strHex(publisherKeys.first)});
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublisherKeys));
@@ -1415,7 +1417,7 @@ private:
app.config().legacy("database_path"),
env.journal);
std::vector<std::string> cfgPublishers;
std::vector<std::string> const cfgPublishers;
hash_set<NodeID> activeValidators;
hash_set<PublicKey> activeKeys;
@@ -1429,7 +1431,7 @@ private:
activeValidators.emplace(calcNodeID(valKey));
activeKeys.emplace(valKey);
BEAST_EXPECT(trustedKeys->load({}, cfgKeys, cfgPublishers));
TrustChanges changes = trustedKeys->updateTrusted(
TrustChanges const changes = trustedKeys->updateTrusted(
activeValidators,
env.timeKeeper().now(),
env.app().getOPs(),
@@ -1452,7 +1454,7 @@ private:
env.journal);
auto const localKey = randomNode();
std::vector<std::string> cfgPublishers;
std::vector<std::string> const cfgPublishers;
hash_set<NodeID> activeValidators;
hash_set<PublicKey> activeKeys;
std::vector<std::string> cfgKeys{toBase58(TokenType::NodePublic, localKey)};
@@ -1466,7 +1468,7 @@ private:
activeKeys.emplace(valKey);
BEAST_EXPECT(trustedKeys->load(localKey, cfgKeys, cfgPublishers));
TrustChanges changes = trustedKeys->updateTrusted(
TrustChanges const changes = trustedKeys->updateTrusted(
activeValidators,
env.timeKeeper().now(),
env.app().getOPs(),
@@ -1532,8 +1534,8 @@ private:
pubSigningKeys.second,
1));
std::vector<std::string> cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> emptyCfgKeys;
std::vector<std::string> const cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> const emptyCfgKeys;
// Threshold of 1 will result in a union of all the lists
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublishers, std::size_t(1)));
@@ -1542,7 +1544,7 @@ private:
auto const sequence = 1;
using namespace std::chrono_literals;
NetClock::time_point const validUntil = env.timeKeeper().now() + 3600s;
std::vector<Validator> localKeys{locals[i].first, locals[i].second};
std::vector<Validator> const localKeys{locals[i].first, locals[i].second};
auto const blob =
makeList(localKeys, sequence, validUntil.time_since_epoch().count());
auto const sig = signList(blob, pubSigningKeys);
@@ -1558,7 +1560,7 @@ private:
addPublishedList(i);
BEAST_EXPECT(trustedKeys->getListThreshold() == 1);
TrustChanges changes = trustedKeys->updateTrusted(
TrustChanges const changes = trustedKeys->updateTrusted(
activeValidators,
env.timeKeeper().now(),
env.app().getOPs(),
@@ -1624,8 +1626,8 @@ private:
pubSigningKeys.second,
1));
std::vector<std::string> cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> emptyCfgKeys;
std::vector<std::string> const cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> const emptyCfgKeys;
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublishers));
@@ -1655,7 +1657,7 @@ private:
{
validUntil2 = validUntil;
}
std::vector<Validator> localKeys{locals[i].first, locals[i].second};
std::vector<Validator> const localKeys{locals[i].first, locals[i].second};
auto const blob =
makeList(localKeys, sequence, validUntil.time_since_epoch().count());
auto const sig = signList(blob, pubSigningKeys);
@@ -1797,7 +1799,7 @@ private:
BEAST_EXPECT(trustedKeys->expires() == std::nullopt);
// Config listed keys have maximum expiry
PublicKey localCfgListed = randomNode();
PublicKey const localCfgListed = randomNode();
trustedKeys->load({}, {toStr(localCfgListed)}, {});
BEAST_EXPECT(
trustedKeys->expires() &&
@@ -1841,8 +1843,8 @@ private:
pubSigningKeys.second,
1));
std::vector<std::string> cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> emptyCfgKeys;
std::vector<std::string> const cfgPublishers({strHex(publisherPublic)});
std::vector<std::string> const emptyCfgKeys;
BEAST_EXPECT(trustedKeys->load({}, emptyCfgKeys, cfgPublishers));
@@ -1874,7 +1876,7 @@ private:
// Configure two publishers and prepare 2 lists
PreparedList prep1 = addPublishedList();
env.timeKeeper().set(env.timeKeeper().now() + 200s);
PreparedList prep2 = addPublishedList();
PreparedList const prep2 = addPublishedList();
// Initially, no list has been published, so no known expiration
BEAST_EXPECT(trustedKeys->expires() == std::nullopt);
@@ -1955,7 +1957,7 @@ private:
env.journal,
minimumQuorum);
std::vector<std::string> cfgPublishers;
std::vector<std::string> const cfgPublishers;
std::vector<std::string> cfgKeys;
hash_set<NodeID> activeValidators;
cfgKeys.reserve(vlSize);
@@ -1995,10 +1997,10 @@ private:
*/
{
hash_set<NodeID> activeValidators;
hash_set<NodeID> const activeValidators;
//== Combinations ==
std::array<std::uint32_t, 4> unlSizes = {34, 35, 39, 60};
std::array<std::uint32_t, 4> nUnlPercent = {0, 20, 30, 50};
std::array<std::uint32_t, 4> const unlSizes = {34, 35, 39, 60};
std::array<std::uint32_t, 4> const nUnlPercent = {0, 20, 30, 50};
for (auto us : unlSizes)
{
for (auto np : nUnlPercent)
@@ -2007,7 +2009,7 @@ private:
BEAST_EXPECT(validators);
if (validators)
{
std::uint32_t nUnlSize = us * np / 100;
std::uint32_t const nUnlSize = us * np / 100;
auto unl = validators->getTrustedMasterKeys();
hash_set<PublicKey> nUnl;
auto it = unl.begin();
@@ -2082,12 +2084,12 @@ private:
// 18
auto nUnl = validators->getNegativeUNL();
BEAST_EXPECT(nUnl.size() == 12);
std::size_t ss = 33;
std::size_t const ss = 33;
std::vector<uint8_t> data(ss, 0);
data[0] = 0xED;
for (int i = 0; i < 6; ++i)
{
Slice s(data.data(), ss);
Slice const s(data.data(), ss);
data[1]++;
nUnl.emplace(s);
}
@@ -2167,7 +2169,7 @@ private:
BEAST_EXPECT(global != sha512Half(signature, blobVector, version));
{
std::map<std::size_t, ValidatorBlobInfo> blobMap{{99, blobVector[0]}};
std::map<std::size_t, ValidatorBlobInfo> const blobMap{{99, blobVector[0]}};
BEAST_EXPECT(global == sha512Half(manifest, blobMap, version));
BEAST_EXPECT(global != sha512Half(blob, blobMap, version));
}
@@ -3698,7 +3700,7 @@ private:
for (auto const& p : publishers)
BEAST_EXPECT(trustedKeys->trustedPublisher(p.pubKey));
TrustChanges changes = trustedKeys->updateTrusted(
TrustChanges const changes = trustedKeys->updateTrusted(
activeValidators,
env.timeKeeper().now(),
env.app().getOPs(),
@@ -3736,7 +3738,7 @@ private:
for (auto const& p : publishers)
BEAST_EXPECT(trustedKeys->trustedPublisher(p.pubKey));
TrustChanges changes = trustedKeys->updateTrusted(
TrustChanges const changes = trustedKeys->updateTrusted(
activeValidators,
env.timeKeeper().now(),
env.app().getOPs(),