chore: Enable clang-tidy misc checks (#6655)

This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions

View File

@@ -59,7 +59,7 @@ public:
// We're only using Env for its Journal. That Journal gives better
// coverage in unit tests.
test::jtx::Env env{*this, test::jtx::envconfig(), nullptr, beast::severities::kDisabled};
beast::Journal journal{env.app().getJournal("ValidatorKeys_test")};
beast::Journal const journal{env.app().getJournal("ValidatorKeys_test")};
// Keys/ID when using [validation_seed]
SecretKey const seedSecretKey =
@@ -82,8 +82,8 @@ public:
{
// No config -> no key but valid
Config c;
ValidatorKeys k{c, journal};
Config const c;
ValidatorKeys const k{c, journal};
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
BEAST_EXPECT(!k.configInvalid());
@@ -109,7 +109,7 @@ public:
Config c;
c.section(SECTION_VALIDATION_SEED).append("badseed");
ValidatorKeys k{c, journal};
ValidatorKeys const k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
@@ -134,7 +134,7 @@ public:
// invalid validator token
Config c;
c.section(SECTION_VALIDATOR_TOKEN).append("badtoken");
ValidatorKeys k{c, journal};
ValidatorKeys const k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
@@ -145,7 +145,7 @@ public:
Config c;
c.section(SECTION_VALIDATION_SEED).append(seed);
c.section(SECTION_VALIDATOR_TOKEN).append(tokenBlob);
ValidatorKeys k{c, journal};
ValidatorKeys const k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(!k.keys);
@@ -156,7 +156,7 @@ public:
// Token manifest and private key must match
Config c;
c.section(SECTION_VALIDATOR_TOKEN).append(invalidTokenBlob);
ValidatorKeys k{c, journal};
ValidatorKeys const k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(!k.keys);