ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 16:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy misc checks (#6655)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/test/app/Ticket_test.cpp
View File

@@ -378,7 +378,7 @@ class Ticket_test : public beast::unit_test::suite
{
// Create tickets on a non-existent account.
Env env{*this};
Account alice{"alice"};
Account const alice{"alice"};
env.memoize(alice);
env(ticket::create(alice, 1), json(jss::Sequence, 1), ter(terNO_ACCOUNT));
@@ -387,11 +387,11 @@ class Ticket_test : public beast::unit_test::suite
// Exceed the threshold where tickets can no longer be
// added to an account.
Env env{*this};
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(100000), alice);
std::uint32_t ticketSeq{env.seq(alice) + 1};
std::uint32_t const ticketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 250));
checkTicketCreateMeta(env);
env.close();
@@ -424,12 +424,12 @@ class Ticket_test : public beast::unit_test::suite
{
// Explore exceeding the ticket threshold from another angle.
Env env{*this};
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(100000), alice);
env.close();
std::uint32_t ticketSeq_AB{env.seq(alice) + 1};
std::uint32_t const ticketSeq_AB{env.seq(alice) + 1};
env(ticket::create(alice, 2));
checkTicketCreateMeta(env);
env.close();
@@ -462,7 +462,7 @@ class Ticket_test : public beast::unit_test::suite
using namespace test::jtx;
Env env{*this};
Account alice{"alice"};
Account const alice{"alice"};
// Fund alice not quite enough to make the reserve for a Ticket.
env.fund(env.current()->fees().accountReserve(1) - drops(1), alice);
@@ -515,7 +515,7 @@ class Ticket_test : public beast::unit_test::suite
using namespace test::jtx;
Env env{*this};
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(10000), alice);
env.close();
@@ -611,14 +611,14 @@ class Ticket_test : public beast::unit_test::suite
using namespace test::jtx;
Env env{*this};
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(10000), alice);
env.close();
// Lambda that returns the hash of the most recent transaction.
auto getTxID = [&env, this]() -> uint256 {
std::shared_ptr<STTx const> tx{env.tx()};
std::shared_ptr<STTx const> const tx{env.tx()};
if (!BEAST_EXPECTS(tx, "Transaction not found"))
Throw<std::invalid_argument>("Invalid transaction ID");
@@ -689,7 +689,7 @@ class Ticket_test : public beast::unit_test::suite
BEAST_EXPECT(txErrCode == rpcSUCCESS);
if (auto txPtr = std::get_if<TxPair>(&maybeTx))
{
std::shared_ptr<Transaction>& tx = txPtr->first;
std::shared_ptr<Transaction> const& tx = txPtr->first;
BEAST_EXPECT(tx->getLedger() == ledgerSeq);
std::shared_ptr<STTx const> const& sttx = tx->getSTransaction();
BEAST_EXPECT((*sttx)[sfSequence] == txSeq);
@@ -726,7 +726,7 @@ class Ticket_test : public beast::unit_test::suite
using namespace test::jtx;
Env env{*this};
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(10000), alice);
env.close();
@@ -812,7 +812,7 @@ class Ticket_test : public beast::unit_test::suite
testcase("Fix both Seq and Ticket");
Env env{*this, testable_amendments()};
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(10000), alice);
env.close();