chore: Enable clang-tidy misc checks (#6655)

This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions

View File

@@ -100,7 +100,7 @@ public:
void
signal()
{
std::lock_guard lk(mutex_);
std::lock_guard const lk(mutex_);
signaled_ = true;
cv_.notify_all();
}
@@ -959,13 +959,13 @@ public:
(domainEnabled ? " w/ " : " w/o ") + "domain");
using namespace jtx;
Env env = pathTestEnv();
Account A1{"A1"};
Account A2{"A2"};
Account A3{"A3"};
Account G1{"G1"};
Account G2{"G2"};
Account G3{"G3"};
Account M1{"M1"};
Account const A1{"A1"};
Account const A2{"A2"};
Account const A3{"A3"};
Account const G1{"G1"};
Account const G2{"G2"};
Account const G3{"G3"};
Account const M1{"M1"};
env.fund(XRP(100000), A1);
env.fund(XRP(10000), A2);
@@ -1060,10 +1060,10 @@ public:
"domain");
using namespace jtx;
Env env = pathTestEnv();
Account A1{"A1"};
Account A2{"A2"};
Account G3{"G3"};
Account M1{"M1"};
Account const A1{"A1"};
Account const A2{"A2"};
Account const G3{"G3"};
Account const M1{"M1"};
env.fund(XRP(1000), A1, A2, G3);
env.fund(XRP(11000), M1);
@@ -1120,11 +1120,11 @@ public:
(domainEnabled ? " w/ " : " w/o ") + "domain");
using namespace jtx;
Env env = pathTestEnv();
Account A1{"A1"};
Account A2{"A2"};
Account G1BS{"G1BS"};
Account G2SW{"G2SW"};
Account M1{"M1"};
Account const A1{"A1"};
Account const A2{"A2"};
Account const G1BS{"G1BS"};
Account const G2SW{"G2SW"};
Account const M1{"M1"};
env.fund(XRP(1000), G1BS, G2SW, A1, A2);
env.fund(XRP(11000), M1);
@@ -1206,16 +1206,16 @@ public:
(domainEnabled ? " w/ " : " w/o ") + "domain");
using namespace jtx;
Env env = pathTestEnv();
Account A1{"A1"};
Account A2{"A2"};
Account A3{"A3"};
Account A4{"A4"};
Account G1{"G1"};
Account G2{"G2"};
Account G3{"G3"};
Account G4{"G4"};
Account M1{"M1"};
Account M2{"M2"};
Account const A1{"A1"};
Account const A2{"A2"};
Account const A3{"A3"};
Account const A4{"A4"};
Account const G1{"G1"};
Account const G2{"G2"};
Account const G3{"G3"};
Account const G4{"G4"};
Account const M1{"M1"};
Account const M2{"M2"};
env.fund(XRP(1000), A1, A2, A3, G1, G2, G3, G4);
env.fund(XRP(10000), A4);
@@ -1349,12 +1349,12 @@ public:
(domainEnabled ? " w/ " : " w/o ") + "domain");
using namespace jtx;
Env env = pathTestEnv();
Account A1{"A1"};
Account A2{"A2"};
Account A3{"A3"};
Account G1{"G1"};
Account G2{"G2"};
Account M1{"M1"};
Account const A1{"A1"};
Account const A2{"A2"};
Account const A3{"A3"};
Account const G1{"G1"};
Account const G2{"G2"};
Account const M1{"M1"};
env.fund(XRP(11000), M1);
env.fund(XRP(1000), A1, A2, A3, G1, G2);
@@ -1539,16 +1539,16 @@ public:
// lambda param that creates different types of offers
auto testPathfind = [&](auto func, bool const domainEnabled = false) {
Env env = pathTestEnv();
Account A1{"A1"};
Account A2{"A2"};
Account A3{"A3"};
Account A4{"A4"};
Account G1{"G1"};
Account G2{"G2"};
Account G3{"G3"};
Account G4{"G4"};
Account M1{"M1"};
Account M2{"M2"};
Account const A1{"A1"};
Account const A2{"A2"};
Account const A3{"A3"};
Account const A4{"A4"};
Account const G1{"G1"};
Account const G2{"G2"};
Account const G3{"G3"};
Account const G4{"G4"};
Account const M1{"M1"};
Account const M2{"M2"};
env.fund(XRP(1000), A1, A2, A3, G1, G2, G3, G4);
env.fund(XRP(10000), A4);
@@ -1815,9 +1815,9 @@ public:
testcase("AMM not used in domain path");
using namespace jtx;
Env env = pathTestEnv();
PermissionedDEX permDex(env);
PermissionedDEX const permDex(env);
auto const& [gw, domainOwner, alice, bob, carol, USD, domainID, credType] = permDex;
AMM amm(env, alice, XRP(10), USD(50));
AMM const amm(env, alice, XRP(10), USD(50));
STPathSet st;
STAmount sa, da;