chore: Enable clang-tidy misc checks (#6655)

This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions

View File

@@ -46,7 +46,7 @@ class NFTokenDir_test : public beast::unit_test::suite
if (state[i].isMember(sfNFTokens.jsonName) &&
state[i][sfNFTokens.jsonName].isArray())
{
std::uint32_t tokenCount = state[i][sfNFTokens.jsonName].size();
std::uint32_t const tokenCount = state[i][sfNFTokens.jsonName].size();
std::cout << tokenCount << " NFtokens in page "
<< state[i][jss::index].asString() << std::endl;
@@ -104,7 +104,7 @@ class NFTokenDir_test : public beast::unit_test::suite
nftIDs.reserve(nftCount);
for (int i = 0; i < nftCount; ++i)
{
std::uint32_t taxon = toUInt32(nft::cipheredTaxon(i, nft::toTaxon(0)));
std::uint32_t const taxon = toUInt32(nft::cipheredTaxon(i, nft::toTaxon(0)));
nftIDs.emplace_back(token::getNextID(env, issuer, taxon, tfTransferable));
env(token::mint(issuer, taxon), txflags(tfTransferable));
env.close();
@@ -160,7 +160,7 @@ class NFTokenDir_test : public beast::unit_test::suite
// Create accounts for all of the seeds and fund those accounts.
std::vector<Account> accounts;
accounts.reserve(seeds.size());
for (std::string_view seed : seeds)
for (std::string_view const seed : seeds)
{
Account const& account =
accounts.emplace_back(Account::base58Seed, std::string(seed));
@@ -364,7 +364,7 @@ class NFTokenDir_test : public beast::unit_test::suite
// Create accounts for all of the seeds and fund those accounts.
std::vector<Account> accounts;
accounts.reserve(seeds.size());
for (std::string_view seed : seeds)
for (std::string_view const seed : seeds)
{
Account const& account =
accounts.emplace_back(Account::base58Seed, std::string(seed));
@@ -595,7 +595,7 @@ class NFTokenDir_test : public beast::unit_test::suite
// Create accounts for all of the seeds and fund those accounts.
std::vector<Account> accounts;
accounts.reserve(seeds.size());
for (std::string_view seed : seeds)
for (std::string_view const seed : seeds)
{
Account const& account = accounts.emplace_back(Account::base58Seed, std::string(seed));
env.fund(XRP(10000), account);
@@ -758,7 +758,7 @@ class NFTokenDir_test : public beast::unit_test::suite
// Create accounts for all of the seeds and fund those accounts.
std::vector<Account> accounts;
accounts.reserve(seeds.size());
for (std::string_view seed : seeds)
for (std::string_view const seed : seeds)
{
Account const& account = accounts.emplace_back(Account::base58Seed, std::string(seed));
env.fund(XRP(10000), account);
@@ -783,7 +783,7 @@ class NFTokenDir_test : public beast::unit_test::suite
for (Account const& account : accounts)
{
// Mint the NFT. Tweak the taxon so zero is always stored.
std::uint32_t taxon = toUInt32(nft::cipheredTaxon(i, nft::toTaxon(0)));
std::uint32_t const taxon = toUInt32(nft::cipheredTaxon(i, nft::toTaxon(0)));
uint256 const& nftID = nftIDsByPage[i].emplace_back(
token::getNextID(env, account, taxon, tfTransferable));
@@ -831,7 +831,7 @@ class NFTokenDir_test : public beast::unit_test::suite
// buyer accepts all of the offers that won't cause an overflow.
// Fill the center and outsides first to exercise different boundary
// cases.
for (int i : std::initializer_list<int>{3, 6, 0, 1, 2, 5, 4})
for (int const i : std::initializer_list<int>{3, 6, 0, 1, 2, 5, 4})
{
for (uint256 const& offer : offers[i])
{