chore: Enable clang-tidy misc checks (#6655)

2026-06-03 16:56:48 +00:00 · 2026-03-31 18:29:45 +01:00
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions
--- a/src/test/app/Invariants_test.cpp
+++ b/src/test/app/Invariants_test.cpp
@@ -127,7 +127,7 @@ class Invariants_test : public beast::unit_test::suite

        OpenView ov{*env.current()};
        test::StreamSink sink{beast::severities::kWarning};
-        beast::Journal jlog{sink};
+        beast::Journal const jlog{sink};
        ApplyContext ac{env.app(), ov, tx, tesSUCCESS, env.current()->fees().base, tapNONE, jlog};

        BEAST_EXPECT(precheck(A1, A2, ac));
@@ -845,7 +845,7 @@ class Invariants_test : public beast::unit_test::suite
                auto sleNew = std::make_shared<SLE>(keylet::escrow(A1, (*sle)[sfSequence] + 2));

                Issue const usd{Currency(0x5553440000000000), AccountID(0x4985601)};
-                STAmount amt(usd, -1);
+                STAmount const amt(usd, -1);
                sleNew->setFieldAmount(sfAmount, amt);
                ac.view().insert(sleNew);
                return true;
@@ -862,7 +862,7 @@ class Invariants_test : public beast::unit_test::suite
                auto sleNew = std::make_shared<SLE>(keylet::escrow(A1, (*sle)[sfSequence] + 2));

                Issue const bad{badCurrency(), AccountID(0x4985601)};
-                STAmount amt(bad, 1);
+                STAmount const amt(bad, 1);
                sleNew->setFieldAmount(sfAmount, amt);
                ac.view().insert(sleNew);
                return true;
@@ -879,7 +879,7 @@ class Invariants_test : public beast::unit_test::suite
                auto sleNew = std::make_shared<SLE>(keylet::escrow(A1, (*sle)[sfSequence] + 2));

                MPTIssue const mpt{MPTIssue{makeMptID(1, AccountID(0x4985601))}};
-                STAmount amt(mpt, -1);
+                STAmount const amt(mpt, -1);
                sleNew->setFieldAmount(sfAmount, amt);
                ac.view().insert(sleNew);
                return true;
@@ -1026,8 +1026,7 @@ class Invariants_test : public beast::unit_test::suite
                auto const sleNew = std::make_shared<SLE>(acctKeylet);
                sleNew->setFieldU32(sfSequence, 0);
                sleNew->setFieldH256(sfAMMID, uint256(1));
-                sleNew->setFieldU32(
-                    sfFlags, lsfDisableMaster | lsfDefaultRipple | lsfDefaultRipple);
+                sleNew->setFieldU32(sfFlags, lsfDisableMaster | lsfDefaultRipple);
                ac.view().insert(sleNew);
                return true;
            },
@@ -1253,8 +1252,8 @@ class Invariants_test : public beast::unit_test::suite
        using namespace test::jtx;

        bool const fixPDEnabled = features[fixPermissionedDomainInvariant];
-        std::initializer_list<TER> badTers = {tecINVARIANT_FAILED, tecINVARIANT_FAILED};
-        std::initializer_list<TER> failTers = {tecINVARIANT_FAILED, tefINVARIANT_FAILED};
+        std::initializer_list<TER> const badTers = {tecINVARIANT_FAILED, tecINVARIANT_FAILED};
+        std::initializer_list<TER> const failTers = {tecINVARIANT_FAILED, tefINVARIANT_FAILED};

        testcase << "PermissionedDomain" + std::string(fixPDEnabled ? " fix" : "");

@@ -1338,7 +1337,7 @@ class Invariants_test : public beast::unit_test::suite

                // update PD with empty rules
                {
-                    STArray credentials(sfAcceptedCredentials, 2);
+                    STArray const credentials(sfAcceptedCredentials, 2);
                    slePd->setFieldArray(sfAcceptedCredentials, credentials);
                    ac.view().update(slePd);
                }
@@ -1438,15 +1437,16 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttPERMISSIONED_DOMAIN_SET, [](STObject&) {}},
            fixPDEnabled ? failTers : badTers);

-        std::initializer_list<TER> goodTers = {tesSUCCESS, tesSUCCESS};
+        std::initializer_list<TER> const goodTers = {tesSUCCESS, tesSUCCESS};

-        std::vector<std::string> badMoreThan1{
+        std::vector<std::string> const badMoreThan1{
            {"transaction affected more than 1 permissioned domain entry."}};
-        std::vector<std::string> emptyV;
-        std::vector<std::string> badNoDomains{{"no domain objects affected by"}};
-        std::vector<std::string> badNotDeleted{{"domain object modified, but not deleted by "}};
-        std::vector<std::string> badDeleted{{"domain object deleted by"}};
-        std::vector<std::string> badTx{
+        std::vector<std::string> const emptyV;
+        std::vector<std::string> const badNoDomains{{"no domain objects affected by"}};
+        std::vector<std::string> const badNotDeleted{
+            {"domain object modified, but not deleted by "}};
+        std::vector<std::string> const badDeleted{{"domain object deleted by"}};
+        std::vector<std::string> const badTx{
            {"domain object(s) affected by an unauthorized transaction."}};

        {
@@ -1596,11 +1596,11 @@ class Invariants_test : public beast::unit_test::suite
        using namespace jtx;

        AccountID pseudoAccountID;
-        Preclose createPseudo = [&, this](Account const& a, Account const& b, Env& env) {
+        Preclose const createPseudo = [&, this](Account const& a, Account const& b, Env& env) {
            PrettyAsset const xrpAsset{xrpIssue(), 1'000'000};

            // Create vault
-            Vault vault{env};
+            Vault const vault{env};
            auto [tx, vKeylet] = vault.create({.owner = a, .asset = xrpAsset});
            env(tx);
            env.close();
@@ -1724,7 +1724,7 @@ class Invariants_test : public beast::unit_test::suite

        std::uint32_t const seq = env.seq(A1);
        env(pdomain::setTx(A1, credentials));
-        uint256 key = pdomain::getNewDomain(env.meta());
+        uint256 const key = pdomain::getNewDomain(env.meta());

        // std::cout << "PD, acc: " << A1.id() << ", seq: " << seq << ", k: " <<
        // key << std::endl;
@@ -1942,7 +1942,7 @@ class Invariants_test : public beast::unit_test::suite

        // Create vault
        uint256 vaultID;
-        Vault vault{env};
+        Vault const vault{env};
        auto [tx, vKeylet] = vault.create({.owner = a, .asset = asset});
        env(tx);
        BEAST_EXPECT(env.le(vKeylet));
@@ -1967,7 +1967,7 @@ class Invariants_test : public beast::unit_test::suite

        // Initialize with a placeholder value because there's no default ctor
        Keylet loanBrokerKeylet = keylet::amendments();
-        Preclose createLoanBroker = [&, this](Account const& a, Account const& b, Env& env) {
+        Preclose const createLoanBroker = [&, this](Account const& a, Account const& b, Env& env) {
            PrettyAsset const xrpAsset{xrpIssue(), 1'000'000};

            loanBrokerKeylet = this->createLoanBroker(a, env, xrpAsset);
@@ -2047,38 +2047,38 @@ class Invariants_test : public beast::unit_test::suite
            // Initialize with a placeholder value because there's no default
            // ctor
            Keylet loanBrokerKeylet = keylet::amendments();
-            Preclose createLoanBroker = [&, this](
-                                            Account const& alice, Account const& issuer, Env& env) {
-                PrettyAsset const asset = [&]() {
-                    switch (assetType)
-                    {
-                        case Asset::IOU: {
-                            PrettyAsset const iouAsset = issuer["IOU"];
-                            env(trust(alice, iouAsset(1000)));
-                            env(pay(issuer, alice, iouAsset(1000)));
-                            env.close();
-                            return iouAsset;
-                        }
+            Preclose const createLoanBroker =
+                [&, this](Account const& alice, Account const& issuer, Env& env) {
+                    PrettyAsset const asset = [&]() {
+                        switch (assetType)
+                        {
+                            case Asset::IOU: {
+                                PrettyAsset const iouAsset = issuer["IOU"];
+                                env(trust(alice, iouAsset(1000)));
+                                env(pay(issuer, alice, iouAsset(1000)));
+                                env.close();
+                                return iouAsset;
+                            }

-                        case Asset::MPT: {
-                            MPTTester mptt{env, issuer, mptInitNoFund};
-                            mptt.create(
-                                {.flags = tfMPTCanClawback | tfMPTCanTransfer | tfMPTCanLock});
-                            PrettyAsset const mptAsset = mptt.issuanceID();
-                            mptt.authorize({.account = alice});
-                            env(pay(issuer, alice, mptAsset(1000)));
-                            env.close();
-                            return mptAsset;
-                        }
+                            case Asset::MPT: {
+                                MPTTester mptt{env, issuer, mptInitNoFund};
+                                mptt.create(
+                                    {.flags = tfMPTCanClawback | tfMPTCanTransfer | tfMPTCanLock});
+                                PrettyAsset const mptAsset = mptt.issuanceID();
+                                mptt.authorize({.account = alice});
+                                env(pay(issuer, alice, mptAsset(1000)));
+                                env.close();
+                                return mptAsset;
+                            }

-                        case Asset::XRP:
-                        default:
-                            return PrettyAsset{xrpIssue(), 1'000'000};
-                    }
-                }();
-                loanBrokerKeylet = this->createLoanBroker(alice, env, asset);
-                return BEAST_EXPECT(env.le(loanBrokerKeylet));
-            };
+                            case Asset::XRP:
+                            default:
+                                return PrettyAsset{xrpIssue(), 1'000'000};
+                        }
+                    }();
+                    loanBrokerKeylet = this->createLoanBroker(alice, env, asset);
+                    return BEAST_EXPECT(env.le(loanBrokerKeylet));
+                };

            // Ensure the test scenarios are set up completely. The test cases
            // will need to recompute any of these values it needs for itself
@@ -2393,7 +2393,7 @@ class Invariants_test : public beast::unit_test::suite
        Account A4{"A4"};
        auto const precloseXrp = [&](Account const& A1, Account const& A2, Env& env) -> bool {
            env.fund(XRP(1000), A3, A4);
-            Vault vault{env};
+            Vault const vault{env};
            auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
            env(tx);
            env(vault.deposit({.depositor = A1, .id = keylet.key, .amount = XRP(10)}));
@@ -2417,7 +2417,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_DELETE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2437,7 +2437,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttPAYMENT, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2457,7 +2457,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttPAYMENT, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2493,7 +2493,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_SET, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2522,7 +2522,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_DELETE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                {
                    auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                    env(tx);
@@ -2568,7 +2568,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_DELETE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2594,7 +2594,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_DELETE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tefINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                env(vault.deposit({.depositor = A1, .id = keylet.key, .amount = XRP(10)}));
@@ -2630,7 +2630,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CREATE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2643,7 +2643,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_DEPOSIT, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2656,7 +2656,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_WITHDRAW, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2669,7 +2669,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CLAWBACK, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2682,7 +2682,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_DELETE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2708,7 +2708,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_SET, [](STObject&) {}},
            {tecINVARIANT_FAILED, tefINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, _] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2730,7 +2730,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_WITHDRAW, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                env(vault.deposit({.depositor = A1, .id = keylet.key, .amount = XRP(10)}));
@@ -2970,7 +2970,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CREATE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -2996,7 +2996,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CREATE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -3023,7 +3023,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CREATE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -3051,7 +3051,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CREATE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -3075,7 +3075,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CREATE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -3103,7 +3103,7 @@ class Invariants_test : public beast::unit_test::suite
            STTx{ttVAULT_CREATE, [](STObject&) {}},
            {tecINVARIANT_FAILED, tecINVARIANT_FAILED},
            [&](Account const& A1, Account const& A2, Env& env) {
-                Vault vault{env};
+                Vault const vault{env};
                auto [tx, keylet] = vault.create({.owner = A1, .asset = xrpIssue()});
                env(tx);
                return true;
@@ -3658,7 +3658,7 @@ class Invariants_test : public beast::unit_test::suite
            }

            auto const mptID = makeMptID(env.seq(A3) - 1, A3);
-            Asset asset = MPTIssue(mptID);
+            Asset const asset = MPTIssue(mptID);
            // Authorize A1 A2 A4
            {
                Json::Value jv;
@@ -3681,7 +3681,7 @@ class Invariants_test : public beast::unit_test::suite
                env.close();
            }

-            Vault vault{env};
+            Vault const vault{env};
            auto [tx, keylet] = vault.create({.owner = A1, .asset = asset});
            env(tx);
            env(vault.deposit({.depositor = A1, .id = keylet.key, .amount = asset(10)}));