chore: Enable clang-tidy misc checks (#6655)

This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions

View File

@@ -52,7 +52,7 @@ class Clawback_test : public beast::unit_test::suite
// Also, asfAllowTrustLineClawback cannot be cleared.
{
Env env(*this, features);
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(1000), alice);
env.close();
@@ -77,7 +77,7 @@ class Clawback_test : public beast::unit_test::suite
// asfNoFreeze has been set
{
Env env(*this, features);
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(1000), alice);
env.close();
@@ -103,8 +103,8 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -146,7 +146,7 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features - featureClawback);
Account alice{"alice"};
Account const alice{"alice"};
env.fund(XRP(1000), alice);
env.close();
@@ -183,8 +183,8 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features - featureClawback);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -228,8 +228,8 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -310,8 +310,8 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
// bob's account is not funded and does not exist
env.fund(XRP(1000), alice);
@@ -332,9 +332,9 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account cindy{"cindy"};
Account const alice{"alice"};
Account const bob{"bob"};
Account const cindy{"cindy"};
env.fund(XRP(1000), alice, bob, cindy);
env.close();
@@ -375,8 +375,8 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -445,8 +445,8 @@ class Clawback_test : public beast::unit_test::suite
// Test that alice is able to successfully clawback tokens from bob
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -496,9 +496,9 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account cindy{"cindy"};
Account const alice{"alice"};
Account const bob{"bob"};
Account const cindy{"cindy"};
env.fund(XRP(1000), alice, bob, cindy);
env.close();
@@ -554,9 +554,9 @@ class Clawback_test : public beast::unit_test::suite
{
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account cindy{"cindy"};
Account const alice{"alice"};
Account const bob{"bob"};
Account const cindy{"cindy"};
env.fund(XRP(1000), alice, bob, cindy);
env.close();
@@ -624,8 +624,8 @@ class Clawback_test : public beast::unit_test::suite
// perspective is allowed to clawback
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -711,8 +711,8 @@ class Clawback_test : public beast::unit_test::suite
// If clawback results the trustline to be default,
// trustline should be automatically deleted
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -761,8 +761,8 @@ class Clawback_test : public beast::unit_test::suite
// Claws back from frozen trustline
// and the trustline should remain frozen
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -807,8 +807,8 @@ class Clawback_test : public beast::unit_test::suite
// When alice tries to claw back an amount that is greater
// than what bob holds, only the max available balance is clawed
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();
@@ -859,8 +859,8 @@ class Clawback_test : public beast::unit_test::suite
// Tests clawback with tickets
Env env(*this, features);
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(1000), alice, bob);
env.close();