ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 01:06:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy misc checks (#6655)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

168
src/test/app/Batch_test.cpp
View File

@@ -960,7 +960,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -969,7 +969,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
@@ -1002,7 +1002,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -1011,7 +1011,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
@@ -1044,7 +1044,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -1053,7 +1053,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
@@ -1086,7 +1086,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -1095,7 +1095,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
@@ -1128,7 +1128,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -1137,7 +1137,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
@@ -1463,7 +1463,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -1495,7 +1495,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(9999)), seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -1524,7 +1524,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(trust(alice, USD(1000), tfSetfAuth), seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -1553,7 +1553,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(trust(alice, USD(1000), tfSetfAuth), 0, seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -1605,7 +1605,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(9999)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tecUNFUNDED_PAYMENT", txIDs[0], batchID},
{2, "Payment", "tecUNFUNDED_PAYMENT", txIDs[1], batchID},
@@ -1638,7 +1638,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tecUNFUNDED_PAYMENT", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -1670,7 +1670,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
};
@@ -1701,7 +1701,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[1], batchID},
};
@@ -1732,7 +1732,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[1], batchID},
};
@@ -1769,7 +1769,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, dave, XRP(100)), seq + 6));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "OfferCreate", "tecKILLED", txIDs[0], batchID},
{2, "OfferCreate", "tecKILLED", txIDs[1], batchID},
@@ -1821,7 +1821,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tecUNFUNDED_PAYMENT", txIDs[0], batchID},
};
@@ -1852,7 +1852,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(4)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -1887,7 +1887,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -1921,7 +1921,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -1954,7 +1954,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -1987,7 +1987,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, dave, XRP(100)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -2038,7 +2038,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tecUNFUNDED_PAYMENT", txIDs[1], batchID},
@@ -2073,7 +2073,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 4));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -2108,7 +2108,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -2142,7 +2142,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(3)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -2175,7 +2175,7 @@ class Batch_test : public beast::unit_test::suite
offer(alice, alice["USD"](100), XRP(100), tfImmediateOrCancel), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -2339,7 +2339,7 @@ class Batch_test : public beast::unit_test::suite
// - has no `Signers` field
// + has `tfInnerBatchTxn` flag
{
STTx amendTx(ttAMENDMENT, [seq = env.closed()->header().seq + 1](auto& obj) {
STTx const amendTx(ttAMENDMENT, [seq = env.closed()->header().seq + 1](auto& obj) {
obj.setAccountID(sfAccount, AccountID());
obj.setFieldH256(sfAmendment, fixBatchInnerSigs);
obj.setFieldU32(sfLedgerSequence, seq);
@@ -2397,7 +2397,7 @@ class Batch_test : public beast::unit_test::suite
batch::sig(bob));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "AccountSet", "tesSUCCESS", txIDs[1], batchID},
@@ -2446,7 +2446,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(1)), seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "AccountSet", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -2501,7 +2501,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "AccountDelete", "tesSUCCESS", txIDs[1], batchID},
@@ -2544,7 +2544,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "AccountDelete", "tecHAS_OBLIGATIONS", txIDs[1], batchID},
@@ -2585,7 +2585,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 3));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -2626,7 +2626,7 @@ class Batch_test : public beast::unit_test::suite
// Just use an XRP asset
PrettyAsset const asset{xrpIssue(), 1'000'000};
Vault vault{env};
Vault const vault{env};
auto const deposit = asset(50'000);
auto const debtMaximumValue = asset(25'000).value();
@@ -2821,7 +2821,7 @@ class Batch_test : public beast::unit_test::suite
batch::sig(bob));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "CheckCreate", "tesSUCCESS", txIDs[0], batchID},
{2, "CheckCash", "tesSUCCESS", txIDs[1], batchID},
@@ -2867,7 +2867,7 @@ class Batch_test : public beast::unit_test::suite
batch::sig(bob));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "CheckCreate", "tecDST_TAG_NEEDED", txIDs[0], batchID},
{2, "CheckCash", "tecNO_ENTRY", txIDs[1], batchID},
@@ -2932,7 +2932,7 @@ class Batch_test : public beast::unit_test::suite
batch::sig(bob));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "TicketCreate", "tesSUCCESS", txIDs[0], batchID},
{2, "CheckCreate", "tesSUCCESS", txIDs[1], batchID},
@@ -2992,7 +2992,7 @@ class Batch_test : public beast::unit_test::suite
batch::sig(alice, bob));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "CheckCreate", "tesSUCCESS", txIDs[0], batchID},
{2, "CheckCash", "tesSUCCESS", txIDs[1], batchID},
@@ -3026,7 +3026,7 @@ class Batch_test : public beast::unit_test::suite
env.fund(XRP(10000), alice, bob);
env.close();
std::uint32_t aliceTicketSeq{env.seq(alice) + 1};
std::uint32_t const aliceTicketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 10));
env.close();
@@ -3044,7 +3044,7 @@ class Batch_test : public beast::unit_test::suite
ticket::use(aliceTicketSeq));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3092,7 +3092,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), 0, aliceTicketSeq + 1));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3123,7 +3123,7 @@ class Batch_test : public beast::unit_test::suite
env.fund(XRP(10000), alice, bob);
env.close();
std::uint32_t aliceTicketSeq{env.seq(alice) + 1};
std::uint32_t const aliceTicketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 10));
env.close();
@@ -3141,7 +3141,7 @@ class Batch_test : public beast::unit_test::suite
ticket::use(aliceTicketSeq));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3202,7 +3202,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3213,7 +3213,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger contains noop txn
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "AccountSet", "tesSUCCESS", noopTxnID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -3246,7 +3246,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3257,7 +3257,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
}
@@ -3285,7 +3285,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3296,7 +3296,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
}
@@ -3327,7 +3327,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "AccountSet", "tesSUCCESS", noopTxnID, std::nullopt},
{1, "Batch", "tesSUCCESS", batchID, std::nullopt},
{2, "Payment", "tesSUCCESS", txIDs[0], batchID},
@@ -3339,7 +3339,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger contains no transactions
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
}
@@ -3365,7 +3365,7 @@ class Batch_test : public beast::unit_test::suite
env.fund(XRP(10000), alice, bob);
env.close();
std::uint32_t aliceTicketSeq{env.seq(alice) + 1};
std::uint32_t const aliceTicketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 10));
env.close();
@@ -3387,7 +3387,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3398,7 +3398,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
}
@@ -3412,7 +3412,7 @@ class Batch_test : public beast::unit_test::suite
env.fund(XRP(10000), alice, bob);
env.close();
std::uint32_t aliceTicketSeq{env.seq(alice) + 1};
std::uint32_t const aliceTicketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 10));
env.close();
@@ -3434,7 +3434,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3445,7 +3445,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
}
@@ -3473,7 +3473,7 @@ class Batch_test : public beast::unit_test::suite
env.fund(XRP(10000), alice, bob);
env.close();
std::uint32_t aliceTicketSeq{env.seq(alice) + 1};
std::uint32_t const aliceTicketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 10));
env.close();
@@ -3497,7 +3497,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "CheckCreate", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3509,7 +3509,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger is empty
std::vector<TestLedgerData> testCases = {};
std::vector<TestLedgerData> const testCases = {};
validateClosedLedger(env, testCases);
}
}
@@ -3520,7 +3520,7 @@ class Batch_test : public beast::unit_test::suite
env.fund(XRP(10000), alice, bob);
env.close();
std::uint32_t aliceTicketSeq{env.seq(alice) + 1};
std::uint32_t const aliceTicketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 10));
env.close();
@@ -3546,7 +3546,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "CheckCreate", "tesSUCCESS", objTxnID, std::nullopt},
{1, "Batch", "tesSUCCESS", batchID, std::nullopt},
{2, "CheckCash", "tesSUCCESS", txIDs[0], batchID},
@@ -3567,7 +3567,7 @@ class Batch_test : public beast::unit_test::suite
env.fund(XRP(10000), alice, bob);
env.close();
std::uint32_t aliceTicketSeq{env.seq(alice) + 1};
std::uint32_t const aliceTicketSeq{env.seq(alice) + 1};
env(ticket::create(alice, 10));
env.close();
@@ -3591,7 +3591,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "CheckCreate", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3687,7 +3687,7 @@ class Batch_test : public beast::unit_test::suite
env(payTxn2, ter(terPRE_SEQ));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Payment", "tesSUCCESS", payTxn1ID, std::nullopt},
{1, "Batch", "tesSUCCESS", batchID, std::nullopt},
{2, "Payment", "tesSUCCESS", txIDs[0], batchID},
@@ -3698,7 +3698,7 @@ class Batch_test : public beast::unit_test::suite
env.close();
{
// next ledger includes the payment txn
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Payment", "tesSUCCESS", payTxn2ID, std::nullopt},
};
validateClosedLedger(env, testCases);
@@ -3910,7 +3910,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -3959,7 +3959,7 @@ class Batch_test : public beast::unit_test::suite
batch::sig(bob));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "Payment", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -4009,7 +4009,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(pay(alice, bob, XRP(2)), seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "AccountSet", "tesSUCCESS", txIDs[0], batchID},
{2, "Payment", "tesSUCCESS", txIDs[1], batchID},
@@ -4029,8 +4029,8 @@ class Batch_test : public beast::unit_test::suite
// MPTokenIssuanceSet with granular permission
{
test::jtx::Env env{*this, features};
Account alice{"alice"};
Account bob{"bob"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(100000), alice, bob);
env.close();
@@ -4071,7 +4071,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(jv2, seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "MPTokenIssuanceSet", "tesSUCCESS", txIDs[0], batchID},
{2, "MPTokenIssuanceSet", "tesSUCCESS", txIDs[1], batchID},
@@ -4084,9 +4084,9 @@ class Batch_test : public beast::unit_test::suite
// with granular permission
{
test::jtx::Env env{*this, features};
Account gw{"gw"};
Account alice{"alice"};
Account bob{"bob"};
Account const gw{"gw"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(10000), gw, alice, bob);
env(fset(gw, asfRequireAuth));
env.close();
@@ -4112,7 +4112,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(jv2, seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "TrustSet", "tesSUCCESS", txIDs[0], batchID},
{2, "TrustSet", "tesSUCCESS", txIDs[1], batchID},
@@ -4123,9 +4123,9 @@ class Batch_test : public beast::unit_test::suite
// inner transaction not authorized by the delegating account.
{
test::jtx::Env env{*this, features};
Account gw{"gw"};
Account alice{"alice"};
Account bob{"bob"};
Account const gw{"gw"};
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(10000), gw, alice, bob);
env(fset(gw, asfRequireAuth));
env.close();
@@ -4152,7 +4152,7 @@ class Batch_test : public beast::unit_test::suite
batch::inner(jv2, seq + 2));
env.close();
std::vector<TestLedgerData> testCases = {
std::vector<TestLedgerData> const testCases = {
{0, "Batch", "tesSUCCESS", batchID, std::nullopt},
{1, "TrustSet", "tesSUCCESS", txIDs[0], batchID},
};