ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-24 15:40:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy misc checks (#6655)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-31 18:29:45 +01:00
committed by GitHub
parent c3fae847f3
commit 2502befb42
469 changed files with 3915 additions and 3965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/libxrpl/protocol/Serializer.cpp
View File

@@ -23,7 +23,7 @@ namespace xrpl {
int
Serializer::add16(std::uint16_t i)
{
int ret = mData.size();
int const ret = mData.size();
mData.push_back(static_cast<unsigned char>(i >> 8));
mData.push_back(static_cast<unsigned char>(i & 0xff));
return ret;
@@ -73,7 +73,7 @@ Serializer::addInteger(std::int32_t i)
int
Serializer::addRaw(Blob const& vector)
{
int ret = mData.size();
int const ret = mData.size();
mData.insert(mData.end(), vector.begin(), vector.end());
return ret;
}
@@ -81,7 +81,7 @@ Serializer::addRaw(Blob const& vector)
int
Serializer::addRaw(Slice slice)
{
int ret = mData.size();
int const ret = mData.size();
mData.insert(mData.end(), slice.begin(), slice.end());
return ret;
}
@@ -89,7 +89,7 @@ Serializer::addRaw(Slice slice)
int
Serializer::addRaw(Serializer const& s)
{
int ret = mData.size();
int const ret = mData.size();
mData.insert(mData.end(), s.begin(), s.end());
return ret;
}
@@ -97,7 +97,7 @@ Serializer::addRaw(Serializer const& s)
int
Serializer::addRaw(void const* ptr, int len)
{
int ret = mData.size();
int const ret = mData.size();
mData.insert(mData.end(), (char const*)ptr, ((char const*)ptr) + len);
return ret;
}
@@ -105,7 +105,7 @@ Serializer::addRaw(void const* ptr, int len)
int
Serializer::addFieldID(int type, int name)
{
int ret = mData.size();
int const ret = mData.size();
XRPL_ASSERT(
(type > 0) && (type < 256) && (name > 0) && (name < 256),
"xrpl::Serializer::addFieldID : inputs inside range");
@@ -143,7 +143,7 @@ Serializer::addFieldID(int type, int name)
int
Serializer::add8(unsigned char byte)
{
int ret = mData.size();
int const ret = mData.size();
mData.push_back(byte);
return ret;
}
@@ -177,7 +177,7 @@ Serializer::getSHA512Half() const
int
Serializer::addVL(Blob const& vector)
{
int ret = addEncoded(vector.size());
int const ret = addEncoded(vector.size());
addRaw(vector);
XRPL_ASSERT(
mData.size() == (ret + vector.size() + encodeLengthLength(vector.size())),
@@ -188,7 +188,7 @@ Serializer::addVL(Blob const& vector)
int
Serializer::addVL(Slice const& slice)
{
int ret = addEncoded(slice.size());
int const ret = addEncoded(slice.size());
if (!slice.empty())
addRaw(slice.data(), slice.size());
return ret;
@@ -197,7 +197,7 @@ Serializer::addVL(Slice const& slice)
int
Serializer::addVL(void const* ptr, int len)
{
int ret = addEncoded(len);
int const ret = addEncoded(len);
if (len != 0)
addRaw(ptr, len);
@@ -343,7 +343,7 @@ SerialIter::get8()
{
if (remain_ < 1)
Throw<std::runtime_error>("invalid SerialIter get8");
unsigned char t = *p_;
unsigned char const t = *p_;
++p_;
++used_;
--remain_;
@@ -469,23 +469,23 @@ SerialIter::getRaw(int size)
int
SerialIter::getVLDataLength()
{
int b1 = get8();
int const b1 = get8();
int datLen = 0;
int lenLen = Serializer::decodeLengthLength(b1);
int const lenLen = Serializer::decodeLengthLength(b1);
if (lenLen == 1)
{
datLen = Serializer::decodeVLLength(b1);
}
else if (lenLen == 2)
{
int b2 = get8();
int const b2 = get8();
datLen = Serializer::decodeVLLength(b1, b2);
}
else
{
XRPL_ASSERT(lenLen == 3, "xrpl::SerialIter::getVLDataLength : lenLen is 3");
int b2 = get8();
int b3 = get8();
int const b2 = get8();
int const b3 = get8();
datLen = Serializer::decodeVLLength(b1, b2, b3);
}
return datLen;
@@ -496,7 +496,7 @@ SerialIter::getSlice(std::size_t bytes)
{
if (bytes > remain_)
Throw<std::runtime_error>("invalid SerialIter getSlice");
Slice s(p_, bytes);
Slice const s(p_, bytes);
p_ += bytes;
used_ += bytes;
remain_ -= bytes;