ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-01 08:25:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a prepared statement to retrieve.

Browse Source
This commit is contained in:
JoelKatz
2013-01-28 01:54:01 -08:00
parent d9938fe033
commit 2466eba17b
1 changed files with 34 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/cpp/ripple/HashedObject.cpp
View File

@@ -90,7 +90,6 @@ void HashedObjectStore::bulkWrite()
} }
// cLog(lsTRACE) << "HOS: writing " << set.size(); // cLog(lsTRACE) << "HOS: writing " << set.size();
static boost::format fExists("SELECT ObjType FROM CommittedObjects WHERE Hash = '%s';");
static boost::format static boost::format
fAdd("INSERT OR IGNORE INTO CommittedObjects " fAdd("INSERT OR IGNORE INTO CommittedObjects "
"(Hash,ObjType,LedgerIndex,Object) VALUES ('%s','%c','%u',%s);"); "(Hash,ObjType,LedgerIndex,Object) VALUES ('%s','%c','%u',%s);");
@@ -135,28 +134,53 @@ HashedObject::pointer HashedObjectStore::retrieve(const uint256& hash)
} }
if (mNegativeCache.isPresent(hash)) if (mNegativeCache.isPresent(hash))
return HashedObject::pointer(); return obj;
if (!theApp || !theApp->getHashNodeDB()) if (!theApp || !theApp->getHashNodeDB())
return HashedObject::pointer(); return obj;
std::string sql = "SELECT * FROM CommittedObjects WHERE Hash='";
sql.append(hash.GetHex());
sql.append("';");
std::vector<unsigned char> data; std::vector<unsigned char> data;
std::string type; std::string type;
uint32 index; uint32 index;
#ifndef NO_SQLITE3_PREPARE
{
ScopedLock sl(theApp->getHashNodeDB()->getDBLock());
static SqliteStatement pSt(theApp->getHashNodeDB()->getDB()->getSqliteDB(),
"SELECT ObjType,LedgerIndex,Object FROM CommittedObjects WHERE Hash = ?;");
pSt.reset();
pSt.bind(1, hash.GetHex());
int ret = pSt.step();
if (pSt.isDone(ret))
{
mNegativeCache.add(hash);
cLog(lsTRACE) << "HOS: " << hash <<" fetch: not in db";
return obj;
}
type = pSt.peekString(0);
index = pSt.getUInt32(1);
pSt.getBlob(2).swap(data);
}
#else
std::string sql = "SELECT * FROM CommittedObjects WHERE Hash='";
sql.append(hash.GetHex());
sql.append("';");
{ {
ScopedLock sl(theApp->getHashNodeDB()->getDBLock()); ScopedLock sl(theApp->getHashNodeDB()->getDBLock());
Database* db = theApp->getHashNodeDB()->getDB(); Database* db = theApp->getHashNodeDB()->getDB();
if (!db->executeSQL(sql) || !db->startIterRows()) if (!db->executeSQL(sql) || !db->startIterRows())
{ {
// cLog(lsTRACE) << "HOS: " << hash << " fetch: not in db";
sl.unlock(); sl.unlock();
mNegativeCache.add(hash); mNegativeCache.add(hash);
return HashedObject::pointer(); return obj;
} }
db->getStr("ObjType", type); db->getStr("ObjType", type);
@@ -167,6 +191,7 @@ HashedObject::pointer HashedObjectStore::retrieve(const uint256& hash)
db->getBinary("Object", &(data.front()), size); db->getBinary("Object", &(data.front()), size);
db->endIterRows(); db->endIterRows();
} }
#endif
assert(Serializer::getSHA512Half(data) == hash); assert(Serializer::getSHA512Half(data) == hash);
@@ -181,7 +206,7 @@ HashedObject::pointer HashedObjectStore::retrieve(const uint256& hash)
assert(false); assert(false);
cLog(lsERROR) << "Invalid hashed object"; cLog(lsERROR) << "Invalid hashed object";
mNegativeCache.add(hash); mNegativeCache.add(hash);
return HashedObject::pointer(); return obj;
} }
obj = boost::make_shared<HashedObject>(htype, index, data, hash); obj = boost::make_shared<HashedObject>(htype, index, data, hash);