ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-27 14:35:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

doAccountLines micro-optimization.

Browse Source
This commit is contained in:
JoelKatz
2013-05-21 15:40:44 -07:00
parent a6bbef4718
commit 23eafaab85
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/cpp/ripple/RPCHandler.cpp
View File

@@ -1071,9 +1071,6 @@ Json::Value RPCHandler::doAccountLines(Json::Value jvRequest, int& cost, ScopedL
{ {
jvResult["account"] = raAccount.humanAccountID(); jvResult["account"] = raAccount.humanAccountID();
// XXX This is wrong, we do access the current ledger and do need to worry about changes.
// We access a committed ledger and need not worry about changes.
AccountItems rippleLines(raAccount.getAccountID(), lpLedger, AccountItem::pointer(new RippleState())); AccountItems rippleLines(raAccount.getAccountID(), lpLedger, AccountItem::pointer(new RippleState()));
Json::Value& jsonLines = (jvResult["lines"] = Json::arrayValue); Json::Value& jsonLines = (jvResult["lines"] = Json::arrayValue);
@@ -1083,9 +1080,9 @@ Json::Value RPCHandler::doAccountLines(Json::Value jvRequest, int& cost, ScopedL
if (!raPeer.isValid() || raPeer.getAccountID() == line->getAccountIDPeer()) if (!raPeer.isValid() || raPeer.getAccountID() == line->getAccountIDPeer())
{ {
STAmount saBalance = line->getBalance(); const STAmount& saBalance = line->getBalance();
STAmount saLimit = line->getLimit(); const STAmount& saLimit = line->getLimit();
STAmount saLimitPeer = line->getLimitPeer(); const STAmount& saLimitPeer = line->getLimitPeer();
Json::Value& jPeer = jsonLines.append(Json::objectValue); Json::Value& jPeer = jsonLines.append(Json::objectValue);
@@ -2610,6 +2607,7 @@ Json::Value RPCHandler::lookupLedger(Json::Value jvRequest, Ledger::pointer& lpL
case LEDGER_CURRENT: case LEDGER_CURRENT:
lpLedger = mNetOps->getCurrentSnapshot(); lpLedger = mNetOps->getCurrentSnapshot();
iLedgerIndex = lpLedger->getLedgerSeq(); iLedgerIndex = lpLedger->getLedgerSeq();
assert(lpLedger->isImmutable() && !lpLedger->isClosed());
break; break;
case LEDGER_CLOSED: case LEDGER_CLOSED: